Jump to content

[1.11.2] ISidedInventory#canInsertItem not being called


Tschipp

Recommended Posts

I want to make it so that a slot from my machine is accessable from up and all the sides, but the  ISidedInventory#canInsertItem method doesn't seem to get called... ever. I've checked with the debug tool.

This is my method, but as I said it isn't even being called.. Am I understanding something wrong?

 

@Override
	public boolean canInsertItem(int index, ItemStack stack, EnumFacing direction) {
		return  (direction == EnumFacing.EAST || direction == EnumFacing.NORTH || direction == EnumFacing.SOUTH || direction == EnumFacing.WEST || direction == EnumFacing.UP) && index == 9;
	}

 

Link to comment
Share on other sites

5 minutes ago, Tschipp said:

(direction == EnumFacing.EAST || direction == EnumFacing.NORTH || direction == EnumFacing.SOUTH || direction == EnumFacing.WEST || direction == EnumFacing.UP)

Why all this? You can also just check once if it isn't EnumFacing.DOWN...

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Link to comment
Share on other sites

9 hours ago, Kokkie said:

Why all this? You can also just check once if it isn't EnumFacing.DOWN...

Whoops xD

 

But still, I removed all this and just return true all the time, I also added a print statement... nothing. The method is supposed to be executed when a hopper tries to insert an item into the machine, right? Becasue the ISidedInventory#canExtractItem method gets executed when a hopper tries to pull items out of it...

Edited by Tschipp
Link to comment
Share on other sites

It's an old, bad API which is still used by Minecraft itself, while capabilities are added by Forge to offer much better compatibility between mods. If you still use IInventory/ISidedInventory, most mods wouldn't know how to interact with your inventories, and can't be used in automation.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

18 minutes ago, larsgerrits said:

It's an old, bad API which is still used by Minecraft itself, while capabilities are added by Forge to offer much better compatibility between mods. If you still use IInventory/ISidedInventory, most mods wouldn't know how to interact with your inventories, and can't be used in automation.

Ok, I see. But in this case, automation really doesn't matter. The block just gives you some text information about the item that you put in, so it's only useable by players. I'll still take a look at the capability thing, in the long run it seems less complicated.

Link to comment
Share on other sites

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/ores/block/BlockMillstone.java#L73-L95

 

Lines 77 and 83 are the important ones for your usage.  Most of the rest of that method is just to give an achievement.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.