Jump to content

Recommended Posts

Posted

I just started modding again after taking a long break, and have been porting my projects from 1.7.10 to 1.10.2, most of it has gone smoothly and i've figured out the new ways of doing things.

 

However in one of my mods i have an item with a custom renderer that rendered a gun, this gun had a number of customizable parts (barrel extension, stock, scope) that could be changed around on the fly, to accomplish this i used a model that simply rendered different parts depending on which were turned on.

 

How would i accomplish this with 1.10?, I havent worked out how to register an item renderer (if thats even possible) and while i could do it with 70 different json files (1 for each combination of attachments) i feel like there must be a more elegant solution, any ideas?

Posted

Okay I've had a look around at BakedModels and from what i've seen I think I should make a seperate .json for each part of the model, load those in, and then use a custom IBakedModel to combine them. What I cant work out is how i would register all this to an item

Posted

So i decided to try something basic to see how this all works before i try anything fancy, took a look around to see if i could find anything on how it does and came up with something, it doesnt work however. I have an item called cttest, for which there is a existing model cttest.json, im trying apply the custom model cttestmeme.json, but it always just loads cttest

 

The Item

public class CTItem extends Item {

	protected String name;

	public CTItem(String name) {
		this.name = name;
		setUnlocalizedName(name);
		setRegistryName(name);
	}

	public void registerItemModel() {
		CreeperTech.proxy.registerItemRenderer(this, name);
	}

	@Override
	public CTItem setCreativeTab(CreativeTabs tab) {
		super.setCreativeTab(tab);
		return this;
	}

}

 

The relevant Proxy code 

	@Override
	public void registerItemRenderer(Item item, String id) {	
		ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(Reference.modID + ":" + id));
	}
	
	@Override
	public void registerClientEvents() {
		Helper.WriteModMessage("Actually Registering Shit");
		MinecraftForge.EVENT_BUS.register(new CTModelBaker());
	}

 

The ModelBakeEvent code, note the object always seems to be null so the code never enters the "really bakin" section

@SideOnly(Side.CLIENT)
public class CTModelBaker {
	@SubscribeEvent
	public void onModelBakeEvent(ModelBakeEvent event) {
		Helper.WriteModMessage("We're bakin boys");
		ModelResourceLocation model = new ModelResourceLocation(Reference.modID + ":" + CreeperTech.ItemCTTest.getUnlocalizedName());
		Object object = event.getModelRegistry().getObject(model);
		if (object != null) {
			Helper.WriteModMessage("Really bakin");
			ModelCTTest customModel = new ModelCTTest();
			event.getModelRegistry().putObject(model, customModel);
		}
	}
}

 

The Model Code

public class ModelCTTest implements IBakedModel {
	public IBakedModel base;
	
	public ModelCTTest() {
		base = Minecraft.getMinecraft().getRenderItem().getItemModelMesher().getModelManager().getModel(new ModelResourceLocation(Reference.modID + ":" + CreeperTech.ItemCTTest.getUnlocalizedName() + "meme"));
	}
	
	
	@Override
	public List<BakedQuad> getQuads(IBlockState state, EnumFacing side, long rand) {
		return base.getQuads(state, side, rand);
	}

	@Override
	public boolean isAmbientOcclusion() {
		return base.isAmbientOcclusion();
	}

	@Override
	public boolean isGui3d() {
		return base.isGui3d();
	}

	@Override
	public boolean isBuiltInRenderer() {
		return base.isBuiltInRenderer();
	}

	@Override
	public TextureAtlasSprite getParticleTexture() {
		return base.getParticleTexture();
	}

	@Override
	public ItemCameraTransforms getItemCameraTransforms() {
		return base.getItemCameraTransforms();
	}

	@Override
	public ItemOverrideList getOverrides() {
		return base.getOverrides();
	}

}

 

And from my main modfile in preinit

		ItemCTTest = new CTItem("cttest");
		ItemCTTest.setCreativeTab(DIMmod.TabDIM);
		GameRegistry.register(ItemCTTest);
		ItemCTTest.registerItemModel();
		

		
		proxy.registerClientEvents();

 

Most of what ive worked out has probably come from outdated stuff, so any help is greatly appreciated

Posted

Thanks, it can now register a custom model, however the issue now is that i cant load the replacement model (cttestmeme) in the constructor of ModelCTTest, it throws nullpointerexception which i traced to the ItemModelMesher not existing, and all in all i think im probably doing it wrong.

 

I rewrote my model code to manually draw something and that worked fine, so registering the new model works, however my ultimate goal is to be able to load a new model from .json and merge that with the existing model. So how would i go about loading another model (not associated with any item)?

Posted

I've looked at these interfaces and there implementation in the source, and i cant work out what i need to do with them

 

I tried this in my model class but it was throwing nullpointers on the attachment.bake line

public class BakedModelCTGun implements IBakedModel {
	public IBakedModel baseModel;
	public IBakedModel attachmentModel;
	public IModel attachment;
	
	public BakedModelCTGun(IBakedModel basemodel) {
		baseModel = basemodel;
		try {
			attachment = ModelLoaderRegistry.getModel(new ModelResourceLocation(Reference.modID + ":" + CreeperTech.ItemCTTest.name + "meme"));
		} catch (Exception e) {
			e.printStackTrace();
		}
		Function<ResourceLocation, TextureAtlasSprite> textureGetter;
		textureGetter = new Function<ResourceLocation, TextureAtlasSprite>()
        {
            public TextureAtlasSprite apply(ResourceLocation location)
            {
                return Minecraft.getMinecraft().getTextureMapBlocks().getAtlasSprite(location.toString());
            }
        };
		attachmentModel = attachment.bake(attachment.getDefaultState(), new VertexFormat(), textureGetter);
	}
	
	@Override
	public List<BakedQuad> getQuads(IBlockState state, EnumFacing side, long rand) {
		//return baseModel.getQuads(state, side, rand);
		return attachmentModel.getQuads(state, side, rand);
	}

 

Do i need to make my own ICustomModelLoader and register it with ModelLoaderRegistry? and if so, what do i need to actually put in the implementation because the implementations in the source (i.e. VanillaLoader) seem needlessly complicated for what im trying to do, and completely tied to ModelLoader

Posted

Why does the path to efficiency have to be paved with ridiculously convoluted code :/

 

I have written an ICustomModelLoader and registered it, and partially written an IModel and have got stuck

 

I have no clue what to write in IModel.bake as the only example I can find is VanillaModelWrapper and its .bake once again seems inordinately complicated for what i want to achieve

Posted

How do i bake that model though? My ModelLoader loads a ModelBlock from the .json and then that is stored in the IModel. I still have no clue what baking even is and i cant find any methods that bake a ModelBlock except VanillaModelWrapper, do i really have to write code to go and do all these operations from its .bake does and go through all the components and do all that crap with quads?

 

cause if i have to it'll probably just be easier for me to ignore jsons alltogether and just write a manual getQuads in my baked model

Posted

You told me to create an ICustomModelLoader that i register with ModelLoaderRegistry that loads a model from a .json and then makes my own IModel, the only way I could find to load a model from .json is in ModelBlock so im confused. How do i go about loading an IModel from a file, and if im doing that, why do i need a custom IModel if im meant to use whatever built in bake method comes with the IModel i load?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please see https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/ for information on how to post your log correctly.
    • Hello!  The detailed description of how you got to where you are is certainly valuable.  But, at the end of the day (well, any time of the day actually), it is going to be the actual logs that going to provide the necessary details to hopefully solve your startup issue. Part of me wonders if you have installed a client-only mod on a dedicated server.  But I may very well be wrong, and it will be the logs that will tell that story.
    • Hello there! I didn't quite know where to go regarding this, but ended up deciding to post it here. I have been running a forge server with around 200 mods for me and some friends to play on casually, but have recently started to get an issue when booting the server. This all started after I decided to add some new mods to the server. Like usual, I add a mod, test run the server for any issues, and if all is well, I'll add a next one and so on until I have added all that I wanted to. After doing so, in all test runs, it all seemed to work just fine. However, the next day, after trying to boot the server, I kept getting an error regarding java.lang.NullPointerException, towards one of the mods I had recently added. So far so good, I removed the mod that was causing the issue, started up the server again, and here in when things took a turn for the worse. I received another java.lang.NullPointerException null error that wouldn't allow me to boot the server, but this time with a mod that wasn't part of the new ones I had recently added. I found this weird, but nonetheless, I removed it thinking it might be causing some conflicts with some of the new ones. Afterwards, booting the server again proved to be impossible, as it gave me another java.lang.NullPointerException null error with the 3rd mod I had ever installed on the server! This mod was there since the start, it added some biomes and had been just fine so far. This turn of events made me remove all the newer mods I had recently added in hopes to fix this whole ordeal, but alas, to no avail. Same error, with that same biome mod that had been there since day one. Reluctantly, I removed the biome mod, booted the server, and voila! The server was running, although without a major mod that had always been there to begin with. As I do not wish to part ways with this mod, specially since it had been working so far without any issues, I tried to bring everything back to how it was before I added those new mods, but kept on getting the same java.lang.NullPointerException null error for the biome mod. Even adding the newer mods won't cause me this error, with exception of the one that started it all, which I find quite odd since the mods I had been using without any issues are now giving me the same error the newer one that started it all gave me. Now, I have checked that everything is up to date regarding the mods, forge (forge-1.20.1-47.3.12) and java. The modpack runs perfectly fine when I start Minecraft itself, and play singleplayer, or even when I open a LAN world, everything works. Everything aside from the server. From what I could gather, this java.lang.NullPointerException null error would point to a missing value of sorts, for an item perhaps, within the mod that is causing the error, but aside from removing the whole mod, I lack the knowledge on how to fix this. With this in mind, if anyone would be so kind as to shine some light into this situation, with a way to fix all this blunder, I would be most grateful!
    • If you want a mana GUI, call Minecraft.getInstance().setScreen(new ManaScreen()); somewhere display your GUI. I would recommend creating a keybind and listening to key events, and if your key bind is pressed down, running that code.
    • You are creating an entire new screen, or GUI. What you probably want is an Overlay.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.