Give achievement based on item in hand.

[ModderInTraining]

I have coded an achievement for wearing specific armor while holding a specific item in each hand. I have the coded it but I do not know how to figure out what isnt working, or why it isnt working.

My code:

        public void onTick(World world, EntityPlayer player, ItemStack itemStack) {
            int TitaniumArmorPeices = 0;
            if(player.getArmorInventoryList() != null) {
                Iterator<ItemStack> iterator = player.getArmorInventoryList().iterator();
                while(iterator.hasNext()) {
                    ItemStack stack = iterator.next();
                    if(stack != null) {
                        if(stack.getItem() instanceof ItemModArmor) {
                            ItemModArmor item = (ItemModArmor) stack.getItem();
                            if(item.getArmorMaterial() == ModArmor.TitaniumMaterial) {
                                TitaniumArmorPeices++;
                                continue;
                            }
                        }
                    }
                }
            }
            if(TitaniumArmorPeices == 4) {
                if(player.getHeldItemMainhand() != null) {
                    boolean iterator = player.getHeldItemMainhand().equals(ModCombat.titaniumSword);
                    while (player.getHeldItemOffhand() != null) {
                        boolean iterator1 = player.getHeldItemOffhand().equals(ModCombat.titaniumShield);
                        {
                                    continue;
                                }
                            }
                        }
                    }
                    if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
                        if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
                            player.addStat(AchievementHandler.achievementBattleReady);
                }
            }
        }

Edited March 12, 2017 by ModderInTraining
I forgot the code

[ModderInTraining]

How should I go about fixing this? Change ItemStack instances to Item instances?

 

[Jay Avery]

5 minutes ago, ModderInTraining said:

How should I go about fixing this? Change ItemStack instances to Item instances?

 

Yes, use ItemStack#getItem.

[ModderInTraining]

9 minutes ago, Jay Avery said:

Yes, use ItemStack#getItem.

Where should I put this?

 

[Draco18s]

I don't know. Maybe invoke it on the item stack in the player's hand?

[ModderInTraining]

 

5 minutes ago, Draco18s said:

I don't know. Maybe invoke it on the item stack in the player's hand?

I havent been modding very long, and dont know very much. What is invoking, and how do you do it?

[Jay Avery]

 

11 minutes ago, ModderInTraining said:

Where should I put this?

 

 

3 minutes ago, ModderInTraining said:

 

I havent been modding very long, and dont know very much. What is invoking, and how do you do it?

You should start by learning some general Java. ItemStack#getItem is a method which you call on an ItemStack instance, and returns an Item instance. You have access to an ItemStack (in the player's hand) and you want an Item (to compare to the correct Item for your achievement). If that isn't enough information for you to get started, you probably need a better understanding of Java before you will make much progress with modding.

[ModderInTraining]

Would this work?

 

        public void onTick(World world, EntityPlayer player, ItemStack itemStack) {
            int TitaniumArmorPeices = 0;
            if(player.getArmorInventoryList() != null) {
                Iterator<ItemStack> iterator = player.getArmorInventoryList().iterator();
                while(iterator.hasNext()) {
                    ItemStack stack = iterator.next();
                    if(stack != null) {
                        if(stack.getItem() instanceof ItemModArmor) {
                            ItemModArmor item = (ItemModArmor) stack.getItem();
                            if(item.getArmorMaterial() == ModArmor.TitaniumMaterial) {
                                TitaniumArmorPeices++;
                                continue;
                            }
                        }
                    }
                }
            }
            if(TitaniumArmorPeices == 4) {
                ItemStack getItem = player.getHeldItemMainhand();
                ItemStack getItem1 = player.getHeldItemOffhand();
                if(player.getHeldItemMainhand() != null) {
                    boolean iterator = player.getHeldItemMainhand().equals(ModCombat.titaniumSword);
                    while (player.getHeldItemOffhand() != null) {
                        boolean iterator1 = player.getHeldItemOffhand().equals(ModCombat.titaniumShield);
                        {
                                    continue;
                                }
                            }
                        }
                    }
                    if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
                        if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
                            player.addStat(AchievementHandler.achievementBattleReady);
                }
            }
        }

[Jay Avery]

Next time, please post your code using the <> button and a spoiler (eye icon), it makes it much easier to read.

 

24 minutes ago, ModderInTraining said:

if(TitaniumArmorPeices == 4) {
                ItemStack getItem = player.getHeldItemMainhand();
                ItemStack getItem1 = player.getHeldItemOffhand();
                if(player.getHeldItemMainhand() != null) {
                    boolean iterator = player.getHeldItemMainhand().equals(ModCombat.titaniumSword);
                    while (player.getHeldItemOffhand() != null) {
                        boolean iterator1 = player.getHeldItemOffhand().equals(ModCombat.titaniumShield);
                        {
                                    continue;
                                }
                            }
                        }
                    }
                    if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
                        if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
                            player.addStat(AchievementHandler.achievementBattleReady);
                }
            }

 

I'm really confused about what you're doing here.

• You declare two ItemStacks which you then never refer to (getItem and getItem1).
• You declare two booleans which you then never refer to (iterator and iterator1 - and why on earth did you pick such confusing variable names?)
• You still haven't used ItemStack#getItem in the way I suggested, so you are still comparing an ItemStack instance to an Item instance in the line player.getHeldItemMainhand().equals(ModCombat.titaniumSword).
• You're using a while loop for something which doesn't need to be looped at all, and seem to have a random mess of opening and closing brackets in the middle for no reason.
• You don't actually check any of the item conditions before applying the achievement.

Edited March 13, 2017 by Jay Avery

[Draco18s]

And you're still comparing an ItemStack to an Item

[ModderInTraining]

This is the only way I can figure of doing it, how would you suggest I do it?

 

[Draco18s]

It can't possibly be the only way you can figure out: it doesn't work for a variety of reasons.

You have a meaningless loop (for example, if player.getHeldItemOffhand() isn't null, it will loop forever and never exit so really, what did you expect?)

 

Have you tried player.getHeldItemOffhand().getItem() possibly?

[Jay Avery]

18 minutes ago, ModderInTraining said:

This is the only way I can figure of doing it, how would you suggest I do it?

 

I gave a list of the problems with your code, so try fixing those and then show us what you have if it still doesn't work as you want.

[ModderInTraining]

I tried this but it doesnt seem to accept boolean.

Spoiler

        public void onTick(World world, EntityPlayer player, ItemStack itemStack) {
            int TitaniumArmorPeices = 0;
            if(player.getArmorInventoryList() != null) {
                Iterator<ItemStack> iterator = player.getArmorInventoryList().iterator();
                while(iterator.hasNext()) {
                    ItemStack stack = iterator.next();
                    if(stack != null) {
                        if(stack.getItem() instanceof ItemModArmor) {
                            ItemModArmor item = (ItemModArmor) stack.getItem();
                            if(item.getArmorMaterial() == ModArmor.TitaniumMaterial) {
                                TitaniumArmorPeices++;
                                continue;
                            }
                        }
                    }
                }
            }
            if(TitaniumArmorPeices == 4) {
                boolean (player.getHeldItemMainhand().getItem().equals(ModCombat.titaniumSword) = true) {
                    boolean (player.getHeldItemOffhand().getItem().equals(ModCombat.titaniumShield) = true) {
                            }
                        }
                    }
                    if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
                        if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
                            player.addStat(AchievementHandler.achievementBattleReady);
                }
            }
        }

Edited March 13, 2017 by ModderInTraining

[ModderInTraining]

My code for checking the armor is working fine, the item in hand is where im struggling.

 

[ModderInTraining]

Spoiler

		public void onTick(World world, EntityPlayer player, ItemStack itemStack) {
			int TitaniumArmorPeices = 0;
			if(player.getArmorInventoryList() != null) {
				Iterator<ItemStack> iterator = player.getArmorInventoryList().iterator();
				while(iterator.hasNext()) {
					ItemStack stack = iterator.next();
					if(stack != null) {
						if(stack.getItem() instanceof ItemModArmor) {
							ItemModArmor item = (ItemModArmor) stack.getItem();
							if(item.getArmorMaterial() == ModArmor.TitaniumMaterial) {
								TitaniumArmorPeices++;
								continue;
							}
						}
					}
				}
			}
			if(TitaniumArmorPeices == 4) {
				if(player.getHeldItemMainhand().getItem().equals(ModCombat.titaniumSword)) {
					if(player.getHeldItemOffhand().getItem().equals(ModCombat.titaniumShield)) {
							}
						}
					}
					if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
						if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
							player.addStat(AchievementHandler.achievementBattleReady);
				}
			}
		}

 

Can someone explain why this isnt working?

 

[ModderInTraining]

So am i closing it too early? Should I move the brackets to after I add the achievement?

 

[Draco18s]

[ModderInTraining]

Still no success. Im bad at this.

Spoiler

		public void onTick(World world, EntityPlayer player, ItemStack itemStack) {
			int TitaniumArmorPeices = 0;
			if(player.getArmorInventoryList() != null) {
				Iterator<ItemStack> iterator = player.getArmorInventoryList().iterator();
				while(iterator.hasNext()) {
					ItemStack stack = iterator.next();
					if(stack != null) {
						if(stack.getItem() instanceof ItemModArmor) {
							ItemModArmor item = (ItemModArmor) stack.getItem();
							if(item.getArmorMaterial() == ModArmor.TitaniumMaterial) {
								TitaniumArmorPeices++;
								continue;
							}
						}
					}
				}
			}
			if(TitaniumArmorPeices == 4) {
				if(player.getHeldItemMainhand().getItem().equals(ModCombat.titaniumSword)) {
					if(player.getHeldItemOffhand().getItem().equals(ModCombat.titaniumShield)) {
					if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
						if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
							player.addStat(AchievementHandler.achievementBattleReady);
							}
						}
					}
				}
			}
		}

 

[ModderInTraining]

2 minutes ago, diesieben07 said:

Yes, you are. Because you are trying to mod without Java knowledge. That's like saying "I am going to learn swimming by being dropped in the middle of the ocean. In a storm." No, you are not going to learn to swim (read: program), you are going to drown.

I have a basic knowledge of Java, but it is very basic and limited

 

[ModderInTraining]

Since your all such experienced programmers, how  would you do this.

[ModderInTraining]

Im doing this in the ItemModArmor Class

 

Edited March 13, 2017 by ModderInTraining

[Jay Avery]

1 hour ago, ModderInTraining said:

  Hide contents

		public void onTick(World world, EntityPlayer player, ItemStack itemStack) {
			int TitaniumArmorPeices = 0;
			if(player.getArmorInventoryList() != null) {
				Iterator<ItemStack> iterator = player.getArmorInventoryList().iterator();
				while(iterator.hasNext()) {
					ItemStack stack = iterator.next();
					if(stack != null) {
						if(stack.getItem() instanceof ItemModArmor) {
							ItemModArmor item = (ItemModArmor) stack.getItem();
							if(item.getArmorMaterial() == ModArmor.TitaniumMaterial) {
								TitaniumArmorPeices++;
								continue;
							}
						}
					}
				}
			}
			if(TitaniumArmorPeices == 4) {
				if(player.getHeldItemMainhand().getItem().equals(ModCombat.titaniumSword)) {
					if(player.getHeldItemOffhand().getItem().equals(ModCombat.titaniumShield)) {
							}
						}
					}
					if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
						if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
							player.addStat(AchievementHandler.achievementBattleReady);
				}
			}
		}

 

Can someone explain why this isnt working?

 

Your brackets are in the wrong places. This is really basic Java stuff that you're struggling with. I'm going to highlight each pair of opening and closing brackets in different colours so you can see:

 

if(TitaniumArmorPeices == 4) {            if(player.getHeldItemMainhand().getItem().equals(ModCombat.titaniumSword)) {                if(player.getHeldItemOffhand().getItem().equals(ModCombat.titaniumShield)) {
                        }
                    }
                }                if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {

if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {                        player.addStat(AchievementHandler.achievementBattleReady);
            }
        }

 

The red brackets are executed if the offhand item is a titaniumShield. The blue brackets are executed if the mainhand item is a titaniumSword. Can you see that both of those brackets have no actual code inside?

Edited March 13, 2017 by Jay Avery

[ModderInTraining]

Im using this, (code inside the proper brackets) but its still not firing 

Spoiler

		public void onTick(World world, EntityPlayer player, ItemStack itemStack) {
			int TitaniumArmorPeices = 0;
			if(player.getArmorInventoryList() != null) {
				Iterator<ItemStack> iterator = player.getArmorInventoryList().iterator();
				while(iterator.hasNext()) {
					ItemStack stack = iterator.next();
					if(stack != null) {
						if(stack.getItem() instanceof ItemModArmor) {
							ItemModArmor item = (ItemModArmor) stack.getItem();
							if(item.getArmorMaterial() == ModArmor.TitaniumMaterial) {
								TitaniumArmorPeices++;
								continue;
							}
						}
					}
				}
			}
			if(TitaniumArmorPeices == 4) {
				if(player.getHeldItemMainhand().getItem().equals(ModCombat.titaniumSword)) {
					if(player.getHeldItemOffhand().getItem().equals(ModCombat.titaniumShield)) {
					if(player.hasAchievement(AchievementHandler.achievementBulletProof)) {
						if(!player.hasAchievement(AchievementHandler.achievementBattleReady)) {
							player.addStat(AchievementHandler.achievementBattleReady);
							}
						}
					}
				}
			}
		}

 

[ModderInTraining]

Does any one have a good source for me to use to better learn java?