[1.10] Retrieving tablist data

[Konako]

Hi, I'm trying to receive the data from the tablist, most notably the footer and header.

 

Here is the method I am using to obtain the private fields. I try to check for both the forge name and vanilla: 

private String getPrivateStringFieldFromObject(Object object, String forgeFieldName, String vanillaFieldName)
            throws NoSuchFieldException, SecurityException, IllegalArgumentException,
            IllegalAccessException {
        Field targetField = null;
        try {
            targetField = object.getClass().getDeclaredField(forgeFieldName);
        } catch (NoSuchFieldException e) {
            targetField = object.getClass().getDeclaredField(vanillaFieldName);
        }
        if (targetField != null) {
            targetField.setAccessible(true);
            return String.valueOf(targetField.get(object).toString()).toString();
        } else {
            return "";
        }
    }

Here is the call that I use: 

getPrivateStringFieldFromObject(minecraft.ingameGUI.getTabList().getClass(), "footer", "field_175255_h") 

however I get java.lang.NoSuchFieldException after catching the first one. I don't see how I'm not getting the footer.

[Draco18s]

Odds are you have the wrong SRG name (not vanilla name, btw, the vanilla name would be something like aaa1).  Looking at the MCPBot exports there are two fields with the MCP name "footer." You're using the first one.  The other one has the SRG name "field_179702_b"

[Konako]

24 minutes ago, Draco18s said:

Odds are you have the wrong SRG name (not vanilla name, btw, the vanilla name would be something like aaa1).  Looking at the MCPBot exports there are two fields with the MCP name "footer." You're using the first one.  The other one has the SRG name "field_179702_b"

The SRG name you provided does the same error.

[Draco18s]

4 hours ago, diesieben07 said:

There is one entry for GuiPlayerTabOverlay.footer and it is field_175255_h.

Notice how I can literally not tell what class a field belongs to in the CSV:

Yes, I know there's an IRC interface that makes things non-ambiguous, but that's rather a bit cumbersome.

[Draco18s]

7 minutes ago, diesieben07 said:

Well, it gives you correct results though...

Yes, using the right field name definitely does.  But having the wrong one throws a NoSuchFieldException which is what the OP was getting.

[Konako]

11 hours ago, diesieben07 said:

Doing it this way is kinda a bad idea. You should look up the Field object once and store it in a static final field. The Field lookup (getDeclaredField) is the slow part about reflection.

Also always directly specify the class-name when using getDeclaredField, you don't know what the exact class of the object will be.

 

The problem why it doesn't work is because you pass in the GuiPlayerTabOverlay.class object into getPrivateStringFieldFromObject. But the method getPrivateStringFieldFromObject assumes the object passed in is the object to access the field from.

 

I suggest just doing something like this:

private static final Field myField = ReflectionHelper.findField(GuiPlayerTabOverlay.class, "field_175255_h", "footer");

// later
myField.get(object);

 

What object do I have to pass in to access the field from in this instance?

[Draco18s]

BTW:

String.valueOf(targetField.get(object).toString()).toString()

How many times do you really need to convert to a string?