Jump to content
Currently supported: All versions

[SOLVED] ForgeGradle jarsigner returned: 1

Bektor

By Bektor
in ForgeGradle

 Share

Recommended Posts

Bektor Dragon Slayer

Bektor

Posted
Posted (edited)

Hi,

 

I'm currently trying to sign my jars, but I'm running into this error:

  

:signJar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':signJar'.
> jarsigner returned: 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 5.76 secs

 

My code for signing the jar: 

// propeties found in %homepath% under .gradle
task signJar(type: SignJar, dependsOn: reobfJar) {
	onlyIf {
		project.hasProperty('keystore')
	}
	
	keyStore = project.keyStore
	alias = project.keyStoreAlias
	storePass = project.keyStorePass
	keyPass = project.keyStoreKeyPass
	inputFile = jar.archivePath
	outputFile = jar.archivePath
}

build.dependsOn signJar

 

The keyStore has the filetype gpg.

  Reveal hidden contents

 

Thx in advance.

Bektor

Edited by Bektor

Developer of Primeval Forest.

HashtagShell Stone Miner

HashtagShell

Posted
Posted (edited)
  On 4/20/2017 at 7:39 PM, Bektor said:

* Try: Run with --stacktrace option to get the stack trace.

Expand  
 
 
 

Stack traces are useful!

 

Also, ForgeGradle is a (kinda) separate project from Forge, and has its own wiki https://forgegradle.readthedocs.io/

 

Googling got me this: https://gist.github.com/matthewprenger/9b2da059b89433a01c1c

 

Searching the FG git repo got me this:

https://github.com/MinecraftForge/ForgeGradle/blob/c438b06df6339a6763e1549ebfa7b039100c1c0c/src/main/java/net/minecraftforge/gradle/tasks/SignJar.java#L94

Which delegates the signJar call to ant:

https://ant.apache.org/manual/Tasks/signjar.html

Which delegates the call to JDK jarsigner:

http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jarsigner.html

Edited by HashtagShell
I used Google some more!
Bektor Dragon Slayer

Bektor

Posted
  • Author
Posted (edited)
  On 4/20/2017 at 7:59 PM, HashtagShell said:

Stack traces are useful!

 

Also, ForgeGradle is a (kinda) separate project from Forge, and has its own wiki https://forgegradle.readthedocs.io/

 

Googling got me this: https://gist.github.com/matthewprenger/9b2da059b89433a01c1c

 

Searching the FG git repo got me this:

https://github.com/MinecraftForge/ForgeGradle/blob/c438b06df6339a6763e1549ebfa7b039100c1c0c/src/main/java/net/minecraftforge/gradle/tasks/SignJar.java#L94

Which delegates the signJar call to ant:

https://ant.apache.org/manual/Tasks/signjar.html

Which delegates the call to JDK jarsigner:

http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jarsigner.html

Expand  

Stacktrace when using jks files as your link used:

  Reveal hidden contents

 

Stacktrace when using gpg files as from before (which is actually the gradle doc using):

  Reveal hidden contents

 

Well, the wiki of ForgeGradle is really out of date.

 

EDIT: (gradle.properties) [same problem when changing keystore.gpg to keystore.jks as the tutorial from the link is using) 

keystore
keyStore=P:\ForgeMods\keystore.gpg
keyStoreAlias=XXXXXX
keyStorePass=XXXX
keyStoreKeyPass=XXXXX

 

Edited by Bektor

Developer of Primeval Forest.

HashtagShell Stone Miner

HashtagShell

Posted
Posted

Following the calls, you will get from gradle calling ant to ant calling the jarsigner tool and throwing an exception when it returns non-zero.

Thus, oracle's jarsigner tool failed. Debugging where exactly the failure was is hard, since the call to it is wrapped in an ExecTask.

It does tell us about code 1 though. Citing the doc for the jarsigner cmdline tool:

  Quote

 

Failure

Reasons why the jarsigner command fails include (but are not limited to) a command line parsing error, the inability to find a keypair to sign the JAR file, or the verification of a signed JAR fails.

failure

Code 1. The signing or verifying fails.

Expand  
 

Meaning SOMETHING went wrong. (well, isn't that a new one)

You'll probably want to run the jarsigner cmdline tool directly with an attached debugger and the exact same options that gradle would have constructed from your configs. Step through it step by step or put a breakpoint on the (I assume there is one) method call that terminates the program with an error code, and then look a level up the frame stack to see where the code is being 'thrown' exactly.

  • Like 1
Bektor Dragon Slayer

Bektor

Posted
  • Author
Posted

After a bit of debugging: 

keyStore=P:\ForgeMods\\keystore.jks

 

GPG which recommends the Gradle documentation for Gradle 3.5 does not work and without a '\\' Windows won't find it.

Also I had the random problem that Windows tried to make out of P:\ForgeMods\\keystore.jks this here: P:\ForgeMods\\P:\ForgeMods\\keystore.jks

I guess everyone sees that this won't work. Only a reboot of Windows had solved that problem (and I don't even know what caused it, just from one second to the other, windows put the path twice)

Developer of Primeval Forest.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept