Hi everyone. I was attempting to generate trees in the overworld, but I seem to have had little success.
Just wanted to see where I went wrong.
Thanks
 

package com.daposeidonguy.testmod.world;

import java.util.Random;

import com.daposeidonguy.testmod.ModBlocks;

import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Biomes;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenTrees;
import net.minecraftforge.fml.common.IWorldGenerator;

public class ModWorldGeneration implements IWorldGenerator {
	@Override
	public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
		if (world.provider.getDimension() == 0) {
			generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
		}
		
	}
	
	private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
		generateRubberTree(world, random, chunkX, chunkZ, 20);
		generateOre(ModBlocks.oreLead.getDefaultState(), world, random, chunkX, chunkZ, 12, 48, 8 + random.nextInt(5), 8);
	}
	
	private void generateRubberTree(World world, Random random, int chunkX, int chunkZ, int chances) {
		int x = chunkX * 16;
		int z = chunkZ * 16;
		BlockPos biomePos = new BlockPos(chunkX, 64, chunkZ);
		if(world.getBiome(biomePos)== Biomes.SWAMPLAND) {
			for(int i=0;i<chances;i++) {
				
				BlockPos pos = new BlockPos(x + random.nextInt(16), findGround(x,z,world) + 1,z + random.nextInt(16));
				
				WorldGenTrees generator = new WorldGenTrees(true, 4,  Blocks.COAL_BLOCK.getDefaultState(), Blocks.BOOKSHELF.getDefaultState(), false);
				generator.generate(world, random, pos);
				System.out.println("Generated tree");
			}
		}
		
	}
	
	private void generateOre(IBlockState ore, World world, Random random, int chunkX,int chunkZ, int minY, int maxY, int size, int chances) {
		int deltaY = maxY - minY;
		int x = chunkX * 16;
		int z = chunkZ * 16;
		
		for (int i=0; i< chances; i++) {
			BlockPos newPos = new BlockPos(x + random.nextInt(16), minY + random.nextInt(deltaY), z + random.nextInt(16));
		
			WorldGenMinable generator = new WorldGenMinable(ore, size);
			generator.generate(world, random, newPos);
		}
	}
	
	private int findGround(int x,int z, World world) {
		int y=255;
		boolean foundGround = false;
		while(foundGround == false && y > 0) {
			y = y -1;
			IBlockState block = world.getBlockState(new BlockPos(x,y,z));
			if (block == Blocks.GRASS.getDefaultState()) {
				foundGround = true;
			}
			else if (block == Blocks.DIRT.getDefaultState()) {
				foundGround = true;
			}
			else {
				foundGround = false;
			}
		}
		return y;
	}
	
}

 

Edited May 16, 20178 yr by Poseidon5001
Updated code

You are putting chunkX and chunkY directly to the position. It should be x and y, isn't it?

41 minutes ago, Abastro said:

You are putting chunkX and chunkY directly to the position. It should be x and y, isn't it?

Oh, you're right. Thank you! Hopefully that's the only thing that's wrong.

 

EDIT: Still doesnt seem to be working. I also updated the code embedded in the main post

Edited May 16, 20178 yr by Poseidon5001

I think you should do the same with biomePos(for World::getBiome), If I recall correctly the position is not the chunk coordinates, but positions of each block.

9 hours ago, Abastro said:

I think you should do the same with biomePos(for World::getBiome), If I recall correctly the position is not the chunk coordinates, but positions of each block.

It works! Thank you!