Jump to content

Recommended Posts

Posted (edited)

I'm new to the forum, so just putting this out here, I have experience with Java (and other similar languages), however I'm very new to modding Minecraft, so much so I'm still largely following any tutorials I can find.

 

However I've hit a block, and I can't seem to figure this out. I'm just trying to get what the player is holding upon right-clicking a block, and then doing something if that item the player is holding matches a specific item.

 

Here's the method I'm working with as it is now:

 

@Override
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) 
    { 
        if(!worldIn.isRemote)
        {
            TileEntity tileEntity = worldIn.getTileEntity(pos);
            if(tileEntity instanceof TileEntityJar) 
            {
                TileEntityJar jar = (TileEntityJar) tileEntity;
                
                if(playerIn.getActiveItemStack() != null)
                {
                    if(playerIn.getActiveItemStack() == new ItemStack(ModItems.cracker))
                    {
                        if(jar.addCracker())
                        {
                        int count = playerIn.getActiveItemStack().getCount();
                            playerIn.getActiveItemStack().setCount(count--);
                            return true;
                        }
                    }
                }
                jar.removeCracker();
            }
        }
        
        return true;
    }

 

Alternatively, the tutorial I'm following originally was using this:

 

@Override
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) 
    { 
        if(!worldIn.isRemote)
        {
            TileEntity tileEntity = worldIn.getTileEntity(pos);
            if(tileEntity instanceof TileEntityJar) 
            {
                TileEntityJar jar = (TileEntityJar) tileEntity;
                
                if(heldItem != null)
                {
                    if(heldItem.getItem() == ModItems.cracker)
                    {
                        if(jar.addCracker())
                        {
                            heldItem.stackSize--;
                            return true;
                        }
                    }
                }
                jar.removeCracker();
            }
        }
        return true;
    }

 

 

the "heldItem" keyword was something this person put in and it just worked, but for me I only get an error and I can't find any possible thing I did wrong. I don't know if there's an import I'm missing or what. Some help would really be appreciated.

 

Edited by JakeZ1990
Posted
  On 5/17/2017 at 10:22 AM, JakeZ1990 said:

if(playerIn.getActiveItemStack() == new ItemStack(ModItems.cracker))

Expand  

You are comparing by reference, and not by content. Additionally you are comparing an object by reference with a newly created object. That comparason will obviously always fail. 

The original tutorial you've linked compares an item from the itemstack with an item instance stored somewhere else. Items are singletons, meaning that that comparason can succeed. 

So that part turns into

if(playerIn.getActiveItemStack().getItem() == ModItems.cracker)

You might additionally want to check the damage value, if needed. It can be obtained with ItemStack::getMetadata() or ItemStack::getItemDamage()

Posted

you cannot compare an existing ItemStack to the one you just created like that... you're asking if it's the very same object. it is not.

ItemStack has GetItem method. compare results of those (items are singletons, you can do that). then do something with entire stack or just one item and reduce the count.

Posted

The heldItem parameter was removed from the method in 1.11, since you can get it from the EntityPlayer using EntityLivingBase#getHeldItem (EntityPlayer extends EntityLivingBase).

 

EntityLivingBase#getActiveItemStack only returns a non-empty ItemStack when the entity is actively using an item (e.g. blocking with a shield, drawing a bow).

 

ItemStacks can no longer be null in 1.11+, the default value is now the empty ItemStack. Use ItemStack#isEmpty to check if an ItemStack is empty. The ItemStack.EMPTY field contains an ItemStack that's always empty.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 5/17/2017 at 10:30 AM, V0idWa1k3r said:

You are comparing by reference, and not by content. Additionally you are comparing an object by reference with a newly created object. That comparason will obviously always fail. 

The original tutorial you've linked compares an item from the itemstack with an item instance stored somewhere else. Items are singletons, meaning that that comparason can succeed. 

So that part turns into

if(playerIn.getActiveItemStack().getItem() == ModItems.cracker)

You might additionally want to check the damage value, if needed. It can be obtained with ItemStack::getMetadata() or ItemStack::getItemDamage()

Expand  

I attempted your modification, however it still fails the check.

 

 

  On 5/17/2017 at 10:33 AM, Choonster said:

The heldItem parameter was removed from the method in 1.11, since you can get it from the EntityPlayer using EntityLivingBase#getHeldItem (EntityPlayer extends EntityLivingBase).

 

EntityLivingBase#getActiveItemStack only returns a non-empty ItemStack when the entity is actively using an item (e.g. blocking with a shield, drawing a bow).

 

ItemStacks can no longer be null in 1.11+, the default value is now the empty ItemStack. Use ItemStack#isEmpty to check if an ItemStack is empty. The ItemStack.EMPTY field contains an ItemStack that's always empty.

Expand  

 

I'm not quite sure how I'd utilize your information? As I said, I'm strictly following tutorials at this point, I'm not very familiar with MDKs code base at all.

Posted

Choonster's information explains why the check failed - player#getActiveItemStack only returns a stack if it's currently in use (like charging a bow). When a player right-clicks on your block, the item they're holding isn't in use, so player#getActiveItemStack will always be empty. If you want to know the stack they have in their hand (regardless of whether it's in use), you can use player#getHeldItem using the EnumHand parameter passed to the method (the player's current active hand).

Posted
  On 5/17/2017 at 11:04 AM, Jay Avery said:

Choonster's information explains why the check failed - player#getActiveItemStack only returns a stack if it's currently in use (like charging a bow). When a player right-clicks on your block, the item they're holding isn't in use, so player#getActiveItemStack will always be empty. If you want to know the stack they have in their hand (regardless of whether it's in use), you can use player#getHeldItem using the EnumHand parameter passed to the method (the player's current active hand).

Expand  

Okay, I get what you're saying, so I found a method I believe will do what I want:

if(playerIn.getHeldItem(hand) == (ModItems.cracker))

However, my issue now is that it's telling me Item and ItemStack are incompatible operand types.

Posted (edited)

That's because Item and ItemStack are different types. getHeldItem returns an ItemStack (not an Item). Use stack#getItem, like in V0idWa1k3r's first post.

Edited by Jay Avery
Posted (edited)
  On 5/17/2017 at 6:34 PM, Jay Avery said:

That's because Item and ItemStack are different types. getHeldItem returns an ItemStack (not an Item). Use stack#getItem, like in V0idWa1k3r's first post.

Expand  

Ohh! Yea, I knew they were different types. I was just being a dummy and forgot to check getHeldItem() for more sub-methods. So It's actually succeeding the If statement now, and placing crackers in the jar, which I can then take out, however, there is one last issue in my snippet.

int count = playerIn.getHeldItem(hand).getCount();
                            playerIn.getHeldItem(hand).setCount(count--);
                            return true;

For some reason, this section here is not decreasing the player's stack by 1.

 

[EDIT] Actually just fixed it by doing this instead:

playerIn.getHeldItem(hand).setCount(playerIn.getHeldItem(hand).getCount() - 1);
                            return true;

 

Although, if you don't mind, do you know why using the int like I was wasn't working?

Edited by JakeZ1990
Posted

You were using the postfix decrement operator (count--), which is applied after the rest of the expression is evaluated. So the code was saying "set this stack size to count, and then reduce the local count variable by 1". If you used the prefix operator (--count) it would reduce count by one before using it in the method. But there's also a simpler way of doing this in one line with no local variable - the method ItemStack#shrink will reduce the stack size of the stack by the number you give it.

  • Like 1
Posted
  On 5/17/2017 at 7:09 PM, Jay Avery said:

You were using the postfix decrement operator (count--), which is applied after the rest of the expression is evaluated. So the code was saying "set this stack size to count, and then reduce the local count variable by 1". If you used the prefix operator (--count) it would reduce count by one before using it in the method. But there's also a simpler way of doing this in one line with no local variable - the method ItemStack#shrink will reduce the stack size of the stack by the number you give it.

Expand  

Okay cool! Thanks a ton for the tip. Sorry for the late response, had to go to work. I'll be sure to mess around with that when I get the chance. I'm very happy you guys were all so kind to help me out so quickly. I'll definitely be coming here again if I hit another roadblock :)

(Hopefully with decreasing frequency, I've been pretty proud of my learning capabilities in the past, lol)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I am using Linux, I did Java --version and it shows I have Java 8 installed
    • Temu Coupon Code $100 Off [acu639380] For The USA This Month  Temu has become a go-to platform for online shopping in recent years, offering a vast selection of trendy items at unbeatable prices. With amazing discounts like the  Temu coupon code (acu639380) offering up to $100 Off for new users and exclusive offers for existing customers,  Temu is quickly cementing itself as a favorite among online shoppers. Whether you're looking for stylish fashion pieces, home essentials, or the latest gadgets, using  Temu 's promotional codes can help you save big on your purchases. In this blog, we’ll dive into all the incredible savings available this month, including details on the  Temu coupon codes (acu639380), which provide discounts like $100 Off for new and existing users, an additional 40% off, and even free gifts for first-time users. No matter where you’re located—whether in the United States, Canada, the UK, or beyond— Temu offers something for everyone. If you're looking to save money on your next shopping spree, keep reading to learn about all the best deals, discounts, and coupon codes you can use in June 2025. What is  Temu ? Before we dive into the details of the amazing  Temu coupon codes (acu639380), let’s first explore what  Temu is all about.  Temu is an online shopping platform that offers a massive range of products, from fashion and beauty items to home goods and electronics. With unbeatable prices, fast delivery, and free shipping to over 67 countries,  Temu is revolutionizing the way we shop online.  Temu is known for offering up to 90% off on certain items, which makes it an attractive option for budget-conscious shoppers. Whether you’re in the mood for trendy apparel, kitchen gadgets, or tech accessories,  Temu has something that fits your style and budget. Plus, with its regular sales events and exclusive coupon codes, there’s always an opportunity to save more. One of the biggest perks is the ability to combine discounts with promo codes like the  Temu coupon code (acu639380), which gives you a $100 discount for new users and additional savings for existing customers. Benefits of Using  Temu Coupon Codes  Temu coupon codes can offer significant discounts, and knowing how to take full advantage of these offers can lead to huge savings. The  Temu coupon code (acu639380) comes with a variety of benefits, such as: $100 Off for new users: This is a great way for new customers to enjoy  Temu ’s products at a fraction of the price. $100 Off for existing users: Loyal customers can still get a fantastic discount. 40% off: This discount code provides a solid extra savings on selected items. $100 coupon bundle: This is an exclusive offer for both new and existing users that lets you save on multiple purchases. Free gifts for new users: A welcome treat for first-time customers.  Temu Coupon Codes for June 2025 Now, let’s look at the  Temu coupon codes for June 2025 and how you can maximize your savings. These codes are designed to provide discounts based on your user status and location. Make sure to apply the  Temu coupon code (acu639380) when you check out to get the best deal possible! Here’s a breakdown of the  Temu coupon codes (acu639380) available:  Temu Coupon Code (acu639380) $100 Off for New Users Enjoy an instant $100 discount when you sign up for  Temu as a new user.  Temu Coupon Code (acu639380) $100 Off for Existing Users Loyal customers can also use this code to score a $100 discount on their next purchase.  Temu Coupon Code (acu639380) 40% Off Get up to 40% off on select items and categories—perfect for budget-savvy shoppers.  Temu $100 Coupon Bundle This bundle lets you apply a $100 discount on your shopping cart for both new and returning users.  Temu First Time User Coupon First-time buyers get an exclusive gift with this coupon code, alongside additional savings.  Temu Promo Code (acu639380) for June 2025 Use this code to unlock all of the June offers, including huge discounts on a wide variety of items. How  Temu Coupon Codes Help You Save More By using the  Temu coupon code (acu639380), you can access not only great discounts but also enjoy perks like free shipping and exclusive offers. The platform’s unbeatable prices, combined with these additional promo codes, create a shopping experience like no other. Let’s take a closer look at how each of these discounts can benefit you. $100 Off for new users: As a new user, you can score $100 Off on your first order with the  Temu coupon code (acu639380) for June 2025. This means you can shop for high-quality products like electronics, fashion, and home goods while spending less. $100 Off for existing users: Existing users also benefit from this promo code, which means even long-time shoppers can save big. The  Temu coupon code (acu639380) ensures that both new and loyal customers get an opportunity to save. 40% extra off: Certain categories are eligible for up to 40% off with this code. Whether you’re eyeing the latest tech gadget or refreshing your wardrobe, this extra discount can make a real difference to your total. Free gifts for new users: If you’re signing up for the first time,  Temu wants to welcome you with extra surprises. Use the  Temu first-time user coupon code to receive free gifts that’ll make your shopping experience even more enjoyable. $100 coupon bundle:  Temu has also created a special bundle that gives users—new and existing—a $100 discount on their orders. This bundle is perfect for those who love shopping in bulk and want to get the most value from their purchases. Where to Use  Temu Coupon Codes (acu639380)  Temu ships to over 67 countries, so no matter where you are, there’s a great deal waiting for you. Here’s a country-specific breakdown of how you can use the  Temu coupon code (acu639380) and enjoy incredible savings:  Temu Coupon Code $100 Off for USA: Residents of the United States can enjoy $100 Off their purchase using the  Temu coupon code (acu639380), which works for both new and existing users.  Temu Coupon Code $100 Off for Canada: Shoppers in Canada can save $100 on their orders when they apply the  Temu coupon code (acu639380), making it an excellent option for our neighbors to the north.  Temu Coupon Code $100 Off for UK: UK shoppers can also benefit from this amazing coupon code, ensuring they get $100 Off their next  Temu order.  Temu Coupon Code 40% Off for Mexico: Mexico-based shoppers can enjoy up to 40% off select items by using the  Temu coupon code (acu639380), which is ideal for those looking for exclusive savings.  Temu Coupon Code 40% Off for Brazil: Brazilian shoppers will be thrilled to know that they can apply the  Temu coupon code (acu639380) for up to 40% off on select items from the website.  Temu Coupon Code $100 Off for Japan: Shoppers in Japan can also take advantage of the  Temu coupon code (acu639380) and get $100 Off their purchases, which works for a wide range of products. Tips to Maximize Your Savings Stack Coupon Codes:  Temu allows users to stack certain discounts, so be sure to combine the  Temu coupon code (acu639380) with other promotional offers to get the best deal possible. Shop During Sales Events: Take advantage of major sales events like Black Friday, Cyber Monday, and holiday sales, when you can use  Temu coupon codes for even bigger discounts. Sign Up for Alerts: By signing up for  Temu ’s newsletter, you’ll be the first to know about new coupon codes, flash sales, and other special offers. Follow  Temu on Social Media:  Temu often shares exclusive discounts and codes on its social media platforms. Follow them to stay updated on the latest deals. Conclusion Whether you’re a first-time shopper or a loyal  Temu customer, using the  Temu coupon code (acu639380) is a smart way to save money on your favorite items. With discounts like $100 Off, up to 40% off, and exclusive coupon bundles,  Temu ensures that you never have to pay full price. With free shipping to over 67 countries, it’s easier than ever to shop for high-quality, affordable products that fit your budget. Don’t miss out on these amazing savings—apply the  Temu coupon code (acu639380) today and enjoy huge discounts on your next purchase.  
    • Make tests with different builds of these mods
    • it worked now. but is therre n outer way to use essential and forggematica?
    • Maybe a conflict with essential - make a test without it
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.