Jump to content

[1.10.2] Placing door from player interact event


Daeruin

Recommended Posts

I am trying to place a door from a PlayerInteractEvent, because I want to add some extra conditions on placing a door (I want to require two solid wood blocks where the hinge is going to be). I tried this:

 

Item heldItem = event.getEntityPlayer().getHeldItemMainhand().getItem();

if (heldItem instanceof ItemDoor)
{
	...check various conditions...
	IBlockState iblockstate = Block.getBlockFromItem(heldItem).getDefaultState().withProperty(BlockDoor.FACING, doorFacing).withProperty(BlockDoor.HINGE, isRightHinge ? BlockDoor.EnumHingePosition.RIGHT : BlockDoor.EnumHingePosition.LEFT);
	world.setBlockState(pos, iblockstate.withProperty(BlockDoor.HALF, BlockDoor.EnumDoorHalf.LOWER), 2);
	world.setBlockState(posUp, iblockstate.withProperty(BlockDoor.HALF, BlockDoor.EnumDoorHalf.UPPER), 2);
}

 

but it gives a null reference exception from Block.getBlockFromItem(heldItem) since the held item is not an instance of ItemBlock (it's an ItemDoor). I also tried BlockDoor.getDefaultstate()... but getDefaultState is not a static method, and I don't have an instance of BlockDoor to call it from. I can't make a new instance, because the constructor for BlockDoor is protected. ItemDoor has a block variable, but it's private. I also tried using ItemDoor's built-in placeDoor() method, but its parameters also require a BlockDoor, which I don't have.

 

What do I need to do here? Thanks in advance.

Edited by Daeruin
Link to comment
Share on other sites

22 minutes ago, Daeruin said:

I also tried BlockDoor.getDefaultstate()... but getDefaultState is not a static method, and I don't have an instance of BlockDoor to call it from. I can't make a new instance, because the constructor for BlockDoor is protected.

You DO have an instance of BlockDoor at net.minecraft.init.Blocks, You in fact have 6 of them there. Blocks are singletons.

But that will obviously only work with vanilla doors and only if you hard-code them. If you want your method to work with any door that uses an inplementation of ItemDoor to be placed you would need to use reflection to access the block field of ItemDoor

  • Like 1
Link to comment
Share on other sites

Blocks.DOOR.getDefaultState()

 

The method isn't static, therefor you need an instance and where do you find that?

 

The Blocks class. Where all the instances are stored.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

20 minutes ago, V0idWa1k3r said:

You DO have an instance of BlockDoor at net.minecraft.init.Blocks, You in fact have 6 of them there. Blocks are singletons.

But that will obviously only work with vanilla doors and only if you hard-code them. If you want your method to work with any door that uses an inplementation of ItemDoor to be placed you would need to use reflection to access the block field of ItemDoor

Ah, yes. That makes sense. I've used reflection before and could probably do it again. I'd much prefer a generic solution to hard coding the placement for each type of door. Thanks!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.