[1.11.2] Help needed with block registering

[diniboy]

Hi,

 

I am a newbie here, this is my first post, So please please be patient, give me some time to come into the mod writing.  I am just started meeting with the Minecraft modding, but I hope, I will understand all the important functions/methods at the near future!

 

I have created a 'mod' with the MDK for Forge 1.11.2, and that little 'mod' adds custom cauldron block to the game. At the Eclipse side, the code looks good, however in game, I Cannot give myself the block... So somehow it Cannot be renderred. And I don't see where is the problem exactly...  I pushed the code to Github, here is the link for the repository.

 

Any help is welcome!

 

Many thanks!

[diesieben07]

• Do not use the ItemModelMesher to register your models, use ModelLoader.setCustomModelResourceLocation in preInit from your client proxy.
• You never register an ItemBlock for your block, as such it can not exist in item form, i.e. in an inventory or as a dropped item. I suggest you read the documentation page on blocks.

[diniboy]

Thanks for Your quick reply!

14 minutes ago, diesieben07 said:

• Do not use the ItemModelMesher to register your models, use ModelLoader.setCustomModelResourceLocation in preInit from your client proxy.
• You never register an ItemBlock for your block, as such it can not exist in item form, i.e. in an inventory or as a dropped item. I suggest you read the documentation page on blocks.

I replaced the ItemModelMesher to the ModelManager, as You suggested. Thanks! Is that okay now (link)?

 

How exactly should this be done?

[Matryoshika]

ModelLoader has to be called in either preInit, after you register your block (as diesieben said in his post), OR in the ModelRegistryEvent (but only if you are using the RegistryEvent to register your block)

Edited June 2, 2017 by Matryoshika

[diesieben07]

You cannot use ModelLoader (or any other client-only class) from common code. It must be accessed only from your client proxy or other client-only classes.

Moreover your block still does not have an ItemBlock, so trying to register a model for that (nonexistent) ItemBlock is not going to do anything useful.

[jeffryfisher]

6 hours ago, diniboy said:

I am just started meeting with the Minecraft modding

There are many Forge mods at CurseForge, and many of them link to their source code at github. You can learn much from just walking through others' source code, especially if you can find a mod doing something like what you want to do.

[diniboy]

Well, I have done a lot of testing, but the block didn't appeared... I didn't pushed that tries to the Github, it was just done on my local repository, but as I haven't reached any result up to now, I think these steps are unnecessary.

 

If it isn't a big request, Can anybody help with some exact code parts, that must be changed? Many thanks!

 

Other: Is there any Javadoc somewhere for the Forge API?

 

BTW an example mod, with one custom block, one custom item, one tile entity, and so on, the basics might be very helpful for the beginners I think.

[Jay Avery]

We can't help you if we don't know what you've tried so far.

[Daeruin]

You may benefit from a straightforward beginner's tutorial like those from ShadowFacts.

 

https://shadowfacts.net/tutorials/forge-modding-1112/

 

You'll want to work through all the tutorials up through Basic Blocks to make sure you get all the pieces right.

[Daeruin]

This post also gives another example using the newer registration events and a couple simple items and blocks.

[diniboy]

Okay, now I Can render an item (and a block too, but with a bit different way)! But just with the old ItemModelMesher method:

 

    public void registerItemRenderer(ItemBase item, int meta, String id) {
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, new ModelResourceLocation(TestMod.MODID + ":" + id, "inventory"));
        
    }

 

The ModelLoader gives me an untextured object:

 

    public void registerItemRenderer(ItemBase item, int meta, String id) {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(TestMod.MODID + ":" + id, "inventory"));
    }

 

BTW I've followed the linked shadowfacts tutorial.

 

Thanks!

[Jay Avery]

Where do you call these methods? ModelLoader.setCustomModelResourceLocation needs to be in either FMLPreInitializationEvent or ModelRegistryEvent.

[diniboy]

I placed that function under the ClientProxy class.

[Draco18s]

That doesn't answer the question, when is it called? 

[diniboy]

From the main class, I call my block and item initializator class, and they are call another two classes. And theese executes the ModelLoader at the ClientProxy.

 

Anyways, why I shouldn't use the old method with the IMM? It is working perfectly for items. Just the blocks are buggy.

[Jay Avery]

In what events do you call those other classes? It's not about which class the method is in, it's about which stage of mod loading it happens in.

 

Edit: Posting all your up-to-date code would be the easiest solution.

Edited June 9, 2017 by Jay Avery

[diniboy]

In the FMLPreInitialization event.

 

Okay, I will merge the current state with the Github repo soon!

[diniboy]

There it is.

[Jay Avery]

17 hours ago, diniboy said:

In the FMLPreInitialization event.

You are still doing it in init.

Edited June 10, 2017 by Jay Avery

[diniboy]

2 minutes ago, Jay Avery said:

You are still doing it in init.

Ahh, sorry, I were silly! Now it is working So cool!

 

Thanks for all Your help guys!