[1.10.2] Adding to an enum not supported by class EnumHelper

[jeffryfisher]

For my next trick, I would like to add a new type of boat. Made from my netherworld rubies, it will be enchantable and able to sail upon lava.

 

Almost from the start, I have hit a snag. There's an enum within EntityBoat that looks like something I should extend so I don't need to copy-pasta an entire vanilla class.

 

Looking in EnumHelper, there's no public method specifically for adding a boat enum. The general-purpose addEnum method used by all public methods looks like my way out. However, at least in 1.10.2, it is private 

 

There are several directions I can go from here. I am leaning toward using reflection to access the private method inside EnumHelper. What do you guys do when faced with extending an enum not specifically supported by the public methods in EnumHelper?

 

Here's my stub of a new boat class:

public class RubyBoat extends ItemBoat {

  static final EntityBoat.Type TYPE;
  static final int ORDINAL;

  static {
    TYPE = EnumHelper.addEnum (EntityBoat.Type.class, "RUBY", String.class, "ruby");
    ORDINAL = TYPE.ordinal ();
  }

  public RubyBoat(String n) {
    super (TYPE);
    // TODO: Continue from here
  }
}

 

[Draco18s]

I was confused for a bit then realized that this is the ItemBoat class not the EntityBoat class.

 

You have a custom entity. Your entity is different than the EntityBoat class and does not have types.

 

Your Item does not need to extend ItemBoat at all. Just make a new one. What the item class does with that type is pass it to EntityBoat#setBoatType() which your boat isn't going to be paying attention to. So you could either make your own item class that doesn't inherit ItemBoat or pass in literally any type you want your entity is going to ignore it anyway.

 

Edit:

Checking my own code when I did a custom minecart...

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/ores/OresBase.java#L161

 

...it's null, that field is never assigned a value.

Edited June 3, 2017 by Draco18s

[jeffryfisher]

13 hours ago, Draco18s said:

Your entity is different than the EntityBoat class and does not have types.

So I should copy-pasta EntityBoat into a new class rather than trying to inject a new value into vanilla EntityBoat's enum? Perhaps my lava-going boat is different enough to need that, but I was hoping to re-use at least some of the code.

Edited June 3, 2017 by jeffryfisher

[Draco18s]

You don't need to copy anything at all. The value is meaningless for you.

[jeffryfisher]

On 6/3/2017 at 10:32 AM, Draco18s said:

You don't need to copy anything at all.

I think I'll need an entity to sail on lava (and water). If I can't work with the vanilla EntityBoat, then I won't be able to extend it. That'll leave me copying most of its code, but then maybe I was destined to do that anyway.

[Draco18s]

What part of "ignore the fuck out of that enum and pretend it doesn't exist" isn't making sense to you?

You can extend the vanilla classes left right and center and that enum can be ignored.