Jump to content

Recommended Posts

Posted

Just wondering if we are in a holding pattern on recipe registry, or am I missing something?

    @Deprecated //TODO Make IRecipe a registry
    public static IRecipe addShapedRecipe(ResourceLocation name, @Nonnull ItemStack output, Object... params)
    {
        throw new RuntimeException("TODO: Forge implement IRecipe registry");
        //return CraftingManager.addRecipe(output, params);
    }

    @Deprecated //TODO Make IRecipe a registry
    public static void addShapelessRecipe(ResourceLocation name, @Nonnull ItemStack output, Ingredient... params)
    {
        throw new RuntimeException("TODO: Forge implement IRecipe registry");
        //CraftingManager.getInstance().addShapelessRecipe(output, params);
    }

    @Deprecated //TODO Make IRecipe a registry
    public static void addRecipe(ResourceLocation name, IRecipe recipe)
    {
        throw new RuntimeException("TODO: Forge implement IRecipe registry");
        //CraftingManager.getInstance().getRecipeList().add(recipe);
    }

 

 

Posted

It's been four days since 1.12 was released, it usually takes the Forge team a couple of weeks to hammer out all the changes they need to make for Forge to be functional. It depends on the severity of the update (1.7 -> 1.8 took so long most modders waited for 1.10).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)

I was able to register recipes by copying the logic from 1.11.2 and making some adjustments to the code to include the new required name field which is used for the recipe book. There are other additional changes here as well.

 

It isn't complete since the names are not friendly but I needed something in order to register new recipes for vanilla objects since I didn't see a way to do that this early in the release.

NOTE: You will have to watch out for duplicate names otherwise you will get errors when starting minecraft when it's registering your recipes.

 

Shaped Recipe:

Spoiler

/**
 * This should only be used for registering recipes for vanilla objects and not mod-specific objects.
 * @param name The name of the recipe. ModID is pre-pended to it.
 * @param stack The output of the recipe.
 * @param recipeComponents The recipe components.
 */
public static void addShapedRecipe(String name, ItemStack stack, Object... recipeComponents)
{	
    name = @YOURMODIDHERE!!!@.toLowerCase() + ":" + name;
    String s = "";
    int i = 0;
    int j = 0;
    int k = 0;

    if (recipeComponents[i] instanceof String[])
    {
        String[] astring = (String[])((String[])recipeComponents[i++]);

        for (String s2 : astring)
        {
            ++k;
            j = s2.length();
            s = s + s2;
        }
    }
    else
    {
        while (recipeComponents[i] instanceof String)
        {
            String s1 = (String)recipeComponents[i++];
            ++k;
            j = s1.length();
            s = s + s1;
        }
    }

    Map<Character, ItemStack> map;

    for (map = Maps.<Character, ItemStack>newHashMap(); i < recipeComponents.length; i += 2)
    {
        Character character = (Character)recipeComponents[i];
        ItemStack itemstack = ItemStack.EMPTY;

        if (recipeComponents[i + 1] instanceof Item)
        {
            itemstack = new ItemStack((Item)recipeComponents[i + 1]);
        }
        else if (recipeComponents[i + 1] instanceof Block)
        {
            itemstack = new ItemStack((Block)recipeComponents[i + 1], 1, 32767);
        }
        else if (recipeComponents[i + 1] instanceof ItemStack)
        {
            itemstack = (ItemStack)recipeComponents[i + 1];
        }

        map.put(character, itemstack);
    }

    NonNullList<Ingredient> aitemstack = NonNullList.withSize(j * k, Ingredient.field_193370_a);

    for (int l = 0; l < j * k; ++l)
    {
        char c0 = s.charAt(l);

        if (map.containsKey(Character.valueOf(c0)))
        {
            aitemstack.set(l, Ingredient.func_193369_a(((ItemStack)map.get(Character.valueOf(c0))).copy()));
        }
    }

    ShapedRecipes shapedrecipes = new ShapedRecipes(name, j, k, aitemstack, stack);
	
	CraftingManager.func_193379_a(name, shapedrecipes);
}

 

 

Shapeless Recipe:

Spoiler

/**
 * This should only be used for registering recipes for vanilla objects and not mod-specific objects.
 * @param name The name of the recipe.
 * @param stack The output stack.
 * @param recipeComponents The recipe components.
 */
public static void addShapelessRecipe(String name, ItemStack stack, Object... recipeComponents)
{
    name = @YOURMODIDHERE!!!@.toLowerCase() + ":" + name;
    NonNullList<Ingredient> list = NonNullList.create();

    for (Object object : recipeComponents)
    {
        if (object instanceof ItemStack)
        {
            list.add(Ingredient.func_193369_a(((ItemStack)object).copy()));
        }
        else if (object instanceof Item)
        {
            list.add(Ingredient.func_193369_a(new ItemStack((Item)object)));
        }
        else
        {
            if (!(object instanceof Block))
            {
                throw new IllegalArgumentException("Invalid shapeless recipe: unknown type " + object.getClass().getName() + "!");
            }

            list.add(Ingredient.func_193369_a(new ItemStack((Block)object)));
        }
    }

    ShapelessRecipes shapelessRecipes = new ShapelessRecipes(name, stack, list);
	
	CraftingManager.func_193379_a(name, shapelessRecipes);
}

 

 

Example Usage:

Info: ModRegistry is a class I created for registering all of my mod specific things.

Shaped Recipe

Spoiler

ModRegistry.addShapedRecipe("stone_shears", new ItemStack(ModRegistry.StoneShears()),
		"a a",
		" b ",
		'a', Items.FLINT,
		'b', Item.getItemFromBlock(Blocks.COBBLESTONE));

 

 

Shaped Recipes within a loop.

Spoiler

for (int i = 0; i < 6; i++)
{
	// wood slabs into sticks.
	ModRegistry.addShapedRecipe("slab_to_stick" + ((Integer)i).toString(), new ItemStack(Items.STICK, 4), 
			"xx",
			"xx", 
			'x', 
			new ItemStack(Blocks.WOODEN_SLAB, 1, i));

	// Wooden slabs into planks.
	ModRegistry.addShapedRecipe("slab_to_plank" + ((Integer)i).toString(), new ItemStack(Blocks.PLANKS, 1, i),
			"x",
			"x",
			'x',
			new ItemStack(Blocks.WOODEN_SLAB, 1, i));
}

 

 

Shapeless Recipe

Spoiler

ModRegistry.addShapelessRecipe("glowstone", new ItemStack(Items.GLOWSTONE_DUST, 2), 
		new ItemStack(Items.REDSTONE),
		new ItemStack(Items.GUNPOWDER),
		new ItemStack(Items.DYE, 1, 11));

 

 

Edited by WuestMan
Putting code in spoilers

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • dynamictrees and dtneapolitan are the last mentioned mod - remove these
    • https://mclo.gs/9y5ciD2 anyone ever had this issue?  Internal exception illegal argument exception: unable to fit 3194354 into 3
    • Hi! I'm trying to add my custom models/textures renderer like this: public class PonyPlayerWrapperRenderer extends EntityRenderer<Player> { // wrapper class under my LivingEntityRenderer class implementation private final PonyPlayerRenderer innerRenderer; private final PonyPlayerRenderer innerSlimRenderer; public PonyPlayerWrapperRenderer(final EntityRendererProvider.Context context) { super(context); System.out.println("creating new PonyPlayerWrapperRenderer"); this.innerRenderer = new PonyPlayerRenderer(context, false); this.innerSlimRenderer = new PonyPlayerRenderer(context, true); } @Override public void render(final Player entity, final float yaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource bufferSource, final int packedLight) { System.out.println("PonyPlayerWrapperRenderer render: " + entity.toString()); if (entity instanceof AbstractClientPlayer clientPlayer) { if (clientPlayer.getModelName().contains("slim")) { innerSlimRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } else { innerRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } } } @Override public ResourceLocation getTextureLocation(final Player player) { System.out.println("PonyPlayerWrapperRenderer getTextureLocation"); if (player instanceof AbstractClientPlayer clientPlayer) { return clientPlayer.getSkinTextureLocation(); } System.out.println("player instanceof AbstractClientPlayer is false"); return getDefaultSkin(player.getUUID()); } } public class PonyPlayerRenderer extends LivingEntityRenderer<AbstractClientPlayer, PlayerModel<AbstractClientPlayer>> { private final PlayerModel<AbstractClientPlayer> earthModel; private final PlayerModel<AbstractClientPlayer> pegasusModel; private final PlayerModel<AbstractClientPlayer> unicornModel; public PonyPlayerRenderer(final EntityRendererProvider.Context context, final boolean slim) { super( context, slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)), 0.5f ); System.out.println("creating new PonyPlayerRenderer"); this.earthModel = slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); this.pegasusModel = new PegasusModel(context.bakeLayer(PegasusModel.LAYER_LOCATION)); this.unicornModel = new UnicornModel(context.bakeLayer(UnicornModel.LAYER_LOCATION)); } @Override public void render(final AbstractClientPlayer player, final float entityYaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource buffer, final int packedLight) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); this.model = switch (race) { case PEGASUS -> pegasusModel; case UNICORN -> unicornModel; case EARTH -> earthModel; }; super.render(player, entityYaw, partialTicks, poseStack, buffer, packedLight); } @Override public ResourceLocation getTextureLocation(final AbstractClientPlayer player) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); return switch (race) { case EARTH -> fromNamespaceAndPath(MODID, "textures/entity/earth_pony.png"); case PEGASUS -> fromNamespaceAndPath(MODID, "textures/entity/pegasus.png"); case UNICORN -> fromNamespaceAndPath(MODID, "textures/entity/unicorn.png"); }; } } @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { // mod bus render registration config @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onRegisterRenderers(final EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityType.PLAYER, PonyPlayerWrapperRenderer::new); System.out.println("onRegisterRenderers end"); } } Method onRegisterRenderers() is called and I can see it being logged. But when I enter the world, my PonyWrapperRenderer render() method doesn't ever seem to be called. I also tried to put my renderer to EntityRenderDispatcher's playerRenderers via reflection: @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onClientSetup(final FMLClientSetupEvent event) { event.enqueueWork(() -> { try { final EntityRenderDispatcher dispatcher = Minecraft.getInstance().getEntityRenderDispatcher(); final Field renderersField = getEntityRenderDispatcherField("playerRenderers"); final Field itemInHandRenderer = getEntityRenderDispatcherField("itemInHandRenderer"); @SuppressWarnings("unchecked") final Map<String, EntityRenderer<? extends Player>> playerRenderers = (Map<String, EntityRenderer<? extends Player>>)renderersField.get(dispatcher); final PonyPlayerWrapperRenderer renderer = new PonyPlayerWrapperRenderer( new EntityRendererProvider.Context( dispatcher, Minecraft.getInstance().getItemRenderer(), Minecraft.getInstance().getBlockRenderer(), (ItemInHandRenderer)itemInHandRenderer.get(dispatcher), Minecraft.getInstance().getResourceManager(), Minecraft.getInstance().getEntityModels(), Minecraft.getInstance().font ) ); playerRenderers.put("default", renderer); playerRenderers.put("slim", renderer); System.out.println("Player renderers replaced"); } catch (final Exception e) { throw new RuntimeException("Failed to replace player renderers", e); } }); } private static Field getEntityRenderDispatcherField(final String fieldName) throws NoSuchFieldException { final Field field = EntityRenderDispatcher.class.getDeclaredField(fieldName); field.setAccessible(true); return field; } } But I receive the error before Minecraft Client appears (RuntimeException: Failed to replace player renderers - from ClientRenderers onClientSetup() method - and its cause below): java.lang.IllegalArgumentException: No model for layer anotherlittlepony:earth_pony#main at net.minecraft.client.model.geom.EntityModelSet.bakeLayer(EntityModelSet.java:18) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererProvider$Context.bakeLayer(EntityRendererProvider.java:69) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerRenderer.<init>(PonyPlayerRenderer.java:32) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerWrapperRenderer.<init>(PonyPlayerWrapperRenderer.java:24) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.ClientRenderers.lambda$onClientSetup$0(ClientRenderers.java:79) ~[main/:?] {re:classloading} ... 33 more Problem appears when EntityRendererProvider context tries to bakeLayer with my model layer location: new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); // PonyPlayerRenderer.java:32 public class PonyModel extends PlayerModel<AbstractClientPlayer> { // the model class itself public static final ModelLayerLocation LAYER_LOCATION = new ModelLayerLocation( ResourceLocation.fromNamespaceAndPath(MODID, "earth_pony"), "main" ); public PonyModel(final ModelPart root) { super(root, false); } public static LayerDefinition createBodyLayer() { // some CubeListBuilder stuff for model appearance } } Textures PNGs are placed at: resources/assets/[my mod id]/textures/entity. My forge version is 1.20.1. Would appreciate any help.
    • Well, a bit more information about what you're trying to do would be helpful. e.g. why you're trying to use "INVOKE_ASSIGN" instead of "INVOKE". "INVOKE_ASSIGN" calls your code after the "target" is called and its value is stored, if applicable. "INVOKE" calls your code before the target is called. "target" expects a fully qualified name, as per the SpongePowered docs, if that name is going to be remapped (which it will be if your injecting into Minecraft itself and not another mod). For more information on fully qualified names versus canonical names, see the Java specifications. Here's an example of a working "@At" from my own code that targets the "getClosestsVulnerablePlayerToEntity" call inside a mob's logic: @At(value = "INVOKE_ASSIGN", target = "net.minecraft.world.World.getClosestVulnerablePlayerToEntity(Lnet/minecraft/entity/Entity;D)Lnet/minecraft/entity/player/EntityPlayer;") Hope this helps!
    • Ran it one more time just to check, and there's no errors this time on the log??? Log : https://mclo.gs/LnuaAiu I tried allocating more memory to the modpack, around 8000MB and it's still the same; stopping at "LOAD_REGISTRIES". Are some of the mods clashing, maybe? I have no clue what to do LOL
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.