Items Not Collectible / Add Pause

[Nathansmash9000]

I have a for loop, and the for loop drops items on the ground. Although, the items are sometimes not collectible, and I think it is because there needs to be a pause in between each time the for loop runs. Here's my code for my for loop:

for (int i = 0; i == 5, i ++)
{
	world.spawnItem(//spawn an item, code not shown);
	//add pause statement
}

If the problem isn't the pause, then please show me how to fix it. Thanks!

[Choonster]

There shouldn't need to be any pause between spawning items.

 

What's more likely is that you're spawning the items on both the logical client and server, when you should only be doing so on the server. See Forge's documentation for an explanation of sides.

 

If this isn't the case, post your actual code.

Edited June 23, 2017 by Choonster

[Nathansmash9000]

10 hours ago, Choonster said:

There shouldn't need to be any pause between spawning items.

 

What's more likely is that you're spawning the items on both the logical client and server, when you should only be doing so on the server. See Forge's documentation for an explanation of sides.

 

If this isn't the case, post your actual code.

Here's my code:

	@Override
	public void onBlockDestroyedByPlayer(World worldIn, BlockPos pos, IBlockState state) {
		// TODO Auto-generated method stub
		super.onBlockDestroyedByPlayer(worldIn, pos, state);
		Random random = new Random();
		int index = random.nextInt(GameRegistry.findRegistry(Item.class).getValues().size());
		
		if (this.name == "Lucky Ore")
		{
			generate();
		}
	}

	@Override
	public void onBlockDestroyedByExplosion(World worldIn, BlockPos pos, Explosion explosionIn) {
		// TODO Auto-generated method stub
		super.onBlockDestroyedByExplosion(worldIn, pos, explosionIn);

		if (this.name == "Lucky Ore")
		{
			generate();
		}
	}
	
	public void generate(){
		
		Random random = new Random();
		int index = random.nextInt(GameRegistry.findRegistry(Item.class).getValues().size());
		world.spawnEntity(new EntityItem(world, pos.getX(), pos.getY(), pos.getZ(), new ItemStack(GameRegistry.findRegistry(Item.class).getValues().get(index))));
		System.out.println("Item Dropped: " + GameRegistry.findRegistry(Item.class).getValues().get(index));
	}

 

[Jay Avery]

Choonster's guess was correct, you are spawning the item on both the logical server and logical client. You need to check that the world is not a client (!world.isRemote) before spawning any type of entity - and read the page Choonster linked to make sure you understand about sides.

[Kokkie]

Also, you should use breakBlock(), which is called if the block is replaced by another block (could be air, but also another block) instead of onBlockDestroyedByExplosion() and onBlockDestroyedByPlayer().