Jump to content

[1.11.2] [Unsolved] Overriding Village for Compatibility


OrangeVillager61

Recommended Posts

My mod overrides vanilla villages in order to add many changes to them and for them to go in different biomes. With some assistance from the forum helpers I was able to override the vanilla villages by having a new village file with a new village structures and then overrding the original villages with setting a new gen on InitMapGenEvent. However, this prevents villages and village buildings from other mods from spawning which is a serious issue. How do I override village structures and VILLAGE_SPAWN_BIOMES without overriding village stuff from other mods. (BTW, I'm very very bad with reflecting)

 

The actual act of changing the village gen:

 

public class ChangeVillageGeneration {

	@SubscribeEvent
	public void changeVillageGen (InitMapGenEvent event) {
		if (event.getType() != null && event.getType() == EventType.VILLAGE){
			IvMapGenVillage newGen = new IvMapGenVillage();
			event.setNewGen(newGen);
		}
	}	
	
}

 

Current Reflector:

 

ublic class Reflector {
	
	public static Object reflectMethod1(List<VillageStructures.PieceWeight> list, Random random, int size){
		
		Class reflectClass = net.minecraftforge.fml.common.registry.VillagerRegistry.class;
		Method method;
		try {
			method = reflectClass.getMethod("addExtraVillageComponents", VillageStructures.PieceWeight.class, Random.class, int.class);
			Object returnValue = method.invoke(null, list, random, size);
			return returnValue;
		} catch (NoSuchMethodException e) {
			// TODO Auto-generated catch block
			//e.printStackTrace();
		} catch (SecurityException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (IllegalAccessException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (IllegalArgumentException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (InvocationTargetException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		return null;
      }
	public static Village reflectMethod2(VillageStructures.Start start, VillageStructures.PieceWeight weight, List<StructureComponent> structureComponents, Random rand, int structureMinX, int structureMinY, int structureMinZ, EnumFacing facing, int componentType){
		
		Class reflectClass = net.minecraftforge.fml.common.registry.VillagerRegistry.class;
		Method method;
		try {
			method = reflectClass.getMethod("getVillageComponent", List.class, VillageStructures.Start.class, VillageStructures.PieceWeight.class, StructureComponent.class, Random.class, int.class, EnumFacing.class);
			Object returnValue = method.invoke(null, weight, start , structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
			Village returnObj = (Village) returnValue;
			return returnObj;
		} catch (NoSuchMethodException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (SecurityException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (IllegalAccessException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (IllegalArgumentException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (InvocationTargetException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		 {
			return null;
		}
      }
}

 

Edited by OrangeVillager61
Link to comment
Share on other sites

The Village Gen file:


 

public class IvMapGenVillage extends MapGenVillage
{
    private final static List<Biome> VILLAGE_SPAWN_BIOMES = Arrays.<Biome>asList(new Biome[] {Biomes.SAVANNA_PLATEAU, Biomes.PLAINS, Biomes.DESERT, Biomes.SAVANNA, Biomes.FOREST, Biomes.FOREST_HILLS, Biomes.TAIGA, Biomes.TAIGA_HILLS, Biomes.REDWOOD_TAIGA, Biomes.REDWOOD_TAIGA_HILLS, Biomes.MESA, Biomes.MESA_ROCK, Biomes.MESA_CLEAR_ROCK});
    /** None */
    private int size;
    private int distance;
    protected boolean isMetropolis;
    public Random r = new Random();
    private final int minTownSeparation;
    public IvMapGenVillage()
    {
        this.distance = Config.VillageDistance;
        this.minTownSeparation = 4;
        this.isMetropolis = true;
        if (r.nextInt(20) + 1 == 2 && Config.enable_Metro){
            this.isMetropolis = true;
        }
    }
    public IvMapGenVillage(Map<String, String> map)
    {
        this();
        
        for (Entry<String, String> entry : map.entrySet())
        {
            if (((String)entry.getKey()).equals("size"))
            {
                this.size = MathHelper.getInt((String)entry.getValue(), this.size, 0);
            }
            else if (((String)entry.getKey()).equals("distance"))
            {
                this.distance = MathHelper.getInt((String)entry.getValue(), this.distance, 9);
            }
        }
    }
    public String getStructureName()
    {
        return "Village";
    }
    protected boolean canSpawnStructureAtCoords(int chunkX, int chunkZ)
    {
        int i = chunkX;
        int j = chunkZ;
        if (chunkX < 0)
        {
            chunkX -= this.distance - 1;
        }
        if (chunkZ < 0)
        {
            chunkZ -= this.distance - 1;
        }
        int k = chunkX / this.distance;
        int l = chunkZ / this.distance;
        Random random = this.world.setRandomSeed(k, l, 10387312);
        k = k * this.distance;
        l = l * this.distance;
        k = k + random.nextInt(this.distance/2);
        l = l + random.nextInt(this.distance/2);
        if (i == k && j == l)
        {
            boolean flag = this.world.getBiomeProvider().areBiomesViable(i * 16 + 8, j * 16 + 8, 0, VILLAGE_SPAWN_BIOMES);
            if (flag)
            {
                return true;
            }
        }
        return false;
    }
    public BlockPos getClosestStrongholdPos(World worldIn, BlockPos pos, boolean p_180706_3_)
    {
        this.world = worldIn;
        return findNearestStructurePosBySpacing(worldIn, this, pos, this.distance, 8, 10387312, false, 100, p_180706_3_);
    }
    protected StructureStart getStructureStart(int chunkX, int chunkZ)
    {
        if (this.isMetropolis)
        {
            this.size = r.nextInt(1) + 4;
        }
        return new IvMapGenVillage.Start(this.world, this.rand, chunkX, chunkZ, this.size, this.isMetropolis);
    }
    public static class Start extends StructureStart
        {
            /** well ... thats what it does */
            private boolean hasMoreThanTwoComponents;
            public Start()
            {
            }
            public Start(World worldIn, Random rand, int x, int z, int size, boolean isMetro)
            {
                super(x, z);
                MapGenStructureIO.registerStructure(Start.class, "Village");
                List<VillageStructures.PieceWeight> list = VillageStructures.getStructureVillageWeightedPieceList(rand, size);
                VillageStructures.Start structurevillagepieces$start = new VillageStructures.Start(worldIn.getBiomeProvider(), 0, rand, (x << 4) + 2, (z << 4) + 2, list, size, isMetro);
                this.components.add(structurevillagepieces$start);
                structurevillagepieces$start.buildComponent(structurevillagepieces$start, this.components, rand);
                List<StructureComponent> list1 = structurevillagepieces$start.pendingRoads;
                List<StructureComponent> list2 = structurevillagepieces$start.pendingHouses;
                while (!list1.isEmpty() || !list2.isEmpty())
                {
                    if (list1.isEmpty())
                    {
                        int i = rand.nextInt(list2.size());
                        StructureComponent structurecomponent = (StructureComponent)list2.remove(i);
                        structurecomponent.buildComponent(structurevillagepieces$start, this.components, rand);
                    }
                    else
                    {
                        int j = rand.nextInt(list1.size());
                        StructureComponent structurecomponent2 = (StructureComponent)list1.remove(j);
                        structurecomponent2.buildComponent(structurevillagepieces$start, this.components, rand);
                    }
                }
                this.updateBoundingBox();
                int k = 0;
                for (StructureComponent structurecomponent1 : this.components)
                {
                    if (!(structurecomponent1 instanceof VillageStructures.Road))
                    {
                        ++k;
                    }
                }
                this.hasMoreThanTwoComponents = k > 2;
            }
            /**
             * currently only defined for Villages, returns true if Village has more than 2 non-road components
             */
            public boolean isSizeableStructure()
            {
                return this.hasMoreThanTwoComponents;
            }
            public void writeToNBT(NBTTagCompound tagCompound)
            {
                super.writeToNBT(tagCompound);
                tagCompound.setBoolean("Valid", this.hasMoreThanTwoComponents);
            }
            public void readFromNBT(NBTTagCompound tagCompound)
            {
                super.readFromNBT(tagCompound);
                this.hasMoreThanTwoComponents = tagCompound.getBoolean("Valid");
            }
        }
}

 

Edited by OrangeVillager61
Link to comment
Share on other sites

I think you are looking for net.minecraftforge.fml.common.registry.VillagerRegistry.addExtraVillageComponents in 

public static List<StructureVillagePieces.PieceWeight> getStructureVillageWeightedPieceList

Edited by Dylem
Link to comment
Share on other sites

3 hours ago, OrangeVillager61 said:

What do you mean by that?

Well, I assume that your function :

VillageStructures.getStructureVillageWeightedPieceList(rand, size)

function doesn't have the line :

net.minecraftforge.fml.common.registry.VillagerRegistry.addExtraVillageComponents(list, random, size);

 

Link to comment
Share on other sites

I think I do as reflectMethod2 is the method you are talking about:

 


    private static VillageStructures.Village findAndCreateComponentFactory(VillageStructures.Start start, VillageStructures.PieceWeight weight, List<StructureComponent> structureComponents, Random rand, int structureMinX, int structureMinY, int structureMinZ, EnumFacing facing, int componentType)
    {
        Class <? extends VillageStructures.Village > oclass = weight.villagePieceClass;
        VillageStructures.Village structurevillagepieces$village = null;

        if (oclass == VillageStructures.House4Garden.class)
        {
            structurevillagepieces$village = VillageStructures.House4Garden.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.Church.class)
        {
            structurevillagepieces$village = VillageStructures.Church.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.House1.class)
        {
            structurevillagepieces$village = VillageStructures.House1.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.WoodHut.class)
        {
            structurevillagepieces$village = VillageStructures.WoodHut.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.Hall.class)
        {
            structurevillagepieces$village = VillageStructures.Hall.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.Field1.class)
        {
            structurevillagepieces$village = VillageStructures.Field1.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.Field2.class)
        {
            structurevillagepieces$village = VillageStructures.Field2.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.House2.class)
        {
            structurevillagepieces$village = VillageStructures.House2.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else if (oclass == VillageStructures.House3.class)
        {
            structurevillagepieces$village = VillageStructures.House3.createPiece(start, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }
        else
        {
            structurevillagepieces$village = Reflector.reflectMethod2(start, weight, structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
        }

        return structurevillagepieces$village;
    }
public static Village reflectMethod2(VillageStructures.Start start, VillageStructures.PieceWeight weight, List<StructureComponent> structureComponents, Random rand, int structureMinX, int structureMinY, int structureMinZ, EnumFacing facing, int componentType){
		
		Class reflectClass = net.minecraftforge.fml.common.registry.VillagerRegistry.class;
		Method method;
		try {
			method = reflectClass.getMethod("getVillageComponent", List.class, VillageStructures.Start.class, VillageStructures.PieceWeight.class, StructureComponent.class, Random.class, int.class, EnumFacing.class);
			Object returnValue = method.invoke(null, weight, start , structureComponents, rand, structureMinX, structureMinY, structureMinZ, facing, componentType);
			Village returnObj = (Village) returnValue;
			return returnObj;
		} catch (NoSuchMethodException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (SecurityException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (IllegalAccessException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (IllegalArgumentException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (InvocationTargetException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		 {
			return null;
		}
      }

 

It may not work like that since I'm pretty bad with reflectors.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I tried to resolve the errors but I can't do it on my own, if anyone knows please help me Heres the log: https://paste.ee/p/JL1AA.  
    • Run jarfix https://johann.loefflmann.net/en/software/jarfix/index.html
    • Ich entschuldige mich schonmal im Voraus, falls es zu Kommunikationsproblemen  kommen sollte. Ich bin deutscher, etwas gestresst und habe gerade nicht wirklich die Nerven dafür, das alles ins englische zu übersetzen.   Ich habe mir in der Curseforge App 2 Mod-Profile für die Java Minecraft-Version 1.20.1 erstellt. eines für Forge-Mods und eines Für Fabric-Mods. Allerdings bekomme ich bei beiden eine Fehlermeldung, wenn ich Minecraft spielen will. Was kann ich tun? (Wenn es gebraucht wird, werde ich mir die Zeit nehmen und die Versionen und Ersteller der Mods und Recources raussuchen.)   Alle Mods, Resources und Modloader-packs sind auf der neusten Version Standpunkt 29.02.2024   - Forge: Meine Zusammenstellung besteht aus 121 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher und der Ladebildschirm taucht auf, bricht allerdings ab und bekomme eine Fehlermeldung. Fehlermeldung: The game crashed whilst initializing game Error: net.minecraftforge.fml.loading.EarlyLoadingException: Could not execute entrypoint stage 'main' due to errors, provided by 'eldritch_end'! Exitcode: -1 Wenn ich allerdings Eldrich End aus schalte, kommt ebenfalls eine. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoClassDefFoundError: Could not initialize class net.minecraft.client.renderer.RenderType Exitcode: -1 Liste der Mods: A.V.A-Alliance of  Valiant Arms Guns Ad Astra Additional Lanterns Additional Structures Alex's Mobs Aquacolture 2 Aquamirae (Forge) Architectury API (Fabric/Forge/NeoForge) Armore Statues [Forge & Fabric] Armored Redstone AzurLib Balm (Forge Editon) Better Villages - Fabric BetterF3 Biomes O' Plenty Blue Skies Botarium CalamityMusicDisc Camera Mod Charm of Undying (Fabric/Forge/Quilt) Citadel Clasic musical discs Cloth Config API (Fabric/Forge/NeoForge) Config API [Fabric/Forge/NeoForge/Quilt] Connected Glass Connector Extras Cristel Lib Curios API (Forge/NeoForge) Curious Armor Stands Denki's Music Disc DivineRPG (Official) Dragon Mounts: Legacy Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fish Tanks Forgified Fabric API Fussion (Connected Textures) Gamma Creatures GeckoLib Handcrafted HorkLord's Musik Discs Ice and Fire: Dragons Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Infinit Abyss Just Enough Items (JEI) Kotlin for Forge L_Enders Catalysm Library Ferret - Forge Macaw's Bridges Macaw's Doors Many More Music Discs [FORGE] MCEF (Minecraft Chromium Embedded  Framework) Mobs Head Modonomicon Monster Plus More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) Morer Music Discs (Records) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators MrCrayfish's Furniture Mod Multipart Machines: Mining Music Discs Galore Musical Instrument Minecraft Interface (MIMI) Musical Lib Mythic Mounts (Forge) Necronomicon API Nether Exorcism Netherrite Horse Armor CJ [Fabric/Forge/Quilt] Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Obscure Tooltips Occultism Ore Tree:Reeborn Patchouli Puzzles Lib [Forge & Fabric] Redstone engineering Redstone Lamp Plus Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Scuffy Music Disc Pack Securety Craft Shadowlands Sinytra Connector SmartBrainLib (Forge/Fabric/Quilt) Spawn Structory Structory: Towers Structure Gel API  SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Forge) The Ather The Graveyard (FORGE/NEOFORGE) The Twilight Forrest Towns and Towers Trash Cans Traveler' Backpack Valhelsia Core Valhelsia Structures Valkyrien Skies (Forge/Fabric) Waddles Waystones DebDisplays Wireles_Redstone Wither's Wepons YUNG'S API (Forge) YUNG'S Better Desert Temples (Forge) YUNG'S Better Dungeons (Forge) YUNG'S Better End Island (Forge) YUNG'S Better Jungle Temples (Forge) YUNG'S Better Mineshafts (Forge) YUNG'S Better Nether Fortresses (Forge) YUNG'S Better Ocean Monuments (Forge) YUNG'S Better Sreongholds (Forge) YUNG'S Better Witch Huts (Forge)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons     - Fabric: Meine Zusammenstellung besteht aus 61 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher, aber ich komme noch nicht einmal in den Ladebildschirm und drückt mir direkt eine Fehlermeldung rein. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoSuchMethodError: 'java.lang.Object[] org.apache.commons.lang3.ArrayUtils.addFirst(java.lang.Object[], java.lang.Object)' Exitcode: -1 Liste der Mods: Ad Astra Additional Lanterns Aquamirae (Fabric) Architectury API (Fabric/Forge/NeoForge) AzurLib Better Villages - Fabric BetterF3 Bosses Of Mass Destruction Botarium Cardinal Components API Cloth Config API (Fabric/Forge/NeoForge) Clutter Config API [Fabric/Forge/NeoForge/Quilt] Cristel Lib Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fabric API Fabric Language Kotlin GeckoLib Handcrafted Immersiv Armors (Fabric/Forge) Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Library Ferret - Fabric Macaw's Bridges Macaw's Doors More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators Mythic Mounts Necronomicon API Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Patchouli (Fabric) Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Spawn Structory Structory: Towers SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Fabric) The Graveyard (FABRIC) Towns and Towers Trash Cans Valkyrien Skies (Forge/Fabric) YUNG'S API (Fabric) YUNG'S Better Desert Temples (Fabric) YUNG'S Better Dungeons (Fabric) YUNG'S Better End Island (Fabric) YUNG'S Better Jungle Temples (Fabric) YUNG'S Better Mineshafts (Fabric) YUNG'S Better Nether Fortresses (Fabric) YUNG'S Better Ocean Monuments (Fabric) YUNG'S Better Sreongholds (Fabric) YUNG'S Better Witch Huts (Fabric)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons
    • When i click a jar file there's a black window popping out for a second then closing i don't know what to do, it's been happening for 2 days already
    • Hello, I don't have much experience with forge but I have some java knowledge, I want to add a button that says "Explore New Packs" to the Pause Screen that opens when we enter a world in the game and press the "esc" button, but I couldn't understand it (or I don't know how to use it), although I did research from artificial intelligence or different places. I was told that I can do it using mixins but I have no idea how to do it, can you explain step by step
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.