Jump to content

Recommended Posts

Posted (edited)

I am trying to use an InventoryBasic as an ItemStackHandler. I am trying to create a GUI for a player to view a villager's inventory. I am using the below method for a container for the inventory. As you can see, it needs to be a hander but the inventory is an InventoryBasic. Is there some way to convert it into an ItemStackHandler? The reason why it is an InventoryBasic is that I'm using modified vanilla code for my mob.

 

public class ContainerIvVillagerInventory extends Container{

	private IvVillager villager;
	
	private IItemHandler handler; 

	
	public ContainerIvVillagerInventory(IvVillager villager, IInventory playerInv){
		this.villager = villager;
		this.handler = this.villager.getVillagerInventory(); //Need the inventory here
		
		this.addSlotToContainer(new SlotItemHandler(handler, 0, 40, 66));
		this.addSlotToContainer(new SlotItemHandler(handler, 1, 58, 66));
		this.addSlotToContainer(new SlotItemHandler(handler, 2, 76, 66));
		this.addSlotToContainer(new SlotItemHandler(handler, 3, 94, 66));
		this.addSlotToContainer(new SlotItemHandler(handler, 4, 112, 66));
		this.addSlotToContainer(new SlotItemHandler(handler, 5, 40, 84));
		this.addSlotToContainer(new SlotItemHandler(handler, 6, 58, 84));
		this.addSlotToContainer(new SlotItemHandler(handler, 7, 76, 84));
		this.addSlotToContainer(new SlotItemHandler(handler, 8, 94, 84));
		this.addSlotToContainer(new SlotItemHandler(handler, 9, 112, 84));
		this.addSlotToContainer(new SlotItemHandler(handler, 10, 40, 102));
		this.addSlotToContainer(new SlotItemHandler(handler, 11, 58, 102));
		this.addSlotToContainer(new SlotItemHandler(handler, 12, 76, 102));
		this.addSlotToContainer(new SlotItemHandler(handler, 13, 94, 102));
		this.addSlotToContainer(new SlotItemHandler(handler, 14, 112, 102));
		this.addSlotToContainer(new SlotItemHandler(handler, 15, 40, 120));
		this.addSlotToContainer(new SlotItemHandler(handler, 16, 58, 120));
		this.addSlotToContainer(new SlotItemHandler(handler, 17, 76, 120));
		this.addSlotToContainer(new SlotItemHandler(handler, 18, 94, 120));
		this.addSlotToContainer(new SlotItemHandler(handler, 19, 112, 120));

		int xPos = 8;
		int yPos = 153;
				
		for (int y = 0; y < 3; ++y) {
			for (int x = 0; x < 9; ++x) {
				this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 9, xPos + x * 18, yPos + y * 18));
			}
		}
				
		for (int x = 0; x < 9; ++x) {
			this.addSlotToContainer(new Slot(playerInv, x, xPos + x * 18, yPos + 58));
		}
	}
	@Override
	public boolean canInteractWith(EntityPlayer player) {
		return false;
	}
}

 

Edited by OrangeVillager61
Posted

If villagers aren't returning an IItemHandler but are returning an IInventory, then....

 

SHOCK, MAGIC

 

Don't use the IItemHandler slots and use regular slots like you're already doing with the player's inventory.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Okay, but when I do just a complete replacement I get this error. While I know it is a arraysize error I don't know where it is coming from:

 

java.util.concurrent.ExecutionException: java.lang.IndexOutOfBoundsException: Index: 51, Size: 51
	at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_121]
	at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_121]
	at net.minecraft.util.Util.runTask(Util.java:30) [Util.class:?]
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1117) [Minecraft.class:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:407) [Minecraft.class:?]
	at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
	at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.IndexOutOfBoundsException: Index: 51, Size: 51
	at java.util.ArrayList.rangeCheck(Unknown Source) ~[?:1.8.0_121]
	at java.util.ArrayList.get(Unknown Source) ~[?:1.8.0_121]
	at net.minecraft.inventory.Container.getSlot(Container.java:135) ~[Container.class:?]
	at net.minecraft.inventory.Container.setAll(Container.java:559) ~[Container.class:?]
	at net.minecraft.client.network.NetHandlerPlayClient.handleWindowItems(NetHandlerPlayClient.java:1306) ~[NetHandlerPlayClient.class:?]
	at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SPacketWindowItems.java:72) ~[SPacketWindowItems.class:?]
	at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SPacketWindowItems.java:13) ~[SPacketWindowItems.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_121]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_121]

 

The container:

public class ContainerIvVillagerInventory extends Container{

	private IvVillager villager;
	
	private IInventory handler; 

	
	public ContainerIvVillagerInventory(IvVillager villager, IInventory playerInv){
		this.villager = villager;
		this.handler = this.villager.getVillagerInventory();
		
		this.addSlotToContainer(new Slot(handler, 0, 40, 66));
		this.addSlotToContainer(new Slot(handler, 1, 58, 66));
		this.addSlotToContainer(new Slot(handler, 2, 76, 66));
		this.addSlotToContainer(new Slot(handler, 3, 94, 66));
		this.addSlotToContainer(new Slot(handler, 4, 112, 66));
		this.addSlotToContainer(new Slot(handler, 5, 40, 84));
		this.addSlotToContainer(new Slot(handler, 6, 58, 84));
		this.addSlotToContainer(new Slot(handler, 7, 76, 84));
		this.addSlotToContainer(new Slot(handler, 8, 94, 84));
		this.addSlotToContainer(new Slot(handler, 9, 112, 84));
		this.addSlotToContainer(new Slot(handler, 10, 40, 102));
		this.addSlotToContainer(new Slot(handler, 11, 58, 102));
		this.addSlotToContainer(new Slot(handler, 12, 76, 102));
		this.addSlotToContainer(new Slot(handler, 13, 94, 102));
		this.addSlotToContainer(new Slot(handler, 14, 112, 102));
		this.addSlotToContainer(new Slot(handler, 15, 40, 120));
		this.addSlotToContainer(new Slot(handler, 16, 58, 120));
		this.addSlotToContainer(new Slot(handler, 17, 76, 120));
		this.addSlotToContainer(new Slot(handler, 18, 94, 120));
		this.addSlotToContainer(new Slot(handler, 19, 112, 120));

		int xPos = 8;
		int yPos = 153;
				
		for (int y = 0; y < 3; ++y) {
			for (int x = 0; x < 9; ++x) {
				this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 9, xPos + x * 18, yPos + y * 18));
			}
		}
				
		for (int x = 0; x < 9; ++x) {
			this.addSlotToContainer(new Slot(playerInv, x, xPos + x * 18, yPos + 58));
		}
	}
	@Override
	public boolean canInteractWith(EntityPlayer player) {
		return false;
	}
}

 

Posted
9 minutes ago, OrangeVillager61 said:

Okay, but when I do just a complete replacement I get this error

Okay, so then you fix that error. If you get a new problem when you make a step forwards, you shouldn't step backwards - you should fix the new problem.

 

Where in the code do you open the container?

 

 

  • Like 1
Posted (edited)
27 minutes ago, Jay Avery said:

Okay, so then you fix that error. If you get a new problem when you make a step forwards, you shouldn't step backwards - you should fix the new problem.

 

Where in the code do you open the container?

 

 

GuiHandler

public class GuiHandler implements IGuiHandler{

	public static final int Hire = 0;
	public static final int Hauler = 1;
	public static final int Info = 2;
	public static final int Inventory = 3;

	@Override
	public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
		// x is used as the entity ID for entity-based GUIs, suggested by Choonster
		if (ID == Hire){
			return new ContainerIvVillagerHireNitwit((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Hauler){
			return new ContainerIvVillagerHauler((IvVillager) world.getEntityByID(x), player.inventory);		
			}
		else if (ID == Info)
		{
			return new ContainerIvVillagerInfo((IvVillager) world.getEntityByID(x), player.inventory);		
		}
		else if (ID == Inventory)
		{
			return new ContainerIvVillagerInventory((IvVillager) world.getEntityByID(x), player.inventory);		
		}
		else {
			return null;
		}
	}

	@Override
	public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
		// x is used as the entity ID for entity-based GUIs, suggested by Choonster
		if (ID == Hire)
		{
			return new GuiIvVillagerHireNitwit((IvVillager) world.getEntityByID(x), player.inventory, player);
		}
		else if (ID == Hauler){
			return new GuiIvVillagerHauler((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Info){
			return new GuiIvVillagerInfo((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Inventory){
			return new GuiIvVillagerInventory((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else {
			return null;
		}
	}

Where it is opened (most of the unrelated code here has been cut out).

	 @Override
	 public boolean processInteract(EntityPlayer player, EnumHand hand){
				else if (this.getTab().equals("Inventory"))
        {
        	if (!world.isRemote) {
        		player.openGui(Iv.instance, GuiHandler.Inventory, world, getEntityId(), 0, 0);
        		}
        	return true;
        }
}

 

Edited by OrangeVillager61

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.