Jump to content

Recommended Posts

Posted

Hi

I'm making a mod that contains, among other things, colored wood. I originally went about this in previous versions by making a separate item class for each color and each wood type combination. I know this is extremely inefficient, but I don't know how to handle data values in the code (I'll probably need two if possible, one for the color and one for the wood type). 

How do I go about working with data id values to the colored wood blocks?

Posted

Data values and NBT tags are two different things. The data value is an integer, and you can only have one data value per item/item stack. So if you're trying to keep track of both color and wood type, unless you can represent all combinations of those things within a single integer from 0 to 15, you can't use data values for it.

But overall, even if you're using NBT tags for this, it's pretty easy. You'd register all your possible item variant model locations with ModelLoader.registerItemVariants(), then you'd supply a customMeshDefinition function that does the logic to determine which model should be used at any given time. Check out this tutorial file for a bit more clarity: https://github.com/McJty/ModTutorials/blob/master/src/main/java/mcjty/modtut/items/MultiModelItem.java

 

Note that the customMeshDefintion function can have any logic you want, whether it be based on the item stack's metadata, NBT tags, or anything else that can be obtained from an ItemStack within the Item class.

Whatever Minecraft needs, it is most likely not yet another tool tier.

Posted

Ok, I got around to looking at the code, it seems the item just toggles between being red and blue upon a right-click. I don't see how you can make a .json recipe file that produces a red item as opposed to a blue one, which is what I ultimately need for my mod, to be able to craft these specific colors with dyes (sorry I didn't specify that before).

Let's say I'll make a class for each wood type. That now allows for us to use data values for the blocks, how would I go about doing that instead of NBT tags?

Posted

Ok, further update.

I managed to get 16 colored blocks in using the data tags, now I only have one question:

How would I specify the names and textures of each block? I added one line in the .lang and it wound up renaming all 16 of them at once.

Posted
On 7/1/2017 at 4:04 PM, IceMetalPunk said:

Data values and NBT tags are two different things. The data value is an integer, and you can only have one data value per item/item stack. So if you're trying to keep track of both color and wood type, unless you can represent all combinations of those things within a single integer from 0 to 15, you can't use data values for it.

Uh.

The 0-15 limit is for blocks. Item stacks have a limit of 0-32,000 (and a bit).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Blocks and ItemBlocks aren't the same thing, still.

Blocks in the world can only contain metadata (0-15) and nothing else. If you want additional data, you need a TileEntity (NBT does not apply to blocks).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

I've settled with making separate ColoredOak, ColoredBirch, etc. classes, so now I'm just dealing with the color per wood type (just like wool, concrete, beds, etc.)

Posted (edited)
5 hours ago, Draco18s said:

Blocks and ItemBlocks aren't the same thing, still.

Blocks in the world can only contain metadata (0-15) and nothing else. If you want additional data, you need a TileEntity (NBT does not apply to blocks).

Right, but if you try representing more than 16 blocks with an ItemBlock, then as soon as it's placed in the world, all hell will break loose. (And by that, I mean "it won't work".)

 

5 hours ago, jonesto95 said:

I've settled with making separate ColoredOak, ColoredBirch, etc. classes, so now I'm just dealing with the color per wood type (just like wool, concrete, beds, etc.)

Which you can easily do by using the data value of the ItemBlock; as far as I know, when an ItemBlock is placed in the world, it calls the block's getStateForPlacement() method and passes its metadata in (which, by default, passes the metadata into the getStateFromMeta() method). So you can take that metadata in that method and convert it to the proper block state for your color, and return that.

Edited by IceMetalPunk

Whatever Minecraft needs, it is most likely not yet another tool tier.

Posted
49 minutes ago, IceMetalPunk said:

Right, but if you try representing more than 16 blocks with an ItemBlock, then as soon as it's placed in the world, all hell will break loose. (And by that, I mean "it won't work".)

Only if you naively try to convert from item meta to block meta.

But yes.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi all,  I have the following issue: I'd like to parse some json using gson and rely on the (somewhat new) java record types. This is supported in gson 2.10+. Gson is already a dependency used by minecraft, however it's 2.8.x for 1.19.2 which I'm targeting at the moment. My idea was to include the newer version of the library in my mod and then shadow it so it gets used inside the scope of my mod instead of the older 2.8. This works fine for building the jar: If I decompile my mod.jar, I can see that it's correctly using the shadowed classes. However obviously when using the runClient intellj config, the shadowing doesn't get invoked. Is there any way of invoking shadow when using runClient, or am I on the wrong track and there's a better way of doing this entirely? Thanks in advance!
    • Yep I did upgrade just because it showed me a new version available.  I'll redownload the mod list and make sure anything works.  Thanks!
    • The latest log was taken down by pastebin for some reason. Did you try removing the mods you added? The mods you updated, was there a specific reason you updated, or just because? It's possible the updates introduced incompatibilitie, or even need a newer build of forge. If you didn't need the updates for a specific reason, you could also try downgrading those mods.
    • Please read the FAQ, and post logs as described there. https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/
    • I am using forge 1.20.1 (version 47.3.0). My pc has an RTX 4080 super and an i9 14900 KF, I am on the latest Nvidia graphics driver, latest windows 10 software, I have java 23, forge 1.12.2 works and so does all vanilla versions but for some reason no version of forge 1.20.1 works and instead the game just crashes with the error code "-1." I have no mods in my mods fodler, I have deleted my options.txt and forge.cfg files in case my settings were causing a crash and have tried removing my forge version from the installations folder and reinstalling but no matter what I still crash with the same code and my log doesn't tell me anything: 18:34:53.924 game 2025-02-06 18:34:53,914 main WARN Advanced terminal features are not available in this environment 18:34:54.023 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, mrmirchi, --version, 1.20.1-forge-47.3.0, --gameDir, C:\Users\aryam\AppData\Roaming\.minecraft, --assetsDir, C:\Users\aryam\AppData\Roaming\.minecraft\assets, --assetIndex, 5, --uuid, 2db00ea8d678420a8956109a85d90e9d, --accessToken, ????????, --clientId, ZWI3NThkNzMtNmNlZS00MGI5LTgyZTgtYmZkNzcwMTM5MGMx, --xuid, 2535436222989555, --userType, msa, --versionType, release, --quickPlayPath, C:\Users\aryam\AppData\Roaming\.minecraft\quickPlay\java\1738838092785.json, --launchTarget, forgeclient, --fml.forgeVersion, 47.3.0, --fml.mcVersion, 1.20.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20230612.114412] 18:34:54.027 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.9+10.0.9+main.dcd20f30 starting: java version 17.0.8 by Microsoft; OS Windows 10 arch amd64 version 10.0 18:34:54.132 game [18:34:54] [main/INFO] [ne.mi.fm.lo.ImmediateWindowHandler/]: Loading ImmediateWindowProvider fmlearlywindow 18:34:54.191 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Trying GL version 4.6 18:34:54.303 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Requested GL version 4.6 got version 4.6 18:34:54.367 monitor Process Monitor Process crashed with exit code -1     screenshot of log: https://drive.google.com/file/d/1WdkH88H865XErvmIqAKjlg7yrmj8EYy7/view?usp=sharing
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.