Jump to content

[1.12] Run event when world first created


laton95

Recommended Posts

I'm trying to create a stronghold-esque structure that only spawns once per world, but like the stronghold only spawns in certain biomes. Is there a way to run an event when the world is first created, so that I can pick the location of this structure?

Also, is there a way to run a method when the selected location is generated, so that the structure can be built?

Edited by laton95
Link to comment
Share on other sites

AFAIK, there's no event that fires when the world is first *created. But once you generate a location, you already know the location has been generated, so the very existence of a non-null location should tell you "I've already done this, don't do it again." In other words, as long as you save the location to the world data and only generate a new one if the existing one is null, you can do this from anywhere, it doesn't have to be only when the world loads.

 

This page of the Forge docs may come in handy with this: https://mcforge.readthedocs.io/en/latest/datastorage/worldsaveddata/

But keep in mind that the structure can't be built in unloaded chunks, so you're better off *actually generating* the structure in a World Generator rather than when the world loads. So you can just have everything in the world generator and generate the location there when none exists.

Whatever Minecraft needs, it is most likely not yet another tool tier.

Link to comment
Share on other sites

Thanks for the help, but I need to generate the positions of the structures on world creation so that I can have an item that points to them (like ender eyes and vanilla strongholds).

 

Since I can't change the vanilla chunk generator to add a new structure, I have made a class that generates and tracks the positions. A new instance of this class is made on InitMapGenEvent, which works but the positions are recalculated each time the event is fired (On reopening a world usually). WorldSaveData is perfect to solve this problem, but I can't get it to work and I can't find a great tutorial. Can anyone explain how to save and load world NBT data?

 

What I have:

 

Class that extends worldSavedData.

Spoiler

public class WorldNBTHelper extends WorldSavedData {
    private static final String DATA_NAME = Reference.MOD_ID;

    // Required constructors
    public WorldNBTHelper() {
        super(DATA_NAME);
    }

    public WorldNBTHelper(String s) {
        super(s);
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        // TODO Auto-generated method stub

    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        // TODO Auto-generated method stub
        return null;
    }
    
    public static WorldNBTHelper get(World world) {
          // The IS_GLOBAL constant is there for clarity, and should be simplified into the right branch.
          MapStorage storage = world.getMapStorage();
          WorldNBTHelper instance = (WorldNBTHelper) storage.getOrLoadData(WorldNBTHelper.class, DATA_NAME);

          if (instance == null) {
            instance = new WorldNBTHelper();
            storage.setData(DATA_NAME, instance);
          }
          return instance;
        }
}

My attempts to save and load data, results in a nullPointerException when the pause menu is opened, I guess when the game tries to save it.

Spoiler

WorldNBTHelper worldNBTHelper = WorldNBTHelper.get(world);
        MapStorage storage = world.getMapStorage();
        WorldSavedData data = storage.getOrLoadData(worldNBTHelper.getClass(), Reference.MOD_ID);
        if (data == null) {
            storage.setData(Reference.MOD_ID, worldNBTHelper);
            data = storage.getOrLoadData(worldNBTHelper.getClass(), Reference.MOD_ID);
        }
        NBTTagCompound nbt = new NBTTagCompound();
        data.readFromNBT(nbt);
        altarsGenerated  = nbt.getBoolean("altarsGenerated");
        
        if (!altarsGenerated) {
            LogHelper.info("Finding locations");
            nbt.setBoolean("altarsGenerated", true);
            data.writeToNBT(nbt);
            data.markDirty();
            //save locations to nbt
        } else {
            //read locations from nbt
        }

 

Edited by laton95
Link to comment
Share on other sites

In WorldSavedData, are the method names for writeToNBT and readFromNBT swapped around? The implementation of write is supposed to return an NBT compound while read does not return anything. Surely a 'read' function should return the thing it is reading?

Edited by laton95
Link to comment
Share on other sites

7 minutes ago, laton95 said:

In WorldSavedData, are the method names for writeToNBT and readFromNBT swapped around? The implementation of write is supposed to return an NBT compound while read does not return anything. Surely a 'read' function should return the thing it is reading?

No that is not how it is used, the write function returns a value because it takes what is saved to the NBTTagcompound and puts it into the file, the read should just take the data out of the NBTTagcompound and put it back into fields.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

23 minutes ago, laton95 said:

In WorldSavedData, are the method names for writeToNBT and readFromNBT swapped around? The implementation of write is supposed to return an NBT compound while read does not return anything. Surely a 'read' function should return the thing it is reading?

The read methods take an NBT tag and read its contents into fields within the object reading it. It doesn't need to return anything. The write methods take the field values and write them into a supplied NBT tag container (often, but not always, a currently-empty NBT tag). It then returns that tag after the modifications have been made, so you can pass it around to other things to write to, or use it however you want.

So read updates the object's state from the contents of an NBT tag, while write stores the object's state into an NBT tag.

Edited by IceMetalPunk

Whatever Minecraft needs, it is most likely not yet another tool tier.

Link to comment
Share on other sites

Thanks, I've figured out WorldSaveData now. My problem now is that it only loads when I enter ungenerated chunks, since I am using the InitMapGen event. I am trying to move over to the WorldEvent.Load event but the world object I get from that event is Null, so I can't load NBT from it.

 

Can anyone recommend a good way to get a non-null world object when the server/world first loads? 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • After uninstalling this mod, everything works! Thanks!
    • I had been playing on this fabric server for about a month with some friend and one day it just stopped starting, can anyone help me understand what the cause is? https://mclo.gs/2jop3r5    
    • The mobs are moving normally for a second, then freeze, then go back to normal, and this repeats. I describe this as mob lag, bc they stutter as if they were lagging. I don't have the best wifi, but that shouldn't matter since its 10mbps which is enough for a server. I have 8 gigs of ram for it, no optimizations have worked, if there is anything more you may need to help lmk, ill describe. The modlist is pretty hefty: VS_ClockworkSurvivalSupportV1.4 aether-1.20.1-1.2.0-neoforge.jar alexsdelight-1.5.jar alexsmobs-1.22.7.jar appleskin-forge-mc1.20.1-2.5.1.jar backpacked-forge-1.20.1-2.2.5.jar balm-forge-1.20.1-7.2.1.jar bettervillage-forge-1.20.1-3.2.0.jar BiomesOPlenty-1.20.1-18.0.0.598.jar botarium-forge-1.20.1-2.3.2.jar CGM-Unofficial-1.4.11+Forge+1.20.1.jar citadel-2.5.2-1.20.1.jar clockwork-1.20.1-0.1.2-forge-05f5d5fbbb.jar configured-forge-1.20.1-2.2.2.jar connectivity-1.20.1-4.9.jar create-1.20.1-0.5.1.f.jar create-new-age-forge-1.20.1-1.1.2.jar createarmoryv0.6.1n.jar createbigcannons-forge-1.20.1-0.5.3.b.jar createchunkloading-1.6.0-forge.jar createdeco-2.0.1-1.20.1-forge.jar createdieselgenerators-1.20.1-1.2h.jar createendertransmission-2.0.7-1.20.1.jar create_misc_and_things_ 1.20.1_4.0A.jar cristellib-1.1.5-forge.jar cupboard-1.20.1-2.3.jar curios-forge-5.7.0+1.20.1.jar destroy-1.20.1-0.8.jar Dungeon Crawl-1.20.1-2.3.14.jar FallingTree-1.20.1-4.3.4.jar FarmersDelight-1.20.1-1.2.4.jar framework-forge-1.20.1-0.6.26.jar geckolib-forge-1.20.1-4.4.2.jar InsaneLib-1.12.1-mc1.20.1.jar Jade-1.20.1-forge-11.8.0.jar jei-1.20.1-forge-15.3.0.4.jar journeymap-1.20.1-5.9.18-forge.jar JustEnoughResources-1.20.1-1.4.0.247.jar kotlinforforge-4.10.0-all.jar l2library-2.4.23.jar libraryferret-forge-1.20.1-4.0.0.jar macawsbridgesbop-1.20-1.1.jar mcw-bridges-2.1.0-mc1.20.4forge.jar moonlight-1.20-2.9.17-forge.jar morevillagers-forge-1.20.1-5.0.0.jar Mo_ZombiesWave-1.20.1-0.1.0-forge.jar NaturesCompass-1.20.1-1.11.2-forge.jar Placebo-1.20.1-8.6.1.jar refinedstorage-1.12.4.jar soundphysics-forge-1.20.1-1.1.2.jar spark-1.10.53-forge.jar stealing_villagers-forge-1.20.1-1.0.0.jar s_a_b-1.3.0_1.20.1.jar takesapillage-1.0.3-1.20.1.jar TerraBlender-forge-1.20.1-3.0.1.4.jar tombstone-1.20.1-8.6.2.jar Towns-and-Towers-1.12-Fabric+Forge.jar twilightforest-1.20.1-4.3.2145-universal.jar valkyrienskies-120-2.1.3-beta.1.jar veinmining-forge-1.3.0+1.20.1.jar waystones-forge-1.20-14.1.3.jar YungsApi-1.20-Forge-4.0.3.jar YungsBetterDesertTemples-1.20-Forge-3.0.3.jar YungsBetterDungeons-1.20-Forge-4.0.3.jar YungsBetterEndIsland-1.20-Forge-2.0.5.jar YungsBetterJungleTemples-1.20-Forge-2.0.4.jar YungsBetterMineshafts-1.20-Forge-4.0.4.jar YungsBetterNetherFortresses-1.20-Forge-2.0.5.jar YungsBetterOceanMonuments-1.20-Forge-3.0.4.jar YungsBetterStrongholds-1.20-Forge-4.0.3.jar YungsBetterWitchHuts-1.20-Forge-3.0.3.jar YungsBridges-1.20-Forge-4.0.3.jar zaynens_leather_from_rotten_flesh_mod_1.20.1.jar
    • Thank you so much! Unfortunately before reading this I reinstalled my java installer. Now when I try to open the forge installer I receive an error message stating 'Unable to install Java' even though I have definitely downloaded and installed the latest version. Any idea what this could be or how I could fix it?  
    • IT WORKED! THANK YOU!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.