Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

1.8.9 Client Command not executing

Irrational

By Irrational
in Modder Support

 Share

Recommended Posts

Irrational Tree Puncher

Irrational

Posted
Posted

Hi there! I'm sure this is a noobish question, since I am new with forge, but I want to ask it anyway.

 

I'm updating a mod that integrates the YouTube Live Stream chat into the MC chat to 1.8.9. But after I make the necessary changes, the command won't execute. Not even a usage message (however, I do get one of those in the "mock" command). I'm not seeing anything in the MC client log, nor is it spitting out errors at me in the chat. It's just that nothing happens!

 

Here is my code: https://github.com/PeregrineZ/youtube-chat-for-minecraft/

 

Can anyone kindly explain to me what I've done wrong?

 

Thanks!

Link to comment
Share on other sites
Choonster Reality Controller

Choonster

Posted
Posted

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites
Irrational Tree Puncher

Irrational

Posted
  • Author
Posted
1 hour ago, Choonster said:

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

Ah, I didn't see that part of the source.

 

This mod was originally coded for single-player only (surprisingly), which is why it checked for a local server, and not a remote one. I was reprogramming it to work on multiplayer.

 

Anyways, I'll build again and see what happens.

Link to comment
Share on other sites
Irrational Tree Puncher

Irrational

Posted
  • Author
Posted
10 hours ago, Choonster said:

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

 

8 hours ago, Irrational said:

Ah, I didn't see that part of the source.

 

This mod was originally coded for single-player only (surprisingly), which is why it checked for a local server, and not a remote one. I was reprogramming it to work on multiplayer.

 

Anyways, I'll build again and see what happens.

Alright, now I've got another problem. 

 

I can't seem to find a way to reference the current MP Player client-side. I can use ICommandSender sender with some methods, but I can't with others because they override. I'm sure this is very noobish, and I'm probably just overlooking a method in the javadocs, but could you quickly point me in the right direction?

 

Thanks!

Link to comment
Share on other sites
Choonster Reality Controller

Choonster

Posted
Posted
13 hours ago, Irrational said:

I can't seem to find a way to reference the current MP Player client-side. I can use ICommandSender sender with some methods, but I can't with others because they override. I'm sure this is very noobish, and I'm probably just overlooking a method in the javadocs, but could you quickly point me in the right direction?

 

The ICommandSender will usually be the client player, but this isn't guaranteed. Mods can execute client commands with their own ICommandSender if they want.

 

The Minecraft#player field contains the current client player.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Xadev
      Rendering overlay error - game crashed

      By Xadev · Posted

      okay.. ';D i did my good old technique of troubleshooting modpack (disabling ALL the mods and gradually in parts enabbling them and lauching game, enabling more mods, launching e.t.c) and managed to narrow it down to one mod.... it was "better smithing table" causing all the errors and making several mods to spit errors.. Same way by FIRSTLY turning on "better smithing tables" and seeing which mods it clashed with was: "Doggy Tallents Next" "bartering station" "Curios API" And further i wasn't able to check what mods conflicted b'cuz it was like: it was working with X mods, enabled 10 more mods, crashed. procedurally disabled all of them and still was crashing, disabled some more mods, worked. enabled back mods with which it was crashing and now it wasn't  i can't understand why and what mods are bad but i'm happy i somehow got the main error causer which again was "better smithing table". Without that mod everything works just fine. SOLVED (?)
    • Xadev
      Rendering overlay error - game crashed

      By Xadev · Posted

      So I'm creating yet another minecraft modpack and stumbled upon error I've never encoutered.. I tried to troubleshoot it myself and it always worked but this time I didn't manage.. Here is minecraft crash report: https://pastebin.com/EVqzdDKg I can't find how or from where to post debug.log  I'm sorry, can someone help me? (as a disclaimer - i've tried already reinstalling minecraft and java)
    • Gecko1199
      Modded Minecraft won't open, error code 1

      By Gecko1199 · Posted

      It works without mods, I've ran it through the launcher by itself and runs perfectly fine, when I open it through Forge I can get through to the launcher but when I go to open the world it loads then gives me the error code 1. Is there anymore info that could help diagnose it?
    • VowedFacecloth
      AE2 Inscriber doesn't work

      By VowedFacecloth · Posted

      Also had the issue. GLAD TO TELL YOU I HAVE THE FIX! Create: Applied Kinetic literally says "Replace all inscriber recipes with Create's sequenced assembly recipe". When I turned off this mod it worked fine. I also didn't use that mod of the pack i played so it didn't matter for me.
    • CodeSlivki
      Missing 'minecraft' dependency (1.16.5).

      By CodeSlivki · Posted

      Right now im trying to make an own mod for minecraft for the version 1.16.5 with forge but whatever i do it still doesnt fix the error this is my build.gradle : buildscript { repositories { maven { url = "https://maven.minecraftforge.net" } mavenCentral() } dependencies { classpath 'net.minecraftforge.gradle:ForgeGradle:5.1.+' } } apply plugin: 'net.minecraftforge.gradle' apply plugin: 'java' group = 'com.example' // Modify to your package name version = '1.0' archivesBaseName = 'flippermod' java { toolchain { languageVersion = JavaLanguageVersion.of(8) } } minecraft { version = "1.16.5-36.2.42" // Ensure this matches your Forge version mappings channel: 'official', version: '1.16.5' runs { client { workingDirectory project.file('run') property 'forge.logging.markers', 'SCAN,REGISTRIES,REGISTRYDUMP' property 'forge.logging.console.level', 'debug' mods { flipper_mod { sourceSets.main.output } } } } } repositories { maven { url = "https://maven.minecraftforge.net/" } mavenCentral() } dependencies { minecraft "net.minecraftforge:forge:1.16.5-36.2.42" } and this one is my settings.gradle:  pluginManagement { repositories { gradlePluginPortal() maven { name = 'MinecraftForge' url = 'https://maven.minecraftforge.net/' } } } plugins { id 'org.gradle.toolchains.foojay-resolver-convention' version '0.7.0' } rootProject.name = 'flippermod' this one is the mods.tml    modLoader="javafml" loaderVersion="[36,)" modId="flippermod" version="1.0.0" displayName="Flippermod" and the last one is the gradle-wrapper.properties distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip dc :"code_slivki"

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept