[SOLVED] [1.12] Missing block textures

[zennyrpg]

So I'm upgrading from 1.10.2 and I'm getting the missing purple/black texture for all my blocks.  I've tried to follow all the guides/ examples for registering blocks/ items, but I'm clearly missing some key part?  I created an example mod to distill my problem down.  Could someone point out why the textures are missing from this block?

 

ExampleMod.java

@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
@Mod.EventBusSubscriber
public class ExampleMod
{
    public static final String MODID = "examplemod";
    public static final String VERSION = "1.0";
	public static ExampleBlock exampleBlock;
  
    
    @EventHandler
    public void preInit(FMLPreInitializationEvent event) 
    {
    	exampleBlock = new ExampleBlock();
    	exampleBlock.setRegistryName(MODID, "exampleblock");
    }
    
    @SubscribeEvent
    public void registerBlocks(RegistryEvent.Register<Block> event) {
        event.getRegistry().register(exampleBlock);
    }
    
    @SubscribeEvent
	public static void registerItems(RegistryEvent.Register<Item> event)
	{
    	event.getRegistry().register(new ItemBlock(exampleBlock).setRegistryName(exampleBlock.getRegistryName()));
	}

    @SubscribeEvent
    public void registerModels(ModelRegistryEvent event) {
    	ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(exampleBlock), 0, new ModelResourceLocation(exampleBlock.getRegistryName(),"inventory"));
    }
}

 

ExampleBlock.java

public class ExampleBlock extends BlockClay {

	protected ExampleBlock() {
		super();
		this.setUnlocalizedName("exampleblock");
	}
}

 

assets/examplemod/blockstates/exampleblock.json

{
    "variants": {
        "normal": { "model": "examplemod:exampleblock" }
    }
}

 

assets/examplemod/models/block/exampleblock.json

{
    "parent": "block/cube_all",
    "textures": {
        "all": "examplemod:blocks/exampleblock"
    }
}

 

assets/examplemod/models/item/exampleblock.json

{
    "parent": "examplemod:block/exampleblock",
    "display": {
        "thirdperson": {
            "rotation": [ 10, -45, 170 ],
            "translation": [ 0, 1.5, -2.75 ],
            "scale": [ 0.375, 0.375, 0.375 ]
        }
    }
}

 

I have the texture saved at assets/examplemod/textures/blocks/exampleblock.png 

Edited July 10, 2017 by zennyrpg

[jonesto95]

I'm pretty sure you actually need a block .json in the item models folder, so that can go.

The ModelResourceLocation "new ModelResourceLocation(block.getUnlocalizedName().substring(5))" works for me.

Before you get any farther, let me warn you: Any declarations involving ModelLoader must be done on the client side, or else they will crash the server. Look at this file here (and maybe the whole repostiory) and see if you can mold your mod to reflect its structure.

https://github.com/Choonster-Minecraft-Mods/TestMod3/blob/1.12/src/main/java/choonster/testmod3/client/model/ModModelManager.java?utf8=✓

[zennyrpg]

@jonesto95

Deleting  assets/examplemod/models/item/exampleblock.json didn't fix this.  I'm not sure if i need that file, but its not what is causing this problem.

 

I looked at the link and its way too complicated for what i'm trying to do.  I'm not trying to write a whole generic model loading system.  I just want one block to show up skinned, which is why I made this toy project.  As far as I can tell, I'm already doing everything I need to do.

I'm

1) registering the block in registerBlocks

2) registering the item in registerItems

3) registering the item's model in registerModels

This is all according to http://mcforge.readthedocs.io/en/latest/concepts/registries/

 

Do you know what step I could be missing?

Edited July 10, 2017 by zennyrpg

[Draco18s]

ModelLoader.setCustomModelResourceLocation(..., new ModelResourceLocation(...,"inventory"))

You have told Minecraft to look for an "inventory" variant.

{
    "variants": {
        "normal": { "model": "examplemod:exampleblock" }
    }
}

You have specified a "normal" variant.

 

You have not specified a default model.

[zennyrpg]

@Draco18s Thanks.  It actually works as is, weirdly?  But I think you are right that that is the proper way to specify the json so I'll experiment with changing it.

 

----

 

So I figured out what was wrong.  Apparently, @Mod.EventBusSubscriber subscribes the class to registerBlocks(RegistryEvent.Register<Block> event) and registerItems(RegistryEvent.Register<Item> event) but not registerModels(ModelRegistryEvent event).  So registerModels was not being called.  I had to MinecraftForge.EVENT_BUS.register(this) in preInit to get registerModels to fire.

 

Of course this should be broken up into separate classes and all that jazz for a real mod, but the toy implementation works now.

[Draco18s]

I want to redo my ultraflexible registration system to use the new events, but it's going to be tough.

[Choonster]

3 hours ago, zennyrpg said:

So I figured out what was wrong.  Apparently, @Mod.EventBusSubscriber subscribes the class to registerBlocks(RegistryEvent.Register<Block> event) and registerItems(RegistryEvent.Register<Item> event) but not registerModels(ModelRegistryEvent event).  So registerModels was not being called.  I had to MinecraftForge.EVENT_BUS.register(this) in preInit to get registerModels to fire.

 

@Mod.EventBusSubscriber will register the Class object with the Forge event bus, which means that any static @SubscribeEvent methods will be registered.

 

Registering an instance of the class with the Forge event bus will register any non-static @SubscribeEvent methods.

 

I suspect your ModelRegistryEvent handler method wasn't static, so it wasn't being registered by @Mod.EventBusSubscriber.

 

Forge's documentation explains events in more detail here.

[zennyrpg]

@Choonster

You are absolutely right, it was non-static.  Thank you for the explanation!