[Solved] [1.12] Rotate block with item

[PegBeard]

I have created a wrench item. When right-clicking a rotatable block, such as a piston, with said wrench, it rotates the block. This works fine but;
If I rotate the block during 'onItemUse' and the block has an inventory, the inventory is shown - is there a way I can stop that but still rotate the block?
If I rotate the block during 'onItemUseFirst' no gui is opened but the block resets after a block update - is there a way to make the rotation stick, or is this just the wrong place to do the rotation.

I have my own rotate code, but for testing purposes I am just using the default method and still getting the results stated above:

    @Override
    public EnumActionResult onItemUse(EntityPlayer player, World world, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)
    {
    	if (hand == EnumHand.OFF_HAND)
    	{
    		return EnumActionResult.FAIL;
    	}

    	Block block = world.getBlockState(pos).getBlock();
    	if (!player.canPlayerEdit(pos, facing, player.getHeldItem(hand)))
    	{
    		return EnumActionResult.PASS;
    	}
    	
    	if (block.getValidRotations(world, pos) != null)
    	{
            if (!player.capabilities.isCreativeMode)
            {
                player.getHeldItem(hand).damageItem(1, player);
            }
            block.rotateBlock(world, pos, facing);
    		SoundType soundtype = block.getSoundType(world.getBlockState(pos), world, pos, player);
            world.playSound(player, pos, soundtype.getHitSound(), SoundCategory.BLOCKS, soundtype.getVolume() * 0.5F, soundtype.getPitch() * 0.75F);
        	player.swingArm(hand);
        	return EnumActionResult.SUCCESS;
    	}
    	return EnumActionResult.PASS;
    }

 

Edited July 12, 2017 by PegBeard

[PegBeard]

Not meaning to sound rude, but I had figured that much out and it doesn't really answer my question.
Are you saying that there is no good way to get the rotation to stick when using  onItemUseFirst and no good way to give my item preference with  onItemUse except when sneaking?

 

I don't mind sticking with  onItemUse and sneaking, I am just curious if there is a way to do what I am asking, for versatility reasons.

[Draco18s]

  On 7/12/2017 at 3:51 PM, diesieben07 said:

If you want the item to always rotate the block, even if it has a GUI and even if the player is not sneaking (this is counter-intuitive!)

Expand  

To a degree. 

I can see the rational both ways, but I'd have to play with it for a while before I could decide if the counter-intuitive method would cause me more frustrating than the must-crouch method. 

[PegBeard]

It was identical to the code shown above, but in the  onItemUseFirst method. So I didn't want to over complicate the original post.

 

    @Override
    public EnumActionResult onItemUseFirst(EntityPlayer player, World world, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, EnumHand hand)
    {
    	if (hand == EnumHand.OFF_HAND)
    	{
    		return EnumActionResult.FAIL;
    	}

    	Block block = world.getBlockState(pos).getBlock();
    	if (!player.canPlayerEdit(pos, facing, player.getHeldItem(hand)))
    	{
    		return EnumActionResult.PASS;
    	}
    	
    	if (block.getValidRotations(world, pos) != null)
    	{
            if (!player.capabilities.isCreativeMode)
            {
                player.getHeldItem(hand).damageItem(1, player);
            }
            block.rotateBlock(world, pos, facing);
    		SoundType soundtype = block.getSoundType(world.getBlockState(pos), world, pos, player);
            world.playSound(player, pos, soundtype.getHitSound(), SoundCategory.BLOCKS, soundtype.getVolume() * 0.5F, soundtype.getPitch() * 0.75F);
        	player.swingArm(hand);
        	return EnumActionResult.SUCCESS;
    	}
    	return EnumActionResult.PASS;
    }

When doing the rotation this way, it appears to rotate, but when the block is updated, it reverts the rotation.

Edited July 12, 2017 by PegBeard

[PegBeard]

Ahh. I see. Thank you.