[1.12] Custom gui doesn't work on server only

[DragonFerocity]

Hey,

 

I'm running a Minecraft server with my mod currently. I have some custom Gui's that I've made for a few items in my mod. The Gui's open when I'm in a single player game, but they do not open when I'm on the server. I'm not sure how to debug this, and I followed several tutorials for how to make custom Gui's.

 

Here's my GuiHandler.java class:

public class GuiHandler implements IGuiHandler
{

    @Override
    public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) 
    { 
        TileEntity tileEntity = world.getTileEntity(new BlockPos(x, y, z));

        if (tileEntity != null)
        {
          if (ID == BlockHandler.GUI_ENUM.ALLOY_FURNACE.ordinal())
          {
              return new ModContainerAlloyFurnace(player.inventory, (ModTileEntityAlloyFurnace)tileEntity);
          }
          else if (ID == BlockHandler.GUI_ENUM.CRAFTING_TABLE.ordinal())
          {
              return new ModCraftingTable.InterfaceCraftingTable(world, new BlockPos(x, y, z));
          }
          else if (ID == BlockHandler.GUI_ENUM.CAMPFIRE.ordinal())
          {
              return new ModContainerCampfire(player.inventory, (ModTileEntityCampfire)tileEntity);
          }
        }

        return null;
    }

    @Override
    public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z)
    {
        TileEntity tileEntity = world.getTileEntity(new BlockPos(x, y, z));

        if (tileEntity != null)
        {
          if (ID == BlockHandler.GUI_ENUM.ALLOY_FURNACE.ordinal())
          {
              return new ModGuiAlloyFurnace(player.inventory, (ModTileEntityAlloyFurnace)tileEntity);
          }
          else if (ID == BlockHandler.GUI_ENUM.CRAFTING_TABLE.ordinal())
          {
              return new GuiCrafting(player.inventory, world, new BlockPos(x, y, z));
          }
          else if (ID == BlockHandler.GUI_ENUM.CAMPFIRE.ordinal())
          {
              return new ModGuiCampfire(player.inventory, (ModTileEntityCampfire)tileEntity);
          }
        }
        return null;
    }
}

Am I missing something?

 

I have this piece of code in my ServerProxy.java (which is the common proxy)

  public void preInit() {
    GameRegistry.registerWorldGenerator(new OreGen(), 0);
    NetworkRegistry.INSTANCE.registerGuiHandler(ExpandedAesthetics.instance, new GuiHandler());
  }

Do I also need to put this in the Client Proxy?

 

(Here's my github repo)

Edited August 3, 2017 by DragonFerocity

[Draco18s]

https://github.com/DragonFerocity/expandedaesthetics/blob/master/src/main/java/com/DragonFerocity/expanded/blocks/ModAlloyFurnace.java#L172

 

That has to be called client-side too

 

Also, this will always be true because of this line.

[Choonster]

1 hour ago, Draco18s said:

That has to be called client-side too

 

No it doesn't. If IGuiHandler#getServerGuiElement returns a non-null Container, FML will send a packet to the client telling it to open the specified GUI.

 

2 hours ago, DragonFerocity said:

I have this piece of code in my ServerProxy.java (which is the common proxy)

  public void preInit() {
    GameRegistry.registerWorldGenerator(new OreGen(), 0);
    NetworkRegistry.INSTANCE.registerGuiHandler(ExpandedAesthetics.instance, new GuiHandler());
  }

Do I also need to put this in the Client Proxy?

 

It needs to be done on both physical sides.

 

Proxies are for sided code, you don't need a "common" proxy. Anything that needs to be done on both physical sides should be done from your @Mod class (or a class called from it).

Edited August 3, 2017 by Choonster

[Draco18s]

9 hours ago, Choonster said:

 

No it doesn't. If IGuiHandler#getServerGuiElement returns a non-null Container, FML will send a packet to the client telling it to open the specified GUI.

My mistake, I looked at my own code and saw I was doing it on both sides and didn't investigate further. And it was midnight.