Jump to content

[1.10.2] TileEntity returns wrong values even though they are stored correctly


XFactHD

Recommended Posts

I have a barricade block with a lot of states: a boolean to determine the top block, two booleans the determine the right, the center and the left block, an EnumFacing limited to the four cardinal directions, a boolean wether the block is on a window or not, a boolean to determine wether the barricade is large (3 blocks wide) or not and a boolean to determine if the block is to be considered as a door. Only the boolean for the top block and the EnumFacing value are stored in metadata, the rest is stored in a TileEntity. The problem is that for some reason the TileEntity always returns false for those boolean value on the server but on the client getActualState() gets all values correctly as the model looks the way it should. Even if I start a seperate server and client from the IDE and join the server, place the block and restart the server, all states are retained which makes no sense what so ever. When the barricade is only one block wide, this problem doesn't show but if the barricade is three blocks wide, you have to break it one column at a time which is not how it should work.

 

The part of the block class that matters:

package XFactHD.rssmc.common.blocks.building;

import XFactHD.rssmc.RainbowSixSiegeMC;
import XFactHD.rssmc.api.block.HitType;
import XFactHD.rssmc.api.block.IDestructable;
import XFactHD.rssmc.common.Content;
import XFactHD.rssmc.common.blocks.BlockBase;
import XFactHD.rssmc.common.blocks.gadget.TileEntityToughBarricade;
import XFactHD.rssmc.common.data.EnumGadget;
import XFactHD.rssmc.common.items.itemBlocks.ItemBlockBarricade;
import XFactHD.rssmc.common.items.itemBlocks.ItemBlockBase;
import XFactHD.rssmc.common.items.misc.ItemCrowbar;
import XFactHD.rssmc.common.utils.helper.PropertyHolder;
import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

import javax.annotation.Nullable;

@SuppressWarnings("deprecation")
public class BlockBarricade extends BlockBase implements IDestructable
{
    public BlockBarricade(String name, Material material, CreativeTabs creativeTab, Class<? extends ItemBlockBase> itemBlockClass)
    {
        super(name, material, creativeTab, itemBlockClass, null);
    }

    public BlockBarricade()
    {
        super("blockBarricade", Material.WOOD, RainbowSixSiegeMC.CT.buildingTab, ItemBlockBarricade.class, null);
        setDefaultState(super.getDefaultState().withProperty(PropertyHolder.TOP, false).withProperty(PropertyHolder.WINDOW, false)
                .withProperty(PropertyHolder.FACING_CARDINAL, EnumFacing.NORTH).withProperty(PropertyHolder.DOOR, false).withProperty(PropertyHolder.LARGE, false)
                .withProperty(PropertyHolder.RIGHT, false).withProperty(PropertyHolder.LEFT, false));
        setSoundType(SoundType.WOOD);
        registerTileEntity(TileEntityBarricade.class, "Barricade");
    }

    @Override
    protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, PropertyHolder.TOP, PropertyHolder.FACING_CARDINAL, PropertyHolder.WINDOW, PropertyHolder.DOOR,
                                             PropertyHolder.LARGE, PropertyHolder.RIGHT, PropertyHolder.LEFT);
    }

    @Override
    public int getMetaFromState(IBlockState state)
    {
        return state.getValue(PropertyHolder.FACING_CARDINAL).getIndex() + (state.getValue(PropertyHolder.TOP) ? 10 : 0);
    }

    @Override
    public IBlockState getStateFromMeta(int meta)
    {
        boolean top = false;
        if (meta > 5)
        {
            meta -= 10;
            top = true;
        }
        if (meta == 0 || meta == 1)
        {
            meta = EnumFacing.NORTH.getIndex();
        }
        return getDefaultState().withProperty(PropertyHolder.FACING_CARDINAL, EnumFacing.getFront(meta)).withProperty(PropertyHolder.TOP, top);
    }

    @Override
    public IBlockState getActualState(IBlockState state, IBlockAccess world, BlockPos pos)
    {
        boolean window = false;
        boolean door = false;
        boolean large = false;
        boolean right = false;
        boolean left = false;
        TileEntity te = world.getTileEntity(pos);
        if (te instanceof TileEntityBarricade)
        {
            window = ((TileEntityBarricade)te).isWindow();
            door = ((TileEntityBarricade)te).isDoor();
            large = ((TileEntityBarricade)te).isLarge();
            right = ((TileEntityBarricade)te).isRight();
            left = ((TileEntityBarricade)te).isLeft();
        }
        return state.withProperty(PropertyHolder.WINDOW, window).withProperty(PropertyHolder.DOOR, door).withProperty(PropertyHolder.LARGE, large)
               .withProperty(PropertyHolder.RIGHT, right).withProperty(PropertyHolder.LEFT, left);
    }

    @Override
    public void onBlockDestroyedByPlayer(World world, BlockPos pos, IBlockState state)
    {
        if (world.isRemote) { return; }
        state = getActualState(state, world, pos);
        EnumFacing facing = state.getValue(PropertyHolder.FACING_CARDINAL);
        boolean large = state.getValue(PropertyHolder.LARGE);
        boolean right = state.getValue(PropertyHolder.RIGHT);
        boolean left = state.getValue(PropertyHolder.LEFT);
        TileEntity te = world.getTileEntity(pos);
        if (te instanceof TileEntityBarricade)
        {
            large = ((TileEntityBarricade)te).isLarge();
            right = ((TileEntityBarricade)te).isRight();
            left = ((TileEntityBarricade)te).isLeft();
        }
        if (state.getValue(PropertyHolder.TOP))
        {
            world.destroyBlock(pos.down(), false);
            if (large)
            {
                if (left)
                {
                    world.destroyBlock(pos.offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.offset(facing.rotateYCCW(), 2), false);
                    world.destroyBlock(pos.down().offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.down().offset(facing.rotateYCCW(), 2), false);
                }
                else if (right)
                {
                    world.destroyBlock(pos.offset(facing.rotateY()), false);
                    world.destroyBlock(pos.offset(facing.rotateY(), 2), false);
                    world.destroyBlock(pos.down().offset(facing.rotateY()), false);
                    world.destroyBlock(pos.down().offset(facing.rotateY(), 2), false);
                }
                else
                {
                    world.destroyBlock(pos.offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.offset(facing.rotateY()), false);
                    world.destroyBlock(pos.down().offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.down().offset(facing.rotateY()), false);
                }
            }
        }
        else
        {
            world.destroyBlock(pos.up(), false);
            if (large)
            {
                if (left)
                {
                    world.destroyBlock(pos.offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.offset(facing.rotateYCCW(), 2), false);
                    world.destroyBlock(pos.up().offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.up().offset(facing.rotateYCCW(), 2), false);
                }
                else if (right)
                {
                    world.destroyBlock(pos.offset(facing.rotateY()), false);
                    world.destroyBlock(pos.offset(facing.rotateY(), 2), false);
                    world.destroyBlock(pos.up().offset(facing.rotateY()), false);
                    world.destroyBlock(pos.up().offset(facing.rotateY(), 2), false);
                }
                else
                {
                    world.destroyBlock(pos.offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.offset(facing.rotateY()), false);
                    world.destroyBlock(pos.up().offset(facing.rotateYCCW()), false);
                    world.destroyBlock(pos.up().offset(facing.rotateY()), false);
                }
            }
        }
    }

    @Override
    public boolean canPlaceBlockAt(World world, BlockPos pos)
    {
        return world.getBlockState(pos).getBlock().isReplaceable(world, pos) && world.getBlockState(pos.up()).getBlock().isReplaceable(world, pos.up());
    }

    @Override
    public boolean canPlaceBlockOnSide(World world, BlockPos pos, EnumFacing side)
    {
        BlockPos panePos = pos.offset(side.getOpposite());
        boolean onGlassPane = world.getBlockState(panePos).getBlock() == Blocks.GLASS_PANE && world.getBlockState(panePos.down()).getBlock() == Blocks.GLASS_PANE;
        return onGlassPane ? side != EnumFacing.UP && side != EnumFacing.DOWN : side == EnumFacing.UP && canPlaceBlockAt(world, pos);
    }

    @Override
    public IBlockState getStateForPlacement(World world, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer, ItemStack stack)
    {
        EnumFacing facing = placer.getHorizontalFacing();
        boolean large = isLargeBarricade(world, pos, facing, side == EnumFacing.UP ? EnumFacing.UP : EnumFacing.DOWN);
        boolean isDoor = checkIsDoor(world, pos, facing, large);
        return getDefaultState().withProperty(PropertyHolder.FACING_CARDINAL, facing).withProperty(PropertyHolder.DOOR, isDoor).withProperty(PropertyHolder.LARGE, large);
    }

    @Override
    public void onBlockPlacedBy(World world, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack)
    {
        if (world.isRemote) { return; }
        EnumFacing facing = placer.getHorizontalFacing();
        boolean window = state.getValue(PropertyHolder.WINDOW);
        boolean large = state.getValue(PropertyHolder.LARGE);
        EnumFacing offset = window ? EnumFacing.DOWN : EnumFacing.UP;
        world.setBlockState(pos.offset(offset), getDefaultState().withProperty(PropertyHolder.FACING_CARDINAL, facing).withProperty(PropertyHolder.TOP, !window));
        if (large)
        {
            world.setBlockState(pos.offset(facing.rotateY()), getDefaultState().withProperty(PropertyHolder.FACING_CARDINAL, facing).withProperty(PropertyHolder.TOP, window));
            world.setBlockState(pos.offset(facing.rotateYCCW()), getDefaultState().withProperty(PropertyHolder.FACING_CARDINAL, facing).withProperty(PropertyHolder.TOP, window));
            world.setBlockState(pos.offset(offset).offset(facing.rotateY()), getDefaultState().withProperty(PropertyHolder.FACING_CARDINAL, facing).withProperty(PropertyHolder.TOP, !window));
            world.setBlockState(pos.offset(offset).offset(facing.rotateYCCW()), getDefaultState().withProperty(PropertyHolder.FACING_CARDINAL, facing).withProperty(PropertyHolder.TOP, !window));
        }
        boolean door = state.getValue(PropertyHolder.DOOR);
        setTileValues(world.getTileEntity(pos), (EntityPlayer) placer, large, false, false, window, !window && door);
        setTileValues(world.getTileEntity(pos.offset(offset)), (EntityPlayer) placer, large, false, false, window, !window && door);
        if (large)
        {
            setTileValues(world.getTileEntity(pos.offset(facing.rotateY())),                   (EntityPlayer) placer, true, true,  false, window, !window && door);
            setTileValues(world.getTileEntity(pos.offset(facing.rotateYCCW())),                (EntityPlayer) placer, true, false, true,  window, !window && door);
            setTileValues(world.getTileEntity(pos.offset(offset).offset(facing.rotateY())),    (EntityPlayer) placer, true, true,  false, window, !window && door);
            setTileValues(world.getTileEntity(pos.offset(offset).offset(facing.rotateYCCW())), (EntityPlayer) placer, true, false, true,  window, !window && door);
        }
    }

    @Override
    public void onBlockClicked(World world, BlockPos pos, EntityPlayer player)
    {
        IBlockState state = world.getBlockState(pos);
        boolean top = state.getValue(PropertyHolder.TOP);
        boolean large = state.getValue(PropertyHolder.LARGE);
        EnumFacing facing = state.getValue(PropertyHolder.FACING_CARDINAL);
        TileEntity te = world.getTileEntity(pos);
        TileEntity te2 = world.getTileEntity(top ? pos.down() : pos.up());
        TileEntity te3 = world.getTileEntity(pos.offset(facing.rotateY()));
        TileEntity te4 = world.getTileEntity(top ? pos.down().offset(facing.rotateY()) : pos.up().offset(facing.rotateY()));
        TileEntity te5 = world.getTileEntity(pos.offset(facing.rotateYCCW()));
        TileEntity te6 = world.getTileEntity(top ? pos.down().offset(facing.rotateYCCW()) : pos.up().offset(facing.rotateYCCW()));
        if (!player.isCreative() && te instanceof TileEntityBarricade && te2 instanceof TileEntityBarricade)
        {
            ((TileEntityBarricade)te).hitBarricade();
            if (((TileEntityBarricade)te).isWindow())
            {
                ((TileEntityBarricade)te).setWindow(false);
                ((TileEntityBarricade)te2).setWindow(false);
                if (large && te3 instanceof TileEntityBarricade && te4 instanceof TileEntityBarricade && te5 instanceof TileEntityBarricade && te6 instanceof TileEntityBarricade)
                {
                    ((TileEntityBarricade)te3).setWindow(false);
                    ((TileEntityBarricade)te4).setWindow(false);
                    ((TileEntityBarricade)te5).setWindow(false);
                    ((TileEntityBarricade)te6).setWindow(false);
                }
                world.playSound(null, pos, SoundEvents.BLOCK_GLASS_BREAK, SoundCategory.BLOCKS, 1, .6F);
            }

            int hits = large ? getTotalHits(te, te2, te3, te4, te5, te6) : getTotalHits(te, te2);
            if (hits >= ((TileEntityBarricade)te).getMaxHits())
            {
                if (world.getBlockState(pos).getValue(PropertyHolder.TOP))
                {
                    world.destroyBlock(pos.down(), false);
                }
                else
                {
                    world.destroyBlock(pos.up(), false);
                }
                world.destroyBlock(pos, false);
            }
        }
    }

    @Override
    public boolean canRenderInLayer(IBlockState state, BlockRenderLayer layer)
    {
        return layer == BlockRenderLayer.CUTOUT || layer == BlockRenderLayer.SOLID;
    }

    @Override
    public TileEntity createTileEntity(World world, IBlockState state)
    {
        if (state.getBlock() == Content.blockToughBarricade)
        {
            return new TileEntityToughBarricade();
        }
        return new TileEntityBarricade();
    }

    private boolean checkIsDoor(World world, BlockPos pos, EnumFacing facing, boolean large)
    {
        if (large)
        {
            BlockPos posFacing = pos.down().offset(facing);
            BlockPos posOpposite = pos.down().offset(facing.getOpposite());
            BlockPos posFacingRight = pos.down().offset(facing).offset(facing.rotateY());
            BlockPos posOppositeRight = pos.down().offset(facing.getOpposite()).offset(facing.rotateY());
            BlockPos posFacingLeft = pos.down().offset(facing).offset(facing.rotateYCCW());
            BlockPos posOppositeLeft = pos.down().offset(facing.getOpposite()).offset(facing.rotateYCCW());
            IBlockState stateFacing = world.getBlockState(posFacing);
            IBlockState stateOpposite = world.getBlockState(posOpposite);
            IBlockState stateFacingRight = world.getBlockState(posFacingRight);
            IBlockState stateOppositeRight = world.getBlockState(posOppositeRight);
            IBlockState stateFacingLeft = world.getBlockState(posFacingLeft);
            IBlockState stateOppositeLeft = world.getBlockState(posOppositeLeft);
            return stateFacing.getBlock().isBlockSolid(world, posFacing, EnumFacing.UP) && stateOpposite.getBlock().isBlockSolid(world, posOpposite, EnumFacing.UP) &&
                   stateFacingRight.getBlock().isBlockSolid(world, posFacingRight, EnumFacing.UP) && stateOppositeRight.getBlock().isBlockSolid(world, posOppositeRight, EnumFacing.UP) &&
                   stateFacingLeft.getBlock().isBlockSolid(world, posFacingLeft, EnumFacing.UP) && stateOppositeLeft.getBlock().isBlockSolid(world, posOppositeLeft, EnumFacing.UP);
        }
        else
        {
            BlockPos posFacing = pos.down().offset(facing);
            BlockPos posOpposite = pos.down().offset(facing.getOpposite());
            IBlockState stateFacing = world.getBlockState(posFacing);
            IBlockState stateOpposite = world.getBlockState(posOpposite);
            return stateFacing.getBlock().isBlockSolid(world, posFacing, EnumFacing.UP) && stateOpposite.getBlock().isBlockSolid(world, posOpposite, EnumFacing.UP);
        }
    }

    private boolean isLargeBarricade(World world, BlockPos pos, EnumFacing facing, EnumFacing off)
    {
        boolean right = world.isAirBlock(pos.offset(facing.rotateY())) || isGlassBlock(world.getBlockState(pos.offset(facing.rotateY())));
        boolean rightUp = world.isAirBlock(pos.offset(facing.rotateYCCW()).offset(off)) || isGlassBlock(world.getBlockState(pos.offset(facing.rotateYCCW()).offset(off)));
        boolean left = world.isAirBlock(pos.offset(facing.rotateY())) || isGlassBlock(world.getBlockState(pos.offset(facing.rotateY())));
        boolean leftUp = world.isAirBlock(pos.offset(facing.rotateYCCW()).offset(off)) || isGlassBlock(world.getBlockState(pos.offset(facing.rotateYCCW()).offset(off)));
        return right && rightUp && left && leftUp;
    }

    private boolean isGlassBlock(IBlockState state)
    {
        return state.getBlock() == Blocks.GLASS_PANE;
    }

    private void setTileValues(TileEntity te, EntityPlayer owner, boolean large, boolean right, boolean left, boolean window, boolean door)
    {
        if (te instanceof TileEntityBarricade)
        {
            ((TileEntityBarricade)te).setOwner(owner);
            ((TileEntityBarricade)te).setLarge(large);
            ((TileEntityBarricade)te).setRight(right);
            ((TileEntityBarricade)te).setLeft(left);
            ((TileEntityBarricade)te).setWindow(window);
            ((TileEntityBarricade)te).setDoor(door);
        }
    }
}

 

The TileEntity class:

package XFactHD.rssmc.common.blocks.building;

import XFactHD.rssmc.RainbowSixSiegeMC;
import XFactHD.rssmc.common.blocks.TileEntityOwnable;
import XFactHD.rssmc.common.net.PacketSetBarricadeValues;
import net.minecraft.nbt.NBTTagCompound;

public class TileEntityBarricade extends TileEntityOwnable
{
    private int hits = 0;
    private boolean window = false;
    private boolean door = false;
    private boolean large = false;
    private boolean right = false;
    private boolean left = false;

    public void hitBarricade()
    {
        hits += 1;
        notifyBlockUpdate();
    }

    public int getHits()
    {
        return hits;
    }

    public boolean isWindow()
    {
        return window;
    }

    public void setWindow(boolean window)
    {
        this.window = window;
        notifyBlockUpdate();
    }

    public boolean isDoor()
    {
        return door;
    }

    public void setDoor(boolean door)
    {
        this.door = door;
        notifyBlockUpdate();
    }

    public boolean isLarge()
    {
        return large;
    }

    public void setLarge(boolean large)
    {
        this.large = large;
        notifyBlockUpdate();
        if (worldObj.isRemote) { sendUpdateToServer(); }
    }

    public boolean isRight()
    {
        return right;
    }

    public void setRight(boolean right)
    {
        this.right = right;
        notifyBlockUpdate();
    }

    public boolean isLeft()
    {
        return left;
    }

    public void setLeft(boolean left)
    {
        this.left = left;
        notifyBlockUpdate();
    }

    public int getMaxHits()
    {
        return 3;
    }

    private void sendUpdateToServer()
    {
        RainbowSixSiegeMC.NET.sendMessageToServer(new PacketSetBarricadeValues(writeToNBT(new NBTTagCompound())));
    }

    @Override
    public void readCustomNBT(NBTTagCompound nbt)
    {
        super.readCustomNBT(nbt);
        hits = nbt.getInteger("hits");
        window = nbt.getBoolean("window");
        door = nbt.getBoolean("door");
        large = nbt.getBoolean("large");
        right = nbt.getBoolean("right");
        left = nbt.getBoolean("left");
    }

    @Override
    public void writeCustomNBT(NBTTagCompound nbt)
    {
        super.writeCustomNBT(nbt);
        nbt.setInteger("hits", hits);
        nbt.setBoolean("window", window);
        nbt.setBoolean("door", door);
        nbt.setBoolean("large", large);
        nbt.setBoolean("right", right);
        nbt.setBoolean("left", left);
    }
}

 

The custom ItemBlock class:

package XFactHD.rssmc.common.items.itemBlocks;

import XFactHD.rssmc.common.blocks.BlockBase;
import XFactHD.rssmc.common.blocks.building.TileEntityBarricade;
import XFactHD.rssmc.common.utils.helper.PropertyHolder;
import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class ItemBlockBarricade extends ItemBlockBase
{
    public ItemBlockBarricade(BlockBase block)
    {
        super(block);
    }

    @Override
    public EnumActionResult onItemUse(ItemStack stack, EntityPlayer player, World world, BlockPos pos, EnumHand hand, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        IBlockState stateBottom = world.getBlockState(pos.down());
        Block blockBottom = stateBottom.getBlock();
        IBlockState stateTop = world.getBlockState(pos);
        Block blockTop = stateTop.getBlock();
        if (side != EnumFacing.UP && side != EnumFacing.DOWN && blockBottom == Blocks.GLASS_PANE && blockTop == Blocks.GLASS_PANE)
        {
            //We have two glass panes on top of each other
            if (stack.stackSize != 0 && player.canPlayerEdit(pos, side, stack))
            {
                int meta = this.getMetadata(stack.getMetadata());
                IBlockState stateToBePlaced = this.block.getStateForPlacement(world, pos, side, hitX, hitY, hitZ, meta, player, stack);
                stateToBePlaced = stateToBePlaced.withProperty(PropertyHolder.TOP, true).withProperty(PropertyHolder.WINDOW, true).withProperty(PropertyHolder.DOOR, false);

                boolean large = stateToBePlaced.getValue(PropertyHolder.LARGE);
                if (large && !isAllGlass(world, pos, stateToBePlaced.getValue(PropertyHolder.FACING_CARDINAL)))
                {
                    stateToBePlaced = stateToBePlaced.withProperty(PropertyHolder.LARGE, false);
                }

                if (!hasAir(world, pos, true, stateToBePlaced.getValue(PropertyHolder.FACING_CARDINAL), stateToBePlaced.getValue(PropertyHolder.LARGE)))
                {
                    return EnumActionResult.FAIL;
                }

                if (placeBlockAt(stack, player, world, pos, side, hitX, hitY, hitZ, stateToBePlaced))
                {
                    SoundType soundtype = world.getBlockState(pos).getBlock().getSoundType(world.getBlockState(pos), world, pos, player);
                    world.playSound(player, pos, soundtype.getPlaceSound(), SoundCategory.BLOCKS, (soundtype.getVolume() + 1.0F) / 2.0F, soundtype.getPitch() * 0.8F);
                    TileEntity te = world.getTileEntity(pos);
                    if (te instanceof TileEntityBarricade)
                    {
                        ((TileEntityBarricade)te).setWindow(true);
                        ((TileEntityBarricade)te).setLarge(stateToBePlaced.getValue(PropertyHolder.LARGE));
                        ((TileEntityBarricade)te).setOwner(player);
                    }
                    if (shouldDecreaseStackSize()) { --stack.stackSize; }
                }

                return EnumActionResult.SUCCESS;
            }
            else
            {
                return EnumActionResult.FAIL;
            }
        }
        else
        {
            //Vanilla behaviour, except the stacksize won't decrease
            IBlockState state = world.getBlockState(pos);
            Block block = state.getBlock();

            if (!block.isReplaceable(world, pos))
            {
                pos = pos.offset(side);
            }

            if (stack.stackSize != 0 && player.canPlayerEdit(pos, side, stack) && world.canBlockBePlaced(this.block, pos, false, side, null, stack))
            {
                int meta = this.getMetadata(stack.getMetadata());
                IBlockState stateToBePlaced = this.block.getStateForPlacement(world, pos, side, hitX, hitY, hitZ, meta, player, stack);

                if (!hasAir(world, pos, false, stateToBePlaced.getValue(PropertyHolder.FACING_CARDINAL), stateToBePlaced.getValue(PropertyHolder.LARGE)))
                {
                    return EnumActionResult.FAIL;
                }

                if (placeBlockAt(stack, player, world, pos, side, hitX, hitY, hitZ, stateToBePlaced))
                {
                    SoundType sound = world.getBlockState(pos).getBlock().getSoundType(world.getBlockState(pos), world, pos, player);
                    world.playSound(player, pos, sound.getPlaceSound(), SoundCategory.BLOCKS, (sound.getVolume() + 1.0F) / 2.0F, sound.getPitch() * 0.8F);
                    TileEntity te = world.getTileEntity(pos);
                    if (te instanceof TileEntityBarricade)
                    {
                        ((TileEntityBarricade)te).setDoor(stateToBePlaced.getValue(PropertyHolder.DOOR));
                        ((TileEntityBarricade)te).setLarge(stateToBePlaced.getValue(PropertyHolder.LARGE));
                        ((TileEntityBarricade)te).setOwner(player);
                    }
                    if (shouldDecreaseStackSize()) { --stack.stackSize; }
                }

                return EnumActionResult.SUCCESS;
            }
            else
            {
                return EnumActionResult.FAIL;
            }
        }
    }

    private boolean hasAir(World world, BlockPos pos, boolean window, EnumFacing facing, boolean large)
    {
        boolean top;
        boolean bottom;
        boolean topRight;
        boolean bottomRight;
        boolean topLeft;
        boolean bottomLeft;
        if (window)
        {
            top = isConsideredAir(world.getBlockState(pos.offset(facing))) && isConsideredAir(world.getBlockState(pos.offset(facing.getOpposite())));
            bottom = isConsideredAir(world.getBlockState(pos.down().offset(facing))) && isConsideredAir(world.getBlockState(pos.down().offset(facing.getOpposite())));
            topRight = isConsideredAir(world.getBlockState(pos.offset(facing).offset(facing.rotateY()))) &&
                    isConsideredAir(world.getBlockState(pos.offset(facing.getOpposite()).offset(facing.rotateY())));
            bottomRight = isConsideredAir(world.getBlockState(pos.down().offset(facing).offset(facing.rotateY()))) &&
                    isConsideredAir(world.getBlockState(pos.down().offset(facing.getOpposite()).offset(facing.rotateY())));
            topLeft = isConsideredAir(world.getBlockState(pos.offset(facing).offset(facing.rotateYCCW()))) &&
                    isConsideredAir(world.getBlockState(pos.offset(facing.getOpposite()).offset(facing.rotateYCCW())));
            bottomLeft = isConsideredAir(world.getBlockState(pos.down().offset(facing).offset(facing.rotateYCCW()))) &&
                    isConsideredAir(world.getBlockState(pos.down().offset(facing.getOpposite()).offset(facing.rotateYCCW())));
        }
        else
        {
            top = isConsideredAir(world.getBlockState(pos.up().offset(facing))) && isConsideredAir(world.getBlockState(pos.up().offset(facing.getOpposite())));
            bottom = isConsideredAir(world.getBlockState(pos.offset(facing))) && isConsideredAir(world.getBlockState(pos.offset(facing.getOpposite())));
            topRight = isConsideredAir(world.getBlockState(pos.up().offset(facing).offset(facing.rotateY()))) &&
                    isConsideredAir(world.getBlockState(pos.up().offset(facing.getOpposite()).offset(facing.rotateY())));
            bottomRight = isConsideredAir(world.getBlockState(pos.offset(facing).offset(facing.rotateY()))) &&
                    isConsideredAir(world.getBlockState(pos.offset(facing.getOpposite()).offset(facing.rotateY())));
            topLeft = isConsideredAir(world.getBlockState(pos.up().offset(facing).offset(facing.rotateYCCW()))) &&
                    isConsideredAir(world.getBlockState(pos.up().offset(facing.getOpposite()).offset(facing.rotateYCCW())));
            bottomLeft = isConsideredAir(world.getBlockState(pos.offset(facing).offset(facing.rotateYCCW()))) &&
                    isConsideredAir(world.getBlockState(pos.offset(facing.getOpposite()).offset(facing.rotateYCCW())));
        }
        return large ? top && bottom && topRight && bottomRight && topLeft && bottomLeft : top && bottom;
    }

    @SuppressWarnings("deprecation")
    private boolean isConsideredAir(IBlockState state)
    {
        if (state.getBlock() == Blocks.AIR) { return true; }
        if (state.getBlock() instanceof BlockBase) { return !((BlockBase)state.getBlock()).isCompleteBlock(state); }
        return !state.getBlock().isFullBlock(state) && !state.getBlock().isFullCube(state) && !state.getBlock().isOpaqueCube(state);
    }

    private boolean isAllGlass(World world, BlockPos pos, EnumFacing facing)
    {
        boolean topRight = world.getBlockState(pos.down().offset(facing.rotateY())).getBlock() == Blocks.GLASS_PANE;
        boolean bottomRight = world.getBlockState(pos.offset(facing.rotateY())).getBlock() == Blocks.GLASS_PANE;
        boolean topLeft = world.getBlockState(pos.down().offset(facing.rotateYCCW())).getBlock() == Blocks.GLASS_PANE;
        boolean bottomLeft = world.getBlockState(pos.offset(facing.rotateYCCW())).getBlock() == Blocks.GLASS_PANE;
        return topRight && topLeft && bottomRight && bottomLeft;
    }

    protected boolean shouldDecreaseStackSize()
    {
        return false;
    }
}

 

Edited by XFactHD
Link to comment
Share on other sites

Packets. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

The data is transfered from the client to the server by MC itself inside the IBlockState as onItemUse runs only on the client. The blocks that are placed on the server by me send their data in the TileEntity via the builtin synchronisation methods. The problem is not that the data is not there on the client or server as the server correctly saves everything through a restart and the client renders everything correctly. The problem is that my getActualState() returns bullshit on the server because the TileEntity's getters don't return the correct values.

Link to comment
Share on other sites

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

7 minutes ago, XFactHD said:

The super class of this TileEntity already takes care of that.

Because we can totally tell what your superclass does.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

20 hours ago, XFactHD said:

if the barricade is three blocks wide, you have to break it one column at a time which is not how it should work.

Am I correct in interpreting that this fact is the only evidence for the problem? Have you tried using the debugger or printlns to see the TE's variables while the game runs?

Link to comment
Share on other sites

10 minutes ago, XFactHD said:

You could have assumed it as I said after your first reply that I am already taking care of the synchronisation.

No I can't. I have to assume the opposite, because if I assume that your superclass does something, then I can assume your code works perfectly.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I have used the debugger while setting as well as while reading the values in the TileEntity. When I set them, they are all correct, when I read them on the client they are also correct but when I read them on the server I only get bullshit. The values are however saved correctly on the server. I even tested this with the dedicated server.

@Draco18s OK, fair enough, I could have been more precise from the beginning.

Edited by XFactHD
Link to comment
Share on other sites

I got it fixed now. After rewriting the ItemBlockBarricade class it still didn't work until I noticed that the TileEntity wasn't existing anymore at the time I tried to access it in onBlockDestroyedByPlayer(). When I moved the destruction of the other blocks to breakBlock() it worked flawlessly eventhough this might be ineffecient because that method is also called for the blocks I destroy in this method which means that I am once destroying blocks and 5 times destroying air.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.