My teleportation item always teleports me inside a block

[Triphion]

So i have made myself a teleportation staff that works fine and all but there is a small issue. Every time i teleport myself to a block, lets say a dirt/grass block while looking down from a high place, i get teleported inside the block i was aiming at. Looking to fix this and hopefully also remove fall damage for a brief period since when you use it while falling under high speed, you take fall damage depending on how fast you were falling. 

 

Code - https://gist.github.com/triphion/c5bb47baa2bdf47242e0e9a2183cf2bb

[IceMetalPunk]

Doesn't the RayTraceResult provide the position of the block you're looking at? If so, then teleporting the player to that location would of course teleport them into the block. You'll want to call BlockPos#offset() before grabbing the coordinates, to offset the position based on the RayTraceResult's sideHit value (it's a public member).

[Triphion]

Thanks for the reply, i'll look into it. There's also this thing, the item doesn't seem to work online, i do think this is because i do not have a worldIn call at the end on the code. But i do not know what it should be after the worldIn call. 

Edited September 5, 2017 by Triphion

[IceMetalPunk]

What do you mean it doesn't work "online"?

 

And you don't need to reference worldIn for your particular code, as EntityPlayer#rayTrace simply uses the world that's bound to the player instance.

[Triphion]

I can't use it to teleport. It doesn't use it nor teleports me anywhere. However, it does work when i play singleplayer, but not on a server. 

Edited September 5, 2017 by Triphion

[Draco18s]

That's because of this:

else{
    return new ActionResult(EnumActionResult.FAIL, playerIn.getHeldItem(handIn));
}

 

[Triphion]

Okey, so i should remove that actionresult that has fail in it, is that it? Is it gonna work in servers now? Then also, when people write 

6 hours ago, IceMetalPunk said:

You'll want to call BlockPos#offset() 

As an example, what exactly do they mean with that hashtag? I mean, what does it stand for? Is it a dot or a method?

 

Edit: It doesn't teleport me anywhere in servers, only in singleplayer still. 

Edited September 5, 2017 by Triphion

[Draco18s]

The hashtag there means that the method is not static. BlockPos.offset(...) implies that you can just call it like that:

foo = BlockPos.offset(bar);

When that is in fact not the case, you need an instance of BlockPos instead:

BlockPos foo = ...
foo.offset(bar);

 

[Triphion]

Uhmm, and what should i type instead of facing(bar)? And you do mean i have to create a new instance like this right?  BlockPos foo = new BlockPos();

Tho im not sure what should be in the two checks. 

Edited September 5, 2017 by Triphion

[Draco18s]

You already have the position, it's the position that isn't working.

 

Now you need to get the facing (which side of the block that was hit by the raycast) and offset that position by 1 in that direction.