[1.12]Custom ItemStack NBT not saving

[GiantNuker]

As stated in title - code: 

if (stack.getTagCompound() == null)
        {
            stack.setTagCompound(new NBTTagCompound());
        }
		stack.getTagCompound().setTag(tag, value);
	}

 

[Draco18s]

Show more of your code. There are several reasons why this might fail, but in order to determine which one of those it is, we need to know where this code is.

[GiantNuker]

10 minutes ago, Draco18s said:

Show more of your code. There are several reasons why this might fail, but in order to determine which one of those it is, we need to know where this code is.

That bit of code is in my API, here it is from the item:

public static boolean isUsable(ItemStack stack) {
		return ((NBTTagInt) ItemData.getStackNBTTag(stack, "damag", new NBTTagInt(0))).getInt() > WingsConfig.detachableDamage ? false : true;
	}
	public static void useDamage(ItemStack stack) {
		int currDam = ((NBTTagInt) ItemData.getStackNBTTag(stack, "damag", new NBTTagInt(0))).getInt();
		if (isUsable(stack)) ItemData.setStackNBTTag(stack, "damag", new NBTTagInt(currDam + 1));
	}
	public boolean isDamageable() {
		return false;
	}
	
	public boolean getIsRepairable(ItemStack toRepair, ItemStack repair) {
		return repair.getItem() == Items.LEATHER;
	}
	
	public double getDurabilityForDisplay(ItemStack stack) {
		return (double)((NBTTagInt) ItemData.getStackNBTTag(stack, "damag", new NBTTagInt(0))).getInt() / WingsConfig.detachableDamage;
	}
	
	public boolean showDurabilityBar(ItemStack stack) {
		return getDurabilityForDisplay(stack) != 0;
	}

and what calls useDamage:

@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public void check(TickEvent.PlayerTickEvent te) {
		try {if (WingsMod.getStateForPlayer(Minecraft.getMinecraft().player) != FlightState.HOVERING && WingsMod.tsc < 1 && Minecraft.getMinecraft().player.onGround) WingsMod.setFlightState(FlightState.NOT_FLYING);
		else if (WingsMod.tsc < 1 && Minecraft.getMinecraft().player.onGround) WingsMod.setFlightState(FlightState.GLIDING);;
		} catch(NullPointerException e) {}
		try {if (WingsMod.getStateForPlayer(te.player) == FlightState.HOVERING && !Minecraft.getMinecraft().player.capabilities.isFlying) Minecraft.getMinecraft().player.capabilities.isFlying = true;} catch(NullPointerException e) {}
		if (WingsMod.tsc > 0) WingsMod.tsc--;
		if (WingsMod.renderHoverVal < -0.5f || WingsMod.renderHoverVal > 0.5f) WingsMod.renderHoverDown = !WingsMod.renderHoverDown;
		if (WingsMod.renderHoverDown) {
			WingsMod.renderHoverVal = WingsMod.renderHoverVal - 0.05f;
		} else {
			WingsMod.renderHoverVal = WingsMod.renderHoverVal + 0.05f;
		}
		
		try {EntityPlayer p = Minecraft.getMinecraft().player;

		 //WingsCapability cap = player.getCapability(WingsCapability.Provider.WINGS_CAP, null);
		if (/*cap.hasWings() ||  */p.getItemStackFromSlot(EntityEquipmentSlot.CHEST).getItem() == WingsMod.wings && ItemDetatchableWings.isUsable(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST))) {
			KeyBinding incVelocity = Minecraft.getMinecraft().gameSettings.keyBindJump;
			
			if (WingsMod.getStateForPlayer(p) == FlightState.GLIDING && incVelocity.isKeyDown() && (p.motionX < 2.7) && (p.motionY < 2.7) && (p.motionZ < 2.7)) { // Fly Up/Increase Velocity
				float yaw = p.rotationYaw;
			    float pitch = p.rotationPitch;
			    float f = 0.02F;
			    double motionX = (double)(-MathHelper.sin(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionZ = (double)(MathHelper.cos(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionY = (double)(-MathHelper.sin((pitch) / 180.0F * (float)Math.PI) * f);
			    p.addVelocity(motionX, motionY, motionZ);
			    if (!p.getName().equals("GiantNuker")) {
				    p.getFoodStats().addExhaustion(WingsConfig.hunger_speedup);
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
			    }
			} else if (WingsMod.getStateForPlayer(p) == FlightState.NOT_FLYING && incVelocity.isKeyDown() && p.fallDistance > 3) {
				WingsMod.setFlightState(FlightState.GLIDING);
			} else if(WingsMod.getStateForPlayer(p) == FlightState.GLIDING && WingsKeyBinds.slow.isKeyDown() && (p.motionX > 0.1) && (p.motionY > 0.1) && (p.motionZ > 0.1)) { // Fly Down/Decrease Velocity
				float yaw = p.rotationYaw;
			    float pitch = p.rotationPitch;
			    float f = 0.04F;
			    double motionX = (double)(-MathHelper.sin(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionZ = (double)(MathHelper.cos(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionY = (double)(-MathHelper.sin((pitch) / 180.0F * (float)Math.PI) * f);
			    p.addVelocity(-motionX, -motionY, -motionZ);
			    if (!p.getName().equals("GiantNuker")) {
				    p.getFoodStats().addExhaustion(WingsConfig.hunger_slowdown);
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
			    }
			} else if(WingsKeyBinds.launch.isKeyDown() && p.onGround) {
				float yaw = p.rotationYaw; 
			    float pitch = p.rotationPitch;
			    float f = 0.8F;
			    double motionX = (double)(-MathHelper.sin(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionZ = (double)(MathHelper.cos(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionY = (double)(-MathHelper.sin((pitch) / 180.0F * (float)Math.PI) * f);
			    WingsMod.setFlightState(FlightState.GLIDING);
			    p.addVelocity(motionX, motionY + 1F, motionZ);
			    if (!p.getName().equals("GiantNuker")) {
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    p.getFoodStats().addExhaustion(WingsConfig.hunger_launch);
			    }
			} else if(WingsKeyBinds.hover.isPressed()) {
				WingsMod.setFlightState(WingsMod.getStateForPlayer(p) == FlightState.HOVERING ? FlightState.GLIDING : FlightState.HOVERING);
				if (WingsMod.getStateForPlayer(p) == FlightState.HOVERING && p.onGround) p.addVelocity(0, 0.5F, 0);
			}
			try {if (p.capabilities.isFlying && WingsMod.getStateForPlayer(p) != FlightState.HOVERING ) WingsMod.setFlightState(FlightState.NOT_FLYING);} catch (NullPointerException e) {}
			if (WingsMod.getStateForPlayer(p) == FlightState.GLIDING) if (!p.getName().equals("GiantNuker")) ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
			else if (WingsMod.getStateForPlayer(p) == FlightState.HOVERING) {
				if (!p.getName().equals("GiantNuker")) {
					ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
					ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
					p.getFoodStats().addExhaustion(WingsConfig.hunger_hover);
				}
			}
			if (!ItemDetatchableWings.isUsable(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST))) {
				WingsMod.setFlightState(FlightState.NOT_FLYING);
			}
		}} catch (NullPointerException e) {}
		
	}

 

[Draco18s]

try {EntityPlayer p = Minecraft.getMinecraft().player;

You're doing everything on the client. The server then synchronizes everything and overwrites your changes.

[GiantNuker]

1 minute ago, Draco18s said:

try {EntityPlayer p = Minecraft.getMinecraft().player;

You're doing everything on the client. The server then synchronizes everything and overwrites your changes.

is there any way to do it without using packets though?

[Draco18s]

Yes. Do whatever it is you're doing on the server thread.

If you can't, then no, you need packets.

[GiantNuker]

Just now, Draco18s said:

Yes. Do whatever it is you're doing on the server thread.

If you can't, then no, you need packets.

Oh well, I DON'T want to send a packet every time the player hits space so I will just damage based on activity(gliding, hovering) thanks anyway