Jump to content

[1.10] Get drops when a BlockBreakHandler is used


dakamojo

Recommended Posts

My machine harvests the drop from a block without breaking it.  I'm using Block#getDrops to figure out what drops from each block.  However, some blocks implement a BlockBreakHandler (TechReborn for oreRuby is an example).  The drops from this are not getting return in getDrops.  How should I be getting the drops from a block as if it were broken?

Link to comment
Share on other sites

BlockBreakHandler is not a Forge or vanilla class.

 

We need details.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

My bad.  I guess the correct thing to say is a class that is registered for the HarvestDropsEvent event.

 

MinecraftForge.EVENT_BUS.register(new BlockBreakHandler());

 

public class BlockBreakHandler {


	@SubscribeEvent
	public void onBlockHarvest(BlockEvent.HarvestDropsEvent event) {
		if (!event.isSilkTouching() && OreDictUtils.isOre(event.getState(), "oreRuby")) {
			event.getDrops().add(ItemGems.getGemByName("red_garnet").copy());
		}
	}
}

 

Link to comment
Share on other sites

Events are fired across each mod in succession meaning that if you handle the event after another mod then you will have access to any changes it made to the drops for that event. A lot of people don't realize that you can change the priority of your subscribe so that it processes after or before other mods -- or at least has a better chance to (if other mod also sets the priority then it is a matter of which mod loads first I think so you would have to control the order the mods actually load).

 

So in your case you want it to load after. Plus you need to handle the case where the previous mod tries to cancel the event (which would normally prevent you from getting it) using the receive cancelled option.

 

Simply create an event handler annotated with @SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)

 

In that you can grab the event.getDrops() and do something with it.

Edited by jabelar

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Event event = new BlockEvent.HarvestDropsEvent(...);
MinecraftForge.EVENT_BUS.fire(event);
event.getDrops()

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 hour ago, diesieben07 said:

A less accurate way is to call Block::getDrops and then fire the event manually, but I don't recommend that.

Whiiiich is what I suggested...

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

uh.png

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I was pointing out how to fire the event, not providing the entire solution

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

5 hours ago, diesieben07 said:

What are you doing...

 

If you truly want to capture a block's drops, you will need to use internal mechanics. 

You will need to call Block::dropBlockAsItemWithChance. That however spawns entities directly into the world, so you need to use the captureDrops method in Block, which is protected, but can be accessed with some tricks.

 

I don't think you read the OP's problem carefully. He's not worried about vanilla blocks, he's handled that. He's worried about other mods that manipulate drops in the harvest event.

 

So I think you need to process the event further (as the methods you mentioned aren't relevant) after the other mod's manipulation.

 

I would basically find all the other mods' blocks in the registry and do a sort of test where I take a location in the world and during one tick successively place each block then break them and handle the harvest event with the low priority and receive canceled annotation I suggested.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I'm Richard, a doctor based in Texas, navigating the complexities of life as a single parent to my 7-year-old daughter. Recently, I decided to invest my pension funds with Coinberry, hoping to supplement my income from my medical practice. Little did I anticipate the tumultuous journey that awaited me. Initially, Coinberry seemed like a promising platform, offering opportunities to invest in cryptocurrencies such as Ethereum (ETH). Entrusting them with $38,000 worth of ETH, I envisioned a future where financial stability and security would complement my responsibilities as a healthcare provider and father. However, my optimism quickly turned to despair when Coinberry's actions took a sinister turn. I found myself on the brink of losing my entire investment—$38,000 worth of ETH—due to what appeared to be a series of manipulative maneuvers. The situation seemed dire, and I was at a loss for how to reclaim what was rightfully mine. Amidst the chaos and desperation, a ray of hope emerged in the form of RESILIENT SHIELD RECOVERY.. Recommended to me by others who had faced similar ordeals, I reached out to them with a flicker of optimism. Their response was nothing short of remarkable. RESILIENT SHIELD RECOVERY. swiftly embarked on a mission to trace the intricate path of my lost funds. Their expertise in blockchain analytics and forensic investigation proved invaluable as they meticulously tracked the movement of ETH across various soft wallets. Within a remarkably short span of three days, they achieved the seemingly impossible—they recovered a substantial portion of my funds. The relief and gratitude I felt cannot be overstated. RESILIENT SHIELD RECOVERY. not only restored my financial stability but also provided me with a renewed sense of security. Their professionalism and efficiency in handling my case were exemplary, guiding me through the intricate process of fund recovery with empathy and clarity. Beyond their role as financial saviors, RESILIENT SHIELD RECOVERY. imparted invaluable lessons on cybersecurity and risk management. They emphasized the importance of vigilance in the digital realm, advocating for measures such as two-factor authentication and secure password practices to safeguard against future threats. Their insights were not only practical but also empowering, equipping me with the knowledge to make informed decisions in my future financial endeavors. As I reflect on this challenging chapter in my life, I am reminded of the resilience inherent in the human spirit. My experience with Coinberry and subsequent salvation by RESILIENT SHIELD RECOVERY. has reinforced the importance of due diligence and caution in investment decisions. It has also underscored the critical role that trusted allies like RESILIENT SHIELD RECOVERY. play in navigating the complexities of financial fraud and cybercrime. To anyone facing similar challenges or contemplating investments in the digital realm, I offer a word of caution and encouragement. Trust your instincts, conduct thorough research, and seek guidance from reputable professionals like RESILIENT SHIELD RECOVERY. when needed. Their expertise and dedication are invaluable assets in safeguarding your financial future. While the scars of this experience may linger, I am grateful for the silver lining provided by RESILIENT SHIELD RECOVERY.. They have not only restored my faith in financial security but also empowered me to protect my daughter's future with renewed vigor and determination. Together, we forge ahead, fortified by hard-earned lessons.  
    • Fast Leaf Decay (by olafskiii) Rubidium (by Asek3) Artifacts (by ochotonida) Framework (by MrCrayfish) Max Health Fix (by DarkhaxDev) Embeddium/Rubidium Extras (by Txni) Essential Mod (by SparkUniverse_) Immersive Aircraft [Fabric/Forge] (by Conczin) Cherished Worlds (Fabric/Forge/NeoForge/Quilt) (by TheIllusiveC4) ExpandAbility (by florensie) Sophisticated Core (by P3pp3rF1y) Tinkers' Levelling Addon (by Pyre540) Better Advancements (by way2muchnoise) Immersive Melodies [Fabric/Forge] (by Conczin) Citadel (by sbom_xela) Vampirism - Become a vampire! (by maxanier) FerriteCore ((Neo)Forge) (by malte0811) CoroUtil (by Corosus) Create Big Cannons (by rbasamoyai) Controlling (by Jaredlll08) Cloth Config API (Fabric/Forge/NeoForge) (by shedaniel) Mekanism (by bradyaidanc) BetterF3 (by cominixo) Supplementaries (by MehVahdJukaar) Chest Cavity - Forge Port (by booneldanforever) ConnectedTexturesMod (by tterrag1098) NetherPortalFix (by BlayTheNinth) Spartan Weaponry (by ObliviousSpartan) Charm of Undying (Fabric/Forge/Quilt) (by TheIllusiveC4) Plushie Mod (by Link4real) JourneyMap (by techbrew) Farmer's Delight (by vectorwing) Connectivity[Forge/Fabric] (by someaddon) Create : Misc & Things (by To0pa) Create: Steam 'n' Rails (by IThundxr) Shutup Experimental Settings! (by Corgi_Taco) Alex's Mobs (by sbom_xela) Quark (by Vazkii) Tool Belt (by gigaherz) Just Enough Items (JEI) (by mezz) Bookshelf (by DarkhaxDev) FastWorkbench (by Shadows_of_Fire) Tinkers Construct (by mDiyo) Collective (by Serilum) Inventory HUD+ (by dmitrylovin) Explorer's Compass (by Chaosyr) playerAnimator (by KosmX) Size Devices (by DaFlame_rl) Jade 🔍 (by Snownee) Create Slice & Dice (by possible_triangle) Create Jetpack (by possible_triangle) Carry On (by Tschipp) Moonlight Lib (by MehVahdJukaar) Kotlin for Forge (by thedarkcolour) CraftTweaker (by Jaredlll08) Just Enough Resources (JER) (by way2muchnoise) AI Improvements (by QueenOfMissiles) Patchouli (by Vazkii) Catalogue (by MrCrayfish) Tool Stats (by DarkhaxDev) It Takes a Pillage (by izofar) JEITweaker (by Jaredlll08) Waystones (by BlayTheNinth) Vampires Need Umbrellas (by focamacho) Oculus (by Asek3) Mantle (by mDiyo) Mob Grinding Utils (by vadis365) Chiseled (by freepeopleworking) AutoRegLib (by Vazkii) Mystical Agriculture (by BlakeBr0) Embeddium/Rubidium Dynamic Lights (by Txni) Flywheel (Legacy) (by jozufozu) Builder's Delight (Forge) (by Tynoxs) Apotheosis (by Shadows_of_Fire) What Are They Up To (Watut) (by Corosus) Create: Interiors (by sudolev) FastFurnace (by Shadows_of_Fire) Balm (Forge Edition) (by BlayTheNinth) Clumps (by Jaredlll08) Iris & Oculus Flywheel Compat (by leon_mout) Configured (by MrCrayfish) Tinkers' Expansion (by Insane96) Crafting on a stick (by OfekN_) MrCrayfish's Gun Mod (by MrCrayfish) Create: Crystal Clear (by singularity_cyvack) FTB Library (Forge) (by FTB) AppleSkin (by squeek502) Curios API (Forge/NeoForge) (by TheIllusiveC4) Better Third Person (by Socolio) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Sons Of Sins (by Furti_Two) SwingThroughGrass (by exidex) AttributeFix (by DarkhaxDev) Quests Additions (Forge) (by NaturaSpell) Building Gadgets (by Direwolf20) Enchantment Descriptions (by DarkhaxDev) Skin Layers 3D (Fabric/Forge) (by tr7zw) Bad Wither No Cookie - Reloaded (by Kreezxil) Placebo (by Shadows_of_Fire) FTB Teams (Forge) (by FTB) Mod Name Tooltip (by mezz) Enigmatic Graves (by Quarris) Sophisticated Backpacks (by P3pp3rF1y) GeckoLib (by Gecko) Builders Crafts & Additions (by MRHminer) Immersive Portals (for Forge) (by qouteall) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Lazy DataFixerUpper(LazyDFU) [FORGE] (by Corgi_Taco) Create Ore Excavation (by tom54541) Tinkers' Rapier (by sz0999312) Mowzie's Mobs (by bobmowzie) Better Combat [Fabric & Forge] (by daedelus_dev) Create Stuff & Additions (by Furti_Two) Cucumber Library (by BlakeBr0) FPS Reducer (by bre2el) Item Filters (by LatvianModder) FTB Quests (Forge) (by FTB) L_Ender 's Cataclysm (by mcl_ender) Starter Kit (by Serilum) Feature NBT Deadlock Be Gone (by telepathicgrunt) Materialis (by RCXcrafter) KleeSlabs (by BlayTheNinth) Pehkui (by Virtuoel) Grappling Hook Mod (by yyonne) Security Craft (by Geforce132) Ars Nouveau (by baileyholl2) Mouse Tweaks (by YaLTeR) Werewolves - Become a Beast! (by Cheaterpaul) Elytra Slot (Fabric/Forge/Quilt) (by TheIllusiveC4) Create (by simibubi) Budschie's Morph Mod (by budschie_) Ore Excavation (by Funwayguy) Create Confectionery (by Furti_Two)
    • Hello, im kind of a newbie on creating mods, and i been trying to make simples mods so far, Right now, i'm creating a mod which detect an specific type of mob and kill it if reach a certain number, by far the mod is detecting the mob and counting them but at the time it reach the limit number, it don't do anything. The Game don't tweak, don't crash, just i't don't run the method i call, which is kill().   public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) { final var TotalCows = pLevel.getNearbyEntities(Cow.class, TargetingConditions.forNonCombat(), pPlayer, pPlayer.getBoundingBox().inflate(5)); if(pLevel.isClientSide){ if(pPlayer.getItemInHand(InteractionHand.MAIN_HAND).getItem() == this.asItem()){ if(!TotalCows.isEmpty()){ if(TotalCows.get(0).isAlive()){ TotalCows.get(0).kill(); } }else{ pPlayer.sendSystemMessage(Component.literal("No hay vacas")); } } } The sendSystemMessage is get triggered, and when i change the method .kill() by any other like send a message it got called, can i get some tips, and a clue of what i'm missing
    • UPD: I DID IT   @Override public void applyEffectTick(LivingEntity livingEntity, int pAmplifier) { Level level = livingEntity.level(); if (!level.isClientSide()) { Holder<DamageType> entropyHolder = level .registryAccess() .registryOrThrow(Registries.DAMAGE_TYPE) .getHolderOrThrow(GTDamageTypes.ENTROPY_KEY); livingEntity.hurt(new DamageSource(entropyHolder), 1); } super.applyEffectTick(livingEntity, pAmplifier); }  
    • So I came to this public class ModDamageTypes{ public static void bootstrap(BootstapContext<DamageType> context) { context.register(GTDamageTypes.ENTROPY_KEY, new DamageType(GrimTales.MOD_ID + "_entropy", 0.1f)); } } public class GTDamageTypes implements DamageTypes { public static final ResourceKey<DamageType> ENTROPY_KEY = register("entropy"); private static ResourceKey<DamageType> register(String name) { return ResourceKey.create(Registries.DAMAGE_TYPE, new ResourceLocation(GrimTales.MOD_ID, name)); } } public class ModWorldGenProvider extends DatapackBuiltinEntriesProvider { public static final RegistrySetBuilder BUILDER = new RegistrySetBuilder() .add(Registries.DAMAGE_TYPE, ModDamageTypes::bootstrap); public ModWorldGenProvider(PackOutput output, CompletableFuture<HolderLookup.Provider> registries) { super(output, registries, BUILDER, Set.of(GrimTales.MOD_ID)); } But! I still have an issue that, I cannot just use Holder.direct, due to it will create error that "Required type:  Holder<DamageType>  Provided : Holder<ResourceKey<DamageType>>" And I still have no clue how to fix it
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.