[Solved]Flowing Fluid To Still Fluid For buckets

[jredfox]

Solved: the answer is that modded fluids are suppose to be one block just support vanilla and you will be fine with your getter method.

public static ItemStack getBucketStack(Block b) 
{
Iterator<Map.Entry<String, Block>> it = Registry.buckets.entrySet().iterator();
while(it.hasNext())
{
	Map.Entry<String, Block> pair = it.next();
	String name = pair.getKey();
	Block block = pair.getValue();
	if(b == block)
	{
		LineBase line = new LineBase("\"" + name + "\"");
		return new ItemStack(GameRegistry.findItem(line.modid, line.name));
	}
}
	return null;
}

try{
//cache buckets
for(Item item : Registry.items)
{
	if(item instanceof ItemBucket)
	{
		Block block = (Block) ReflectionHelper.findField(ItemBucket.class, MCPMappings.getFeildName(MainCommonMod.isEclipse, "isFull")).get(item);
		Registry.buckets.put(ItemUtil.getItemString(item),block);
	}
}
	}catch(Exception e){e.printStackTrace();}

 

public static boolean isFluid(Block b) 
{
	return b instanceof BlockFluidBase || b instanceof BlockLiquid || b instanceof IFluidBlock;
}

How do I Get Flowing Fluid > Still Fluid?

 

I noticed there was FluidRegistry but, I can't seem to find out how to get the flowing liquid from the still liquid. 

 

Example: I have flowing_water in a Forge event. How do I get still_water?

Edited September 20, 2017 by jredfox
not english

[Draco18s]

1 hour ago, jredfox said:

Example: I have flowing_water in a forge event > water

Let me rewrite this into English:

 

Example: I have flowing_water in a Forge event. How do I get still_water?

[jredfox]

28 minutes ago, Draco18s said:

Let me rewrite this into English:

 

Example: I have flowing_water in a Forge event. How do I get still_water?

thanks

[Choonster]

For vanilla liquid blocks (which extend BlockLiquid), use BlockLiquid.getFlowingBlock and BlockLiquid.getStaticBlock to get the flowing and static Blocks for the specified Material.

 

For modded fluid blocks (which usually implement IFluidBlock and extend BlockFluidBase), there's only one Block.

[jredfox]

2 hours ago, Choonster said:

For vanilla liquid blocks (which extend BlockLiquid), use BlockLiquid.getFlowingBlock and BlockLiquid.getStaticBlock to get the flowing and static Blocks for the specified Material.

 

For modded fluid blocks (which usually implement IFluidBlock and extend BlockFluidBase), there's only one Block.

Are modded liquids forced to fallow these procedures? If not I think I might have great incompatibility issues. 

What I am actually trying to do:
fix vanilla's fill bucket event:

preserve NBT on fill
for that I need to get the ItemStack to what it's suppose to be
for that I need get it from by Block > ItemStack bucket cache,
for that I need to know what precociously the block is not two separate blocks still and flowing.

Is there another way without ASM for detecting what the ItemBucket's Output is suppose to be? Specifically on the fill event not on the empty event. I got the stack from the empy event by Iitem.getContainerItem() 

Edited September 18, 2017 by jredfox

[jabelar]

Quote

Are modded liquids forced to fallow these procedures? If not I think I might have great incompatibility issues. 

 

Well, it depends what you mean by "forced". Of course in Java you can extend and @Override most stuff, or create your own custom fluid system, etc.

 

So what fluids are you interested in handling. Basically there are the vanilla fluids, forge fluids and then other weird fluid systems other mods might have. If you're worried about trying to handle other mods' non-Forge fluid systems then you'd have to either look at their source/API or you have to work with their developer to ensure compatibility.

 

But this is the same for all mod compatibility issues. Many modders follow the forge intended APIs but some go off and do things differently.

 

I personally would just follow Choonster's advice and handle the vanilla and forge fluids for now.

[Draco18s]

On 9/18/2017 at 5:39 AM, jredfox said:

Are modded liquids forced to fallow these procedures? If not I think I might have great incompatibility issues.

https://en.wikipedia.org/w/index.php?title=Fallow

Edited September 19, 2017 by Draco18s

[jredfox]

10 hours ago, Draco18s said:

https://en.wikipedia.org/w/index.php?title=Fallow

Well I don't understand that comment but, I figured out what I am going to do.

 

1.10.2 > Support ItemBucket/Universal Bucket Class

ItemBucket > get stack from block (support vanilla if is not flowing get the flowing) > preserver enchantments and/or NBT
Universal bucket class has output stack, and getfluid. I think it fires fill bucket event yes? If so it could be supported easily. > preserver enchantments and/or NBT