[solved][1.10.2] How to sync entity living from server to client?

[Dustpuppy]

Hi,

i have an entity, i set a custom name at spawning. He has it then and is synced on server and client.

 

The entity class.

Spoiler

package helpinghands.Models;

import javax.annotation.Nullable;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class EntityDeliveryMan extends EntityWorker{

	public EntityDeliveryMan(World worldIn) {
		super(worldIn);
		this.profession = EntityTyp.DELIVERY_MAN;
		this.Name = "Delivery Guy";
	}

	@Override
	public void onUpdate() {
		super.onUpdate();
		
	}
	
	@Override
	@SideOnly(Side.CLIENT)
	public EnumActionResult applyPlayerInteraction(EntityPlayer player,	Vec3d vec, @Nullable ItemStack stack, EnumHand hand) {
		return super.applyPlayerInteraction(player, vec, stack, hand);
	}
}

 

 

The base class.

Spoiler

package helpinghands.Models;

import javax.annotation.Nullable;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.SharedMonsterAttributes;
import net.minecraft.entity.ai.EntityAILookIdle;
import net.minecraft.entity.ai.EntityAISwimming;
import net.minecraft.entity.ai.EntityAITasks.EntityAITaskEntry;
import net.minecraft.entity.ai.EntityAIWatchClosest;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class EntityWorker extends EntityLiving{

	public EntityTyp profession;
	public String Name;
	
    public EntityWorker(World worldIn) {
        super(worldIn);
        this.profession = EntityTyp.DEFAULT;
    	this.setDropItemsWhenDead(false);
    	this.setAlwaysRenderNameTag(true);
    	/*
    	this.setItemStackToSlot(EntityEquipmentSlot.HEAD, new ItemStack(Items.DIAMOND_HELMET));
    	this.setItemStackToSlot(EntityEquipmentSlot.CHEST, new ItemStack(Items.DIAMOND_CHESTPLATE));
    	this.setItemStackToSlot(EntityEquipmentSlot.LEGS, new ItemStack(Items.DIAMOND_LEGGINGS));
    	this.setItemStackToSlot(EntityEquipmentSlot.FEET, new ItemStack(Items.DIAMOND_BOOTS));
    	this.setItemStackToSlot(EntityEquipmentSlot.MAINHAND, new ItemStack(Items.DIAMOND_SWORD));
    	*/
    }

    @Override
    protected void entityInit() {
        super.entityInit();
    }

    @Override
    protected void applyEntityAttributes() {
        super.applyEntityAttributes();
        // Here we set various attributes for our mob. Like maximum health, armor, speed, ...
        this.getEntityAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(15F);
        this.getEntityAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.3D);
        this.getEntityAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(64.0D);
        this.getEntityAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(2.0D);
        }


    @Override
    protected void initEntityAI() {
        this.tasks.addTask(0, new EntityAISwimming(this));
        this.tasks.addTask(8, new EntityAIWatchClosest(this, EntityPlayer.class, 8.0F));
        this.tasks.addTask(9, new EntityAILookIdle(this));

        this.applyEntityAI();
    }

    public void applyEntityAI() {
    }

    public void writeEntityToNBT(NBTTagCompound nbt)
    {
    	nbt.setString("name", this.Name);
    	super.writeEntityToNBT(nbt);
    	
    }
    
    public void readEntityFromNBT(NBTTagCompound nbt)
    {
    	super.readEntityFromNBT(nbt);
    	this.Name = nbt.getString("name");
    }   
 
    
    @SideOnly(Side.CLIENT)
    @Override
    public EnumActionResult applyPlayerInteraction(EntityPlayer player,	Vec3d vec, @Nullable ItemStack stack, EnumHand hand) {
    	Minecraft.getMinecraft().displayGuiScreen(new GuiWorker());
    	GuiWorker.setup(this);

    	return super.applyPlayerInteraction(player, vec, stack, hand);
    }

    public void onUpdate() {
    	super.onUpdate();
    }

	public void clearTasks()
	{
		if(!this.targetTasks.taskEntries.isEmpty())
		{
			for (EntityAITaskEntry t : this.targetTasks.taskEntries) 
			{
				this.targetTasks.removeTask(t.action);
			}
		}
	}
	
	@Override
	public void onLivingUpdate() {
    	System.out.println(this.Name);
		super.onLivingUpdate();
	}
	
	public void moveTo(BlockPos pos) 
	{
		// first clear the task list
		clearTasks();
		// add task
		this.targetTasks.addTask(0, new EntityWorkerMoveTo(this, 1D, 1, pos));
	}

    public void faceBlock(@Nullable final BlockPos block)
    {
        if (block == null)
        {
            return;
        }

        final double xDifference = block.getX() - this.posX;
        final double zDifference = block.getZ() - this.posZ;
        final double yDifference = block.getY() - (this.posY + (double) this.getEyeHeight());

        final double squareDifference = Math.sqrt(xDifference * xDifference + zDifference * zDifference);
        final double intendedRotationYaw = (Math.atan2(zDifference, xDifference) * 180.0D / Math.PI) - 90.0;
        final double intendedRotationPitch = -(Math.atan2(yDifference, squareDifference) * 180.0D / Math.PI);
        
        float newYaw = (float)intendedRotationYaw;
        float newPitch = (float)intendedRotationPitch;

        this.setLocationAndAngles(this.posX, this.posY, this.posZ, newYaw, newPitch);
        
        final double goToX = xDifference > 0 ? 0.001D : -0.001D;
        final double goToZ = zDifference > 0 ? 0.001D : -0.001D;

        this.moveEntity((float) goToX, 0, (float) goToZ);
    }

    public String getName()
    {
    	return this.Name;
    }
    
    public void setName(String Name)
    {
    	this.Name = Name;
    	this.setCustomNameTag(this.Name);
    	
    }
    
    @Override
    public void setCustomNameTag(String name) {
    	super.setCustomNameTag(name);
    }
    
    @Override
    public boolean hasCustomName() {
    	return true;
    }
    
    public enum EntityTyp
    {
        DEFAULT("default", 0),
        DELIVERY_MAN("deliveryman", 1);

        public final String textureBase;

        public final int numTextures;

        EntityTyp(final String textureBase, final int numTextures)
        {
            this.textureBase = textureBase;
            this.numTextures = numTextures;
        }
        
    }
}

 

 

This is the output after spawn.

Spoiler

[20:46:46] [Server thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Delivery Guy
[20:46:46] [Client thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Delivery Guy
[20:46:46] [Server thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Delivery Guy
[20:46:46] [Client thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Delivery Guy

 

 

When i change the custom name over a gui then, only the server get's it, but the client not.

How do i sync the client to the server data?

The ouput after changing the name.

Spoiler

[20:53:04] [Server thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Deliver Boy
[20:53:04] [Client thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Delivery Guy
[20:53:04] [Server thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Deliver Boy
[20:53:04] [Client thread/INFO] [STDOUT]: [helpinghands.Models.EntityWorker:onLivingUpdate:110]: Delivery Guy

 

 

Client still keeps the old data.

Edited September 29, 2017 by Dustpuppy

[AnZaNaMa]

I don't have any experience with this, but here's a tutorial that might be able to help you out... https://wiki.mcjty.eu/modding/index.php/Networking-1.12

[jabelar]

Maybe look at how the vanilla name tags work.

[AnZaNaMa]

At first, I was going to say that it could just be that you're never calling setCustomNameTag() after the Name is changed, but seeing that you're printing the value of Name to the console and it's not changing, I guess that doesn't really solve the issue here, though you still may want to consider doing so.

 

I believe the real issue here is the way you're handling the GUI. The solution to the problem is not to sync the data from the client to the server. When working with GUIs, you want to use both sides, so your method that opens the GUI should not be @SideOnly(Side.CLIENT) and you should not use  Minecraft.getMinecraft().displayGuiScreen(), but instead FMLNetworkHandler.openGui().  I haven't worked with GUIs in a while, but here's a tutorial on using them properly:

 

https://bedrockminer.jimdo.com/modding-tutorials/advanced-modding/gui-screen/

[Dustpuppy]

5 hours ago, AnZaNaMa said:

At first, I was going to say that it could just be that you're never calling setCustomNameTag() after the Name is changed,

 

I did. I call this function in the entity class

Spoiler

    public void setName(String Name)
    {
    	this.Name = Name;
    	this.setCustomNameTag(this.Name);
    	
    }

 

And the call in the gui

Spoiler

	@Override
	protected void keyTyped(char typedChar, int keyCode) throws IOException {
		workerName.textboxKeyTyped(typedChar, keyCode);
		worker.setName(workerName.getText());
		super.keyTyped(typedChar, keyCode);
	}

 

 

Changing the gui handling to gui handler will also not solve the problem.

 

[Dustpuppy]

I found it.

Have taken out all parts, where i was using the self set string "Name" and accessing now only custom name tag. Now it works. He didn't sync the string, even with using nbt tag to store and reread it.