[1.12] Making items in 1.12?

[AnZaNaMa]

So, I haven't attempted to create any mods in 1.12 yet. I'm following shadowfacts' tutorial on items and I see now that registering things requires an EventHandler. I have implemented a class for items that just does basic stuff, and I have created EventHandlers.

@SubscribeEvent
public static void registerItems(RegistryEvent.Register<Item> event) {
    event.getRegistry().registerAll(
            wrench
    );
}

@SubscribeEvent
public static void registerItemModels(ModelRegistryEvent event) {
    wrench.registerItemModel();
}

@SideOnly(Side.CLIENT)
public static void registerItemRenderer(Item item, int meta, String id) {
    ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(Modularity.MODID +
            ":" + id, "inventory"));
}

 

I've followed this tutorial down to the letter (well I guess not literally) and for some reason, my item is not showing up when I load the game. Yes, I have included the @Mod.EventBusSubscriber annotation on my class.

 

Here's a link to my Item Class.

 

[Draco18s]

Question, why do you pass this off to the item only to have the item pass it back to the registry class?

https://github.com/AnZaNaMa/Modularity/blob/master/src/main/java/com/anzanama/modularity/Registry.java#L45-L54

You could just call

registerItemModel(wrench, 0, new ModelResourceLocation(wrench.getRegistryName(),"normal"))

 

Also:

https://github.com/AnZaNaMa/Modularity/blob/master/src/main/java/com/anzanama/modularity/common/item/ItemBase.java#L14

NO. BAD. There is no reason save this.

https://github.com/AnZaNaMa/Modularity/blob/master/src/main/java/com/anzanama/modularity/common/item/ItemBase.java#L18

setUnlocalizedName(getRegistryName())

 

https://github.com/AnZaNaMa/Modularity/blob/master/src/main/java/com/anzanama/modularity/Registry.java#L46

This event is client-side-only:

https://github.com/AnZaNaMa/Modularity/blob/master/src/main/java/com/anzanama/modularity/Registry.java#L10

Edited September 29, 2017 by Draco18s

[AnZaNaMa]

Okay, I've moved the model registering function, gotten rid of the saved reference to name, and slapped an @SideOnly(Side.CLIENT) on the model registry. I don't know why you're saying to call setUnlocalizedName(getRegistryName()). getRegistryName() returns a ResourceLocation and setUnlocalizedName() requires a String.

 

Also, my item still isn't showing up in the creative menu. I was trying to use my own tab at first, but thought that might be the issue, so I changed it to Tab.MATERIALS and it's still not working correctly. With the @Mod.EventBusSubscriber, I don't need to call MinecraftForge.EVENT_BUS.register() anywhere do I?

[Draco18s]

8 minutes ago, AnZaNaMa said:

Okay, I've moved the model registering function, gotten rid of the saved reference to name, and slapped an @SideOnly(Side.CLIENT) on the model registry. I don't know why you're saying to call setUnlocalizedName(getRegistryName()). getRegistryName() returns a ResourceLocation and setUnlocalizedName() requires a String.

You can turn the resource location into a string. The point is to get your mod ID into the unlocalized name as to avoid name conflicts (language entries are NOT mod specific). e.g. https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L95

8 minutes ago, AnZaNaMa said:

Also, my item still isn't showing up in the creative menu. I was trying to use my own tab at first, but thought that might be the issue, so I changed it to Tab.MATERIALS and it's still not working correctly. With the @Mod.EventBusSubscriber, I don't need to call MinecraftForge.EVENT_BUS.register() anywhere do I?

Hmm...

There's no need to override setCreativeTab:

https://github.com/AnZaNaMa/Modularity/blob/master/src/main/java/com/anzanama/modularity/common/item/ItemBase.java#L27

Just call it in the item's constructor with whatever tab you want.

 

Not seeing any other issues, though.

[AnZaNaMa]

the override was so that I could call setCreativeTab() in the same line that I create the object, since I store it as an ItemBase, not an Item

Edited September 29, 2017 by AnZaNaMa

[Draco18s]

2 minutes ago, AnZaNaMa said:

the override was so that I could call setCreativeTab() in the same line that I create the object, since I store it as an ItemBase, not an Item

wrench = new ItemBase("wrench").setCreativeTab(CreativeTabs.WHATEVER);

No override needed.

[AnZaNaMa]

This is so strange, though. I don't see why it wouldn't be working. I don't get any errors in the console

[AnZaNaMa]

I figured it out. Didn't realize I had to give the modid as a parameter to the @Mod.EventBusSubsciber. I've got it working now.