[SOLVED][1.12.2] Question about genPatches when contributing to Forge

[jabelar]

I'm working on my first (simple) contribution to Forge. So I think I'm ready to submit a pull request, but want to clarify a couple things.

 

I have my fork, which I've been working on (on the 1.12 branch), have a working test mod, etc. The change I'm making is only on Forge code, not Minecraft. So in that case do I need to generate patches? I assume my change will just get merged without needing patches -- generating patches is for cases when a change to the vanilla code is being proposed, right?

 

My next contribution will want to do some changes to vanilla behavior. So in that case, I do the change in the Clean part of the code and then generate patches? Also, the instructions say to run the gradlew genPatches on the "Forge root". Does that mean the top of my workspace (which contains both the Clean and Forge, or actually run inside the Forge folder?

 

Lastly, once the patch is generated I sync that back to my github repository?

 

Sorry for the noob questions...

Edited October 9, 2017 by jabelar

[Draco18s]

  On 10/9/2017 at 3:16 PM, jabelar said:

Does that mean the top of my workspace (which contains both the Clean and Forge, or actually run inside the Forge folder?

Expand  

Top of the workspace. GenPatches does a comparison between Clean and Forge.

[jabelar]

  On 10/9/2017 at 3:24 PM, Draco18s said:

Top of the workspace. GenPatches does a comparison between Clean and Forge.

Expand  

Okay, so I shouldn't modify clean at all then (makes sense). Under Forge there is the src/main/Java which contains Minecraft code and I should do the edits there then the genPatchs compares that with clean. Thanks for the clarification. 

 

What about my other question, if my changes are only in the Forge stuff (under main-java), I don't need to generate a patch right? It will get directly merged?

[jabelar]

Thanks guys.