[1.12.2]NBT Packet

[GiantNuker]

It would be much less of a pain to send packets if I knew how to put NBT in them, it is possible, because when I spawn an entity, my NBT read code activates:

[13:26:48] [Server thread/INFO]: Saving and pausing game...
[13:26:48] [Server thread/INFO]: Saving chunks for level 'New World'/overworld
[13:26:48] [Server thread/INFO]: Saving chunks for level 'New World'/the_nether
[13:26:48] [Server thread/INFO]: Saving chunks for level 'New World'/the_end
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:77]: deser
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:83]: body_chestnut
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:88]: mark:marks_whitefield
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:88]: mark:marks_whitedots
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:88]: mark:marks_white
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:88]: mark:marks_blackfield
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:88]: mark:marks_greyfield
[13:26:50] [Server thread/INFO]: [mods.giantnuker.horse.Markings:deserializeNBT:88]: mark:marks_white

This first prints the body image, body_chestnut, then all the additional markings the horse has, marks_whitedots, marks_greyfield.

Help would be nice

[Draco18s]

You can. ByteBufUtils.writeTag(buffer, nbt);

You can also send more than one value in a packet...

[GiantNuker]

1 minute ago, Draco18s said:

You can. ByteBufUtils.writeTag(buffer, nbt);

You can also send more than one value in a packet...

Thank You!!!!

Never again will I have so much trouble sending strings

[GiantNuker]

17 hours ago, diesieben07 said:

In my opinion, if you are sending NBT in a packet, 90% of the time you are doing something wrong.

why

[GiantNuker]

On 10/20/2017 at 0:42 AM, diesieben07 said:

Because there is no point in doing:

compound = new NBTTagCompound();
compound.setInt("foo", 123);
compound.setString("bar", "Hello World");
byteBuf.writeCompound(compound);

when you can just do:

byteBuf.writeInt(123);
byteBuf.writeString("Hello World");

 

 

The second version is more compact code-wise, it takes less bandwidth and it is more performant.

there is no writeString method in ByteBuf.

[Draco18s]

Knowing two things:

1) How to use my IDE

2) That strings are characters and characters are bytes

I worked this out on my own:

 

buf.writeBytes(("this is a string").getBytes());

[Silly511]

54 minutes ago, Draco18s said:

Knowing two things:

1) How to use my IDE

2) That strings are characters and characters are bytes

I worked this out on my own:

 

buf.writeBytes(("this is a string").getBytes());

You should use ByteBufUtils.writeString and ByteBufUtils.readString instead.

[Draco18s]

1 minute ago, Silly511 said:

You should use ByteBufUtils.writeString and ByteBufUtils.readString instead.

The ByteBufUtils are awesome, and definitely a better choice.

But in terms of "here's what's in front of me, how can I solve this problem?" I could do it.

[Silly511]

1 minute ago, Draco18s said:

The ByteBufUtils are awesome, and definitely a better choice.

But in terms of "here's what's in front of me, how can I solve this problem?" I could do it.

I was about to edit my post when you replied, I should have been more specific. You can't use the code you posted because you can't read the string afterwards. You need to know how long the string is so you know how many bytes to read. ByteBufUtils.writeString will write the length so that ByteBufUtils.readString knows how many bytes to read.

[jabelar]

On 10/17/2017 at 11:21 PM, diesieben07 said:

In my opinion, if you are sending NBT in a packet, 90% of the time you are doing something wrong.

I do it when I'm also planning to save / load the information. I know I can also do that in a raw file sort of way, but kinda nice to have one format that contains mixed data types that has helper classes for both packet and file serializers.

[Draco18s]

8 minutes ago, Silly511 said:

because you can't read the string afterwards. You need to know how long the string is so you know how many bytes to read.

Oh gosh, leaving an exercise to the reader about writing in the length of the string first! The horror!