Jump to content
View in the app

A better way to browse. Learn more.
Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.
Currently supported: All versions

Question on Forge's mod to getTileEntities() in WorldServer.java

mikeprimm
in General Discussion

Featured Replies

Posted

This is specific to https://github.com/MinecraftForge/MinecraftForge/blob/master/patches/minecraft/net/minecraft/world/WorldServer.java.patch#L171.

 

Over on Spigot, we developed our own version of this performance patch before realizing that the Forge team had already discovered and addressed it.  One debate we're still having is on the need for the 'isInvalid()' check that is being made in the Forge version - I've been on the page that you guys have had it for a while, so I'm inclined to trust that you had a good reason, but one of my counterpart is arguing that it doesn't appear to be necessary.  If anyone involved with this change can recall, was there a particular need or issue addressed by checking for the isInvalid()?  The cases my associate has identified appear to avoid the issue of the invalid TEs being on the chunk's list by the time the call is used, but I'm not confident that all the cases have been considered.

 

If you're interested, the discussion is on this PR - https://github.com/EcoCityCraft/Spigot/pull/21#discussion_r3192913.  Thanks for any insight that can be offered.

  • Quote

    Due to several changes where we defer removal until later times, the tile entities in the chunk can be invalid, so yes, this is needed.

    I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
    Consider supporting the team on Patreon

  • Quote
    • Author

    Due to several changes where we defer removal until later times, the tile entities in the chunk can be invalid, so yes, this is needed.

    Super - thanks for the info.  So, just to be 100% clear, to your knowledge, it was needed in Forge due to other Forge-related changes, versus being needed to preserved "vanilla" behavior, correct?

  • Quote

    That, i haven't looked into for a long time, as far as I remember invalid entities should not be in that list in vanilla. So, in vanilla it is not needed.

    I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
    Consider supporting the team on Patreon

  • Quote

    • Join the conversation

    You can post now and register later. If you have an account, sign in now to post with your account.
    Note: Your post will require moderator approval before it will be visible.

    Guest
    Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
    Reply to this topic...
    Go to topic listing

    Important Information

    By using this site, you agree to our Terms of Use.

    I accept

    Configure browser push notifications
    Chrome (Android)
    1. Tap the lock icon next to the address bar.
    2. Tap Permissions → Notifications.
    3. Adjust your preference.
    Chrome (Desktop)
    1. Click the padlock icon in the address bar.
    2. Select Site settings.
    3. Find Notifications and adjust your preference.