[1.11.2] [UNSOLVED] Block connections & Blockstates

[Bektor]

Hi,

 

I'm wondering how I can achieve something like in the picture below, but with a few differences:

• Side X looks differently than the other sides when a machine is connected to side X.

 

I thought about something like this, just that I'm calculating that stuff automatically for all sides:

    /** Whether this fence connects in the northern direction */
    public static final PropertyBool NORTH = PropertyBool.create("north");
    /** Whether this fence connects in the eastern direction */
    public static final PropertyBool EAST = PropertyBool.create("east");
    /** Whether this fence connects in the southern direction */
    public static final PropertyBool SOUTH = PropertyBool.create("south");
    /** Whether this fence connects in the western direction */
    public static final PropertyBool WEST = PropertyBool.create("west");

 

Then I thought about adding some other property (maybe <EnumFacing> stuff??) to know the specific side (can only be one at the same time).

 

Base idea: In the middle is a default cube and more models are added to either side depending on the connections. So something similiar to another problem I had some time ago (can't find the link currently),

but with one side beeing different as stateted.

 

My problem know is (assuming the thoughts from above are correct and the best possible way):

• How to handle getStateFromMeta, getActualState and getMetaFromState?
• How to handle the JSON file that model X will be used on side X instead of the normal model which is used for all other sides? [side x = any side && number of side x connections <= 1]
• How would I handle the above when it would be: number of side x connections < all possible sides

 

Thx in advance.

Bektor

[Draco18s]

Use bool properties, like the fence and cobblestone wall do. There is no reason to get fancier than that.

getStateFromMeta / getMetaFromState will likely do nothing special

getActualState will handle the which-sides-are-connected bool properties (they do not need to be encoded in metadata because their properties of the world)

 

[Bektor]

  On 10/25/2017 at 6:01 PM, Draco18s said:

Use bool properties, like the fence and cobblestone wall do. There is no reason to get fancier than that.

 

Expand  

Wouldn't this mean I've got 12 properties? 6 for all the possible sides and another 6 for all possible sides of the "side x".

Also I don't see where this meets with the conditions of side x.

 

  On 10/25/2017 at 6:01 PM, Draco18s said:

they do not need to be encoded in metadata because their properties of the world

Expand  

Meaning visual stuff doesn't need to be encoded to metadata and everything else does, correct?

[Draco18s]

  On 10/25/2017 at 6:46 PM, Bektor said:

Wouldn't this mean I've got 12 properties? 6 for all the possible sides and another 6 for all possible sides of the "side x".

Expand  

Yes. And?

You could also use an enum:

NOT_CONNECTED, CONNECTED, CONNECTED_MACHINE

  2 hours ago, Bektor said:

Meaning visual stuff doesn't need to be encoded to metadata and everything else does, correct?

Expand  

Well, it can be non-visual information as well. But yes, any information you can arrive at by looking at adjacent blocks does not need to be encoded in metadata.

[Bektor]

  On 10/25/2017 at 9:17 PM, Draco18s said:

Yes. And?

 

Expand  

Well, quite a lot. (thinking of over-complex json files with a lot of lines)

  On 10/25/2017 at 9:17 PM, Draco18s said:

You could also use an enum:

NOT_CONNECTED, CONNECTED, CONNECTED_MACHINE

Expand  

I guess this would be difficult because it doesn't tell the json file at which side the special model should be used.

 

I'm also wondering how I could got about limiting the connections so that only one special model can be used to avoid multiply sides having this special

model as it should indicate a connection towards a machine and the block can only connect to one machine at a time, but to a dozen cables at the same time.

 

Also, how would I go with the JSON file? I mean, thinking of the boolean properties I would be required to create 6 entries for the 6 properties in the json file and inside of all of those entries I would again need to define 6 entries + one for when none of these other six is used, creating 42 entries... and that's totally not what I want.

While also having the problem with multiply special models beeing used at the same time?

[Draco18s]

  On 10/25/2017 at 10:35 PM, Bektor said:

Well, quite a lot. (thinking of over-complex json files with a lot of lines)

I guess this would be difficult because it doesn't tell the json file at which side the special model should be used.

Expand  

I meant that enum for each side instead of two booleans.

  35 minutes ago, Bektor said:

Also, how would I go with the JSON file? I mean, thinking of the boolean properties I would be required to create 6 entries for the 6 properties in the json file and inside of all of those entries I would again need to define 6 entries + one for when none of these other six is used, creating 42 entries... and that's totally not what I want.

While also having the problem with multiply special models beeing used at the same time?

Expand  

Use the Forge format where each property is separate from each other:

http://mcforge.readthedocs.io/en/latest/blockstates/forgeBlockstates/#sub-models

[Bektor]

  On 10/25/2017 at 11:11 PM, Draco18s said:

Use the Forge format where each property is separate from each other:

http://mcforge.readthedocs.io/en/latest/blockstates/forgeBlockstates/#sub-models

Expand  

Hm... This still results into nearly 200 lines of json file...

 

I've also got another problem:

• I've created now an array containing all of the first 6 properties and another one for the next 6 properties. How do I combine them now in createBlockState?

 

[Draco18s]

new BlockStateContainer({ A, B, C, D, E, F, G, H, I, J, K, L})

[Bektor]

  On 10/29/2017 at 11:16 PM, Draco18s said:

new BlockStateContainer({ A, B, C, D, E, F, G, H, I, J, K, L})

Expand  

Any way to do this automatically without having to list each one of the properties manually? (got two arrays)

[Draco18s]

The parameter to BlockStateContainer's constructor already takes an IProperty[] array, so use array operation magic.

Edited October 30, 2017 by Draco18s

[Choonster]

Use BlockStateContainer.Builder to create the BlockStateContainer, you can call BlockStateContainer.Builder#add once for each array of properties

[Bektor]

  On 10/30/2017 at 7:41 AM, Choonster said:

Use BlockStateContainer.Builder to create the BlockStateContainer, you can call BlockStateContainer.Builder#add once for each array of properties

Expand  

Thx, didn't know there was such a method.

 

Thought as can be seen in the image: There is also an connection on the wrong side (happens only for west and east sides).

	protected boolean isValidConnection(IBlockAccess worldIn, BlockPos pos, IBlockState neighbourState, EnumFacing facing) {
        if(super.isValidConnection(worldIn, pos, neighbourState, facing))
            return true;
        
        TileEntity tile = worldIn.getTileEntity(pos.offset(facing));
        if(tile != null)
            return EnergyUtils.hasCapability(tile, facing);
        
        return false;
    }
    
    private boolean canConnectToMachine(final IBlockAccess worldIn, final IBlockState state, final BlockPos pos, EnumFacing facing) {
        final BlockPos neighborPos = pos.offset(facing);
        final IBlockState neighbourState = worldIn.getBlockState(neighborPos);
        
        return this.isValidConnection(worldIn, pos, neighbourState, facing) && !(neighbourState instanceof BlockCableConnector) && !(neighbourState instanceof BlockCable);
    }
    
    @Override
    public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
        for(final EnumFacing facing : EnumFacing.VALUES)
            state = super.getActualState(state, worldIn, pos).withProperty(SPECIAL_PROPERTIES.get(facing.getIndex()), this.canConnectToMachine(worldIn, state, pos, facing));
        
        return state;
    }
    
    @Override
    protected BlockStateContainer createBlockState() {
        return new BlockStateContainer.Builder(this)
                .add(CONNECTED_PROPERTIES.toArray(new IProperty[CONNECTED_PROPERTIES.size()]))
                .add(SPECIAL_PROPERTIES.toArray(new IProperty[SPECIAL_PROPERTIES.size()]))
                .build();
    }

 

BlockCableConnector is this block while BlockCable is the block on the left side of the image. The SPECIAL_PROPERTIES adds this larger thing on the smaller middle part of the cable while the CONNECTED_PROPERTIES just adds the normal element to the side (which can be seen in there.)

[Bektor]

Bump.

[Bektor]

Anyone who might know what's wrong??

[jeffryfisher]

Set a breakpoint in getActualState. Use the debugger to step through / into the decision processes to see where the errant state is being made.