[1.12] Copy NBT on crafting

[Melonslise]

I need to know how to copy the NBT of an ingredient and copy it over to the result. Can this be done with the existing system? If not how would I go about doing it? I've read about an IRecipe implementation, but I'm not sure about the rest of the process.

Edited November 25, 2017 by Melonslise

[Draco18s]

You need a custom IRecipe implementation.

Look at Choonster's TestMod3 for an example of something similar.

Pay special attention to the _factories.json file in the assets.

[Melonslise]

Ok I made an IRecipe implementation as well as a nested factory. What do I do next? Is the factory required? I'm not really parsing anything because I just need access to the items' NBT.

Edited November 25, 2017 by Melonslise

[Draco18s]

28 minutes ago, Melonslise said:

Ok I made an IRecipe implementation as well as a nested factory. What do I do next? Is the factory required? I'm not really parsing anything because I just need access to the items' NBT.

You still need it, yes. Because you still have to declare some kind of input: it has to parse that JSON file somehow.

[Melonslise]

But what do I do next, though? My guess is to register the recipe with the registry event? What is the factory needed for in that case?

EDIT: Also what is the isDynamic method for in the IRecipe interface? It doesn't have a description.

Edited November 25, 2017 by Melonslise

[Draco18s]

isDynamic? I don't see that method in IRecipe. What release # of Forge are you using?

1 hour ago, Melonslise said:

But what do I do next, though? My guess is to register the recipe with the registry event?

Nothing. Once you have an implementation and it's mentioned in your _factories.json your next step is to use it. That's it. You're done.

[Melonslise]

Right, I think I got it to work. What I don't understand is why I need to instantiate the recipe when registering it with the event if its factory constantly does that. Doesn't that kind of kill the point of registries? Do I even need to keep a static reference to the recipe like I do with all other entries? Also I'm getting a crash if I don't set the recipe's registry name, but I don't understand why that's required since the factory creates copies (which again kills the purpose of registries).

Edited November 25, 2017 by Melonslise

[Draco18s]

2 hours ago, Melonslise said:

What I don't understand is why I need to instantiate the recipe when registering it with the event if its factory constantly does that.

You don't:

3 hours ago, Draco18s said:

Nothing. Once you have an implementation and it's mentioned in your _factories.json your next step is to use it. That's it. You're done.

 

2 hours ago, Melonslise said:

Do I even need to keep a static reference to the recipe like I do with all other entries?

No.

 

2 hours ago, Melonslise said:

Also I'm getting a crash if I don't set the recipe's registry name, but I don't understand why that's required since the factory creates copies (which again kills the purpose of registries).

Always post crash logs.

[Choonster]

7 hours ago, Draco18s said:

You need a custom IRecipe implementation.

Look at Choonster's TestMod3 for an example of something similar.

Pay special attention to the _factories.json file in the assets.

 

Just for future reference, you linked to the 1.12.1 branch; which is currently 11 commits behind 1.12.2 (the branch with the latest changes on it).

 

I also recommend linking to a file/folder in a specific commit rather than a branch so that the link will remain pointing to the same code in the future rather than pointing to code that's been changed/removed.

[Melonslise]

I don't understand. Without registering the recipe with the registry event the recipe doesn't work at all. I did add its factory to the _factories.json. I looked at vanilla too and I've found more specific recipes like book cloning being registered (but in some different way).

Edited November 26, 2017 by Melonslise

[Choonster]

You need to specify the IRecipeFactory class in the _factories.json file and then create the individual recipe JSON files for any recipes that use the recipe class.

[Melonslise]

I did add the factory class to my _factories.json. Since my recipe is pretty much hard coded I don't need any json files for the recipe. Or do I still have to create some basic recipe json?

Edited November 26, 2017 by Melonslise

[Choonster]

1 hour ago, Melonslise said:

I did add the factory class to my _factories.json. Since my recipe is pretty much hard coded I don't need any json files for the recipe. Or do I still have to create some basic recipe json?

 

Using the JSON system is the recommended way to add recipes (and should be used wherever possible), but you can instantiate and register the recipe from code during RegistryEvent.Register<IRecipe> if necessary.

[Melonslise]

So that means I do need to give it a registry name and I don't need a factory for it. I tried making a reusable version and failed, because all vanilla examples I looked at used some helper specific only to that recipe which I couldn't decipher because there it had no descriptions.

Edited November 26, 2017 by Melonslise

[Draco18s]

55 minutes ago, Melonslise said:

So that means I do need to give it a registry name and I don't need a factory for it. I tried making a reusable version and failed, because all vanilla examples I looked at used some helper specific only to that recipe which I couldn't decipher because there it had no descriptions.

Those helpers really aren't that hard to understand. Every recipe factory I've created I've done by going "here's a vanilla/forge recipe that's really close to what I want...COPY....PASTE!"

[Demonly]

13 minutes ago, Draco18s said:

Those helpers really aren't that hard to understand. Every recipe factory I've created I've done by going "here's a vanilla/forge recipe that's really close to what I want...COPY....PASTE!"

Actually I am personally starting to notice that as well with a variety of things, like how to set NBT to an entity and save it/read it later.

[Draco18s]

For recipes, there's no reason to reimplement something complicated like reading an item stack, vanilla did that already. 

 

Custom achievements though...99% copy-paste for the whole class. You literally go in, modify what data it is that needs to be deserialized and checked against (if any!) and then just fix all the red that shows up until it is gone. You modify like 12 lines total.