Jump to content

[1.12] Copy NBT on crafting


Melonslise

Recommended Posts

I need to know how to copy the NBT of an ingredient and copy it over to the result. Can this be done with the existing system? If not how would I go about doing it? I've read about an IRecipe implementation, but I'm not sure about the rest of the process.

Edited by Melonslise
Link to comment
Share on other sites

You need a custom IRecipe implementation.

Look at Choonster's TestMod3 for an example of something similar.

Pay special attention to the _factories.json file in the assets.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

28 minutes ago, Melonslise said:

Ok I made an IRecipe implementation as well as a nested factory. What do I do next? Is the factory required? I'm not really parsing anything because I just need access to the items' NBT.

You still need it, yes. Because you still have to declare some kind of input: it has to parse that JSON file somehow.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

But what do I do next, though? My guess is to register the recipe with the registry event? What is the factory needed for in that case?

EDIT: Also what is the isDynamic method for in the IRecipe interface? It doesn't have a description.

Edited by Melonslise
Link to comment
Share on other sites

isDynamic? I don't see that method in IRecipe. What release # of Forge are you using?

1 hour ago, Melonslise said:

But what do I do next, though? My guess is to register the recipe with the registry event?

Nothing. Once you have an implementation and it's mentioned in your _factories.json your next step is to use it. That's it. You're done.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Right, I think I got it to work. What I don't understand is why I need to instantiate the recipe when registering it with the event if its factory constantly does that. Doesn't that kind of kill the point of registries? Do I even need to keep a static reference to the recipe like I do with all other entries? Also I'm getting a crash if I don't set the recipe's registry name, but I don't understand why that's required since the factory creates copies (which again kills the purpose of registries).

Edited by Melonslise
Link to comment
Share on other sites

2 hours ago, Melonslise said:

What I don't understand is why I need to instantiate the recipe when registering it with the event if its factory constantly does that.

You don't:

3 hours ago, Draco18s said:

Nothing. Once you have an implementation and it's mentioned in your _factories.json your next step is to use it. That's it. You're done.

 

2 hours ago, Melonslise said:

Do I even need to keep a static reference to the recipe like I do with all other entries?

No.

 

2 hours ago, Melonslise said:

Also I'm getting a crash if I don't set the recipe's registry name, but I don't understand why that's required since the factory creates copies (which again kills the purpose of registries).

Always post crash logs.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

7 hours ago, Draco18s said:

You need a custom IRecipe implementation.

Look at Choonster's TestMod3 for an example of something similar.

Pay special attention to the _factories.json file in the assets.

 

Just for future reference, you linked to the 1.12.1 branch; which is currently 11 commits behind 1.12.2 (the branch with the latest changes on it).

 

I also recommend linking to a file/folder in a specific commit rather than a branch so that the link will remain pointing to the same code in the future rather than pointing to code that's been changed/removed.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

I don't understand. Without registering the recipe with the registry event the recipe doesn't work at all. I did add its factory to the _factories.json. I looked at vanilla too and I've found more specific recipes like book cloning being registered (but in some different way).

Edited by Melonslise
Link to comment
Share on other sites

You need to specify the IRecipeFactory class in the _factories.json file and then create the individual recipe JSON files for any recipes that use the recipe class.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

1 hour ago, Melonslise said:

I did add the factory class to my _factories.json. Since my recipe is pretty much hard coded I don't need any json files for the recipe. Or do I still have to create some basic recipe json?

 

Using the JSON system is the recommended way to add recipes (and should be used wherever possible), but you can instantiate and register the recipe from code during RegistryEvent.Register<IRecipe> if necessary.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

So that means I do need to give it a registry name and I don't need a factory for it. I tried making a reusable version and failed, because all vanilla examples I looked at used some helper specific only to that recipe which I couldn't decipher because there it had no descriptions.

Edited by Melonslise
Link to comment
Share on other sites

55 minutes ago, Melonslise said:

So that means I do need to give it a registry name and I don't need a factory for it. I tried making a reusable version and failed, because all vanilla examples I looked at used some helper specific only to that recipe which I couldn't decipher because there it had no descriptions.

Those helpers really aren't that hard to understand. Every recipe factory I've created I've done by going "here's a vanilla/forge recipe that's really close to what I want...COPY....PASTE!"

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

13 minutes ago, Draco18s said:

Those helpers really aren't that hard to understand. Every recipe factory I've created I've done by going "here's a vanilla/forge recipe that's really close to what I want...COPY....PASTE!"

Actually I am personally starting to notice that as well with a variety of things, like how to set NBT to an entity and save it/read it later.

Link to comment
Share on other sites

For recipes, there's no reason to reimplement something complicated like reading an item stack, vanilla did that already. 

 

Custom achievements though...99% copy-paste for the whole class. You literally go in, modify what data it is that needs to be deserialized and checked against (if any!) and then just fix all the red that shows up until it is gone. You modify like 12 lines total. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm using Modrinth as a launcher for a forge modpack on 1.20.1, and can't diagnose the issue on the crash log myself. Have tried repairing the Minecraft instillation as well as removing a few mods that have been problematic for me in the past to no avail. Crash log is below, if any further information is necessary let me know. Thank you! https://paste.ee/p/k6xnS
    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.