Jump to content

[1.12.2] Shapeless Ore Recipes w/ Single Ingredient Type can be Substituted for Any Item


Recommended Posts

Posted

Hi there,

 

I believe to have uncovered a bug in Minecraft Forge. Either that or I've misunderstood how to create shapeless ore recipes - apologies in advanced if I have. Below I've tried to describe the issue in as much detail as I could I hope the information included contains all the necessary information. 

 

  • Java 1.8.0_131 (64 bit)

  • Minecraft 1.12.2

  • Minecraft Forge 14.23.1.2554

 

In my setup, I'm using the example mod which is packaged with the Minecraft Forge MDK (version information stated above). I've added a singular shapeless ore recipe at the path specified in figure 1 (Recipe filename is figure 2). Within the JSON file I've created (figure 3) what I know to be the correct syntax for a Forge shapeless ore recipe . My recipe example is 3 gravel to 1 flint.

 

Now that I've created my recipe I've loaded up the game,  created a single player world, and attempted to craft the recipe (both crafting table and in inventory). The recipe, as expected, works perfectly fine. However, if I should substitute any of the ingredients of the recipe with any other item I'm presented with my recipe in the output slot once more.

 

Note: For the substitution to work I still must have the correct quantity of the item required normally for the recipe when crafting with substitutes otherwise the recipe will not work. This can be seen visually in figure 7.

 

So, why does this happen? I have two hypothesis as to why this occurs, they are:

 

  1. When parsing the recipe, it fails to check that all the ingredients are the correct item.
  2. The recipe file doesn't correctly pick up the ore dict reference (e.g. gravel, ingotIron, stickWood, etc.)
  3. The recipe is parsed as "correct" because the correct amount of the singular ingredient required for the recipe appears in a single item stack 

 

I could be completely wrong. Probably am. All I know for sure is this is weird behaviour that you wouldn't expect. 

 

Figure 1 - The file path to the recipe JSON.

src/main/resources/assets/examplemod/recipes/

 

Figure 2 - The filename of the recipe JSON.

flint.json

 

Figure 3 - The JSON itself.

https://gist.github.com/anonymous/563e066652a2d3c321d0155ae2739f82

 

Figure 4 - Crafting the recipe with the correct ingredients in a crafting table.

https://ss.blamesnow.co.uk/2017/11/1511721182-adfbcb58.gif

 

Figure 5 - Crafting the recipe with the correct ingredients in the player crafting window.

https://ss.blamesnow.co.uk/2017/11/1511721281-45573e89.gif

 

Figure 6 - Crafting the recipe with the incorrect ingredients in a crafting table.

https://ss.blamesnow.co.uk/2017/11/1511721364-593bdcc2.gif

 

Figure 7 - Crafting the recipe with the incorrect ingredients in the player crafting window.

https://ss.blamesnow.co.uk/2017/11/1511721487-cfee540b.gif

width=16 height=16

http://i.imgur.com/4MIQrE0.png[/img] Feed the Beast Modpack Developer & Maintainer width=16 height=16http://i.imgur.com/6RNctNx.png[/img]

Front End Developer -|- Modpack Developer -|- Winner of Jampacked 2

UK - https://twitter.com/SnowShock35

Posted

There was a custom shapeless recipe matching system added in Forge 1.12.2-14.23.0.2552. Maybe there's a bug in there. Can you try with a version below that?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted
Just now, larsgerrits said:

There was a custom shapeless recipe matching system added in Forge 1.12.2-14.23.0.2552. Maybe there's a bug in there. Can you try with a version below that?

The bug occurs in any build above 14.23.0.2531 - It's been on my to do list to report this for a while. - I've seen several recipe related PR's and changes in the Forge changelog which I assumed fixed the issue but every time there was no success. Hence reporting it here. 

width=16 height=16

http://i.imgur.com/4MIQrE0.png[/img] Feed the Beast Modpack Developer & Maintainer width=16 height=16http://i.imgur.com/6RNctNx.png[/img]

Front End Developer -|- Modpack Developer -|- Winner of Jampacked 2

UK - https://twitter.com/SnowShock35

Posted

Thanks for actually reporting it. We've been trying to track down all the edge cases. I was able to reproduce this on my end.

It's happening in Vanilla code, so im seeing if I can isolate as much as I can. Then i'll report it to Grum and have him fix it in vanilla. While I fix it in 1.12.2.

 

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted

No problem. I thought I remember seeing you mention this somewhere else. On a PR perhaps?

 

It's a really strange issue that's for sure. My solution for now is to find any recipes with this problem and remove them then re-add them using CraftTweaker since it doesn't have this problem. While not ideal it's the best bet for now especially since a lot of mods are updating their minimum Forge version to the new recommended build and I wanna keep mods up to date in packs as well as use the recommended version myself to take advantage of things that have been fixed as well as the new features e.g. the commands. 

width=16 height=16

http://i.imgur.com/4MIQrE0.png[/img] Feed the Beast Modpack Developer & Maintainer width=16 height=16http://i.imgur.com/6RNctNx.png[/img]

Front End Developer -|- Modpack Developer -|- Winner of Jampacked 2

UK - https://twitter.com/SnowShock35

Posted

Solved for now by forcing it to use my matching system, so use 2555. I've passed this along to those that need it so we can make sure its fixed for 1.13.

  • Like 1

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted
8 minutes ago, LexManos said:

Solved for now by forcing it to use my matching system, so use 2555. I've passed this along to those that need it so we can make sure its fixed for 1.13.

Thanks a ton Lex. 

width=16 height=16

http://i.imgur.com/4MIQrE0.png[/img] Feed the Beast Modpack Developer & Maintainer width=16 height=16http://i.imgur.com/6RNctNx.png[/img]

Front End Developer -|- Modpack Developer -|- Winner of Jampacked 2

UK - https://twitter.com/SnowShock35

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.