[1.12] Do BlockItems need JSON's?

[oldcheese]

Hey there. Currently I'm in the process of updating everything to 1.12, since I'm fairly sure that I'm never going to finish my mod while 1.10 is still relevant. And it's plainly easier to release everything for 1.12 and have longevity for a year or so.

 

Anyway.  I'm registering blocks and blockItems as such: 

 

    @SubscribeEvent
    public void registerBlocks(RegistryEvent.Register<Block> event){
        final Block[] blocks = {
                oreSilver,
                shrine,
        };

        event.getRegistry().registerAll(blocks);
    }

    @SubscribeEvent
    public void registerItemBlock(RegistryEvent.Register<Item> event){
        final ItemBlock[] items = {
             new ItemBlock(shrine),
             new ItemBlock(oreSilver),
        };
        for(final ItemBlock item:items){
            final Block block = item.getBlock();
            event.getRegistry().register(item.setRegistryName(block.getRegistryName()));
        }
    }

 

 

obviously I subscribe the event and such.

 

If I don't register an ItemBlock I don't get an item. Previously I was able to just get an item from the block, considering that blocks had an item that was just a miniature render of the block.

 

Now all of my itemBlocks give me a default/missing pink and black texture.

 

Is that because I need a JSON file and a texture for all my blocks? Is there a way to simply add a default texture to my items? The setCustomModelResourceLocation method still works, but I'm assuming there's perhaps a more up to date method?

 

 

 

[Draco18s]

You need to subscribe to the ModelRegistryEvent in order to register models for your items with ModelLoader.setCustomModelResourceLocation

[oldcheese]

35 minutes ago, Draco18s said:

You need to subscribe to the ModelRegistryEvent in order to register models for your items with ModelLoader.setCustomModelResourceLocation

 

Alright. I've simply added the blocks to my renderer using 

 

	@SubscribeEvent
	public void registerRenders(ModelRegistryEvent event){
		registerRender(Item.getItemFromBlock(RPVPBlocks.oreSilver));
		registerRender(Item.getItemFromBlock(RPVPBlocks.shrine));

	}

	private static void registerRender(Item item) {
		ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
	}

 

which seems to automatically render the item as a small block, no JSON needed. Though I see how I could make a custom icon using that.

 

Thanks.

[Draco18s]

44 minutes ago, oldcheese said:

which seems to automatically render the item as a small block, no JSON needed. Though I see how I could make a custom icon using that.

Blocks default to using the blockstate json to determine their model. (That's what the "inventory" or "normal" variant section is for)

Bare items use an item model json file (which is typically a subtype of item/generated which is itself a subtype of builtin/generated, which creates the model from a texture).