Jump to content

Recommended Posts

Posted

I am having an issue with porting a mod from 1.11 to 1.12.2. I think I have all the block and item registration setup correctly, but when I go to launch the game, it crashes right away and gives an error about existing registry names. I am not sure what I have to change to move past this. 

 

Crash log is here:  https://pastebin.com/pujTMbfa

 

I am not even sure what code I would need to provide to be more helpful on my end, so please let me know.

 

Thank you so much

Posted
7 hours ago, diesieben07 said:

You are calling setRegistryName twice on the same object, this is not allowed. We need to see your code to know where.

I solve the problem, but I just want to make sure I have my answer straight. When I register a Tile Entity, it is the same thing as registering a block correct? I.E. I do not need to register both a block and a tile entity for the same object.

Posted
29 minutes ago, Dongle12 said:

I solve the problem, but I just want to make sure I have my answer straight. When I register a Tile Entity, it is the same thing as registering a block correct? I.E. I do not need to register both a block and a tile entity for the same object.

No, it is not the same thing. TileEntities should be rare, but in either case, if you have one, you do need to register it.

However, that is not your problem here. Registering two items is not the same as registering the same thing twice. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
2 hours ago, Draco18s said:

No, it is not the same thing. TileEntities should be rare, but in either case, if you have one, you do need to register it.

However, that is not your problem here. Registering two items is not the same as registering the same thing twice. 

 

Alright thanks, turns out my problem wasn't solved. I have tried limiting changing the code around to ensure that it doesn't register the same thing twice, but I think I do not fully grasp registering or am missing something and registering the block twice by accident.

 

The crash log starts with this: java.lang.IllegalStateException: Attempted to set registry name with existing registry name! New: BlockCompressedTorcherino Old: torcherino:blocktorcherino, and then points to line #9 of the BlockCompressedTorcherino class which has the following. 

 

public final class BlockCompressedTorcherino extends BlockTorcherino {
    public BlockCompressedTorcherino() {
        setRegistryName("BlockCompressedTorcherino");
        setUnlocalizedName("torcherino.compressed_torcherino");
    }

    @Override
    public TileEntity createNewTileEntity(final World world, final int i) {
        return new TileCompressedTorcherino();
    }
}

 

Line # 9 is the setRegistryName() function call.

 

From there I do the block registering in the CommonProxy(). The block registration code looks like the following: 

 

    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event) {
    	
    	event.getRegistry().register(new BlockTorcherino());
    	GameRegistry.registerTileEntity(TileTorcherino.class, "torcherino_tile");

    	event.getRegistry().register(new BlockCompressedTorcherino());
    	GameRegistry.registerTileEntity(TileCompressedTorcherino.class, "compressed_torcherino_tile");

    	event.getRegistry().register(new BlockDoubleCompresedTorcherino());
    	GameRegistry.registerTileEntity(TileDoubleCompressedTorcherino.class, "double_compressed_torcherino_tile");
    }

 

It runs into trouble at the line event.getRegistry().register(new BlockCompressedTorcherino()); 

 

I think this issue may stem from the BlockCompressedTorcherino extending the BlockTorcherino class which has code for setting registry name already in its constructor: setRegistryName("blocktorcherino"); 

 

 

Posted
19 minutes ago, diesieben07 said:

 

Alright thank you for the link to the code changes. I seem to have it working, although my solution seems a bit hacked together to me. I fixed it by removing the setRegistryName() call from the super and subclasses, and then in my CommonProxy(), I create new objects, and then set their appropriate names there. Is this a correct approach to fixing this issue?

 

Posted

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to create block with entity, that will have height of 3 or more(configurable) and I tried to change first VoxelShape by increasing collision box on height I want and for changing block height on visual side i tried to configure BlockModelBuilder:  base.element() .from(0, 0, 0) .to(16f, 48f, 16f) .face(Direction.UP).texture("#top").end() .face(Direction.DOWN).texture("#bottom").end() .face(Direction.NORTH).texture("#side").end() .face(Direction.SOUTH).texture("#side").end() .face(Direction.WEST).texture("#side").end() .face(Direction.EAST).texture("#side").end() .end(); but, getting crash with next error: Position y out of range, must be within [-16, 32]. Found: %d [48.0]; Looks like game wont to block height modified by more than 32. Is there any way to fix that problem?
    • As long as the packets you are sending aren't lost, there's nothing wrong with what you're currently doing. Although, this sounds like something that would benefit from you making your own datapack registry instead of trying to arbitrarily sync static maps. Check out `DataPackRegistryEvent.NewRegistry`.
    • Hey all, I've been working a lot with datapacks lately, and I'm wondering what the most efficient way to get said data from server to client is.  I'm currently using packets, but given that a lot of the data I'm storing involves maps along the lines of Map<ResourceLocation, CustomDataType>, it can easily start to get messy if I need to transmit a lot of that data all at once. Recently I started looking into the ReloadableServerResources class, which is where Minecraft stores its built-ins.  I see you can access it via the server from the server's resources.managers, and it seems like this can be done even from the client to appropriately retrieve data from the server, unless I'm misunderstanding.  However, from what I can tell, this only works via built-in methods such as getRecipeManager() or getLootTables(), etc.  These are all SimpleJsonResourceReloadListeners, just like my datapack entries are, so it seems like it could be possible for me to access my datapack entries similarly?  But I don't see anywhere in ReloadableServerResources that stores loaded modded entries, so either I'm looking in the wrong place or it doesn't seem to be a thing. Are packets really the best way of doing this, or am I missing a method that would let me use ReloadableServerResources or something similar?
    • Hi, everyone! I'm new to minecraft modding stuff and want ask you some questions. 1. I checked forge references and saw there com.mojang and net.minecraft (not net.minecraftforge) and as I understand it's original game packages with all minecraft logic inside including renderers and so on, right? 2. Does it mean that forge has a limited set of instruments which doesn't cover all the aspects of the game? If make my question more specific then does forge provide such instruments that allow me totally change minecraft itself, like base mechanics and etc.? Or I have to use "original game packages" to implement such things? 3. I actively learning basic concepts with forge documentation and tutorials. So in my plans make different inventory system like in diabloids. Is that possible with forge? 4. It is last question related to the second one. So how deeply I can change minecraft with forge? I guess all my questions above because of that I haven't globally understanding what forge is and how it works inside and how it works with minecraft. It would be great if you provide some links or topics about it or explain it by yourself but I guess it's to big to be explained in that post at once. Anyway, thank you all for any help!
    • Im trying add to block a hole in center, just a usual block and in center of it on up side, there is should be a hole. I tried to add it via BlockModelBuilder, but its not working. Problem is that it only can change block size outside. I tried it to do with VoxelShape and its working, but its has been on server side and looks like its just changed collision shape, but for client, there is a texture covering this hole. I tried to use: base.renderType("cutout"); and removed some pixels from texture. I thought its should work, but game optimization makes block inside looks transparent. So, only custom model?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.