Remove possibility to place string (tripwire)

[Newww]

public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
 {
          ItemStack item = event.item;
           
          if (itemStack == Items.string)
          {
         event.item.useItemRightClick(null, null);
          }
  }

___________________________________________________________________

That's how far I got, not really far at all lol.

I want string to do nothing at all when you right click it, just like gunpowder or glowstone for instane.

Does someone have an idea what I could do?

[Matryoshika]

You are comparing an ItemStack(that contains an item) to an item. You need to use ItemStack::getItem, and then compare it.

ItemStack::useItemRightClick does not do what you think it does, by the way. It is normally called when an item is rightclicked, and replaces the current ItemStack to a new one (normally the same itemstack, perhaps +-1 stack-count depending on what the item actually does).
If you want to block the player from actually using the item, call Event::setCanceled(true).

 

[Newww]

9 minutes ago, Matryoshika said:

You are comparing an ItemStack(that contains an item) to an item. You need to use ItemStack::getItem, and then compare it.

ItemStack::useItemRightClick does not do what you think it does, by the way. It is normally called when an item is rightclicked, and replaces the current ItemStack to a new one (normally the same itemstack, perhaps +-1 stack-count depending on what the item actually does).
If you want to block the player from actually using the item, call Event::setCanceled(true).

 

Ok, thanks! I'm just having some problems translating that into some working code :L

_________________________________________________________________________

   public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
   {
           ItemStack getItem;
           
           if (itemStack == Items.string)
           {
           event.setCanceled(true);
           }
   }

[Matryoshika]

ItemStack is not an item. You are still trying to compare them, which will always return false.
You get an ItemStack from the event. You then need to get the item out of the ItemStack. You then compare the item, to string.

[Newww]

14 minutes ago, Matryoshika said:

ItemStack is not an item. You are still trying to compare them, which will always return false.
You get an ItemStack from the event. You then need to get the item out of the ItemStack. You then compare the item, to string.

" ItemStack getItem; " gets the item out of the stack right? But what's the single item called?

_______________________________________________

 

public class TripWireRem {

   public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
    {
           ItemStack getItem;
           
           if (Item == Items.string)
           {
           event.setCanceled(true);
           }
   }
}

 

[Matryoshika]

"getItem" is a non-static method, in the ItemStack class. You need to call it on an ItemStack.

As it is right now, your code will not even compile, and your IDE should tell you as much.

Edited December 29, 2017 by Matryoshika

[Newww]

3 minutes ago, Matryoshika said:

"getItem" is a non-static method, in the ItemStack class. You need to call it on an ItemStack.

As it is right now, your code will not even compile, and your IDE should tell you as much.

Ahhh D: I'm sorry, but I really don't know how to translate that into code.

[Matryoshika]

event.item returns an ItemStack.
event.item.getItem() returns an actual Item.

 

This is basic Java...

[Newww]

2 minutes ago, Matryoshika said:

event.item returns an ItemStack.
event.item.getItem() returns an actual Item.

 

This is basic Java...

And is " event.setCanceled(true); " at the end enough to cancel the right click action, so it doesn't place the string? Or do I need to say which event has to get canceled?

[Matryoshika]

"event" is given to you by the EventHandler, because your method "PlayerUseItemEvent" requires a Start Event (which here is a sub-class of the actual PlayerUseItemEvent)

(Your method shouldn't have the same name as the event, as it can get confusing).
This "event" will always be of the type PlayerUseItemEvent, specifically before the item is used. (As indicated of the sub-type Start).

As such, you do not have to worry about "which" event, because this will only work for the event that you have.

 

For the future, you should also look up what Static and Non-Static classes, methods and fields means. This is as said basic Java knowledge, which is sorely needed, but not taught here.

Edited December 29, 2017 by Matryoshika

[Newww]

6 minutes ago, Matryoshika said:

"event" is given to you by the EventHandler, because your method "PlayerUseItemEvent" requires a Start Event (which here is a sub-class of the actual PlayerUseItemEvent)

(Your method shouldn't have the same name as the event, as it can get confusing).
This "event" will always be of the type PlayerUseItemEvent, specifically before the item is used. (As indicated of the sub-type Start).

As such, you do not have to worry about "which" event, because this will only work for the event that you have.

 

For the future, you should also look up what Static and Non-Static classes, methods and fields means. This is as said basic Java knowledge, which is sorely needed, but not taught here.

I'm just going to stop and hope that someone else writes a mod that does the same thing lol.

[Newww]

2 hours ago, Matryoshika said:

"event" is given to you by the EventHandler, because your method "PlayerUseItemEvent" requires a Start Event (which here is a sub-class of the actual PlayerUseItemEvent)

(Your method shouldn't have the same name as the event, as it can get confusing).
This "event" will always be of the type PlayerUseItemEvent, specifically before the item is used. (As indicated of the sub-type Start).

As such, you do not have to worry about "which" event, because this will only work for the event that you have.

 

For the future, you should also look up what Static and Non-Static classes, methods and fields means. This is as said basic Java knowledge, which is sorely needed, but not taught here.

Could you maybe write that short piece of code for me to copy? That would be really kind of you!

[Matryoshika]

No.
Why won't I?
Because this forum is meant to help people with their own code.
If I write the code for you, you won't know what the heck it does, why it does it, when it does it, nor how it does it.

If you have any issues, you would have no idea how to solve them, and would need further help.

 

You were pretty close last time around, just had to actually compare an item against an item.

[Newww]

6 minutes ago, Matryoshika said:

No.
Why won't I?
Because this forum is meant to help people with their own code.
If I write the code for you, you won't know what the heck it does, why it does it, when it does it, nor how it does it.

If you have any issues, you would have no idea how to solve them, and would need further help.

 

You were pretty close last time around, just had to actually compare an item against an item.

Don't make it so difficult for me :L I just wanted to know how I could get that code to work. I'm just not good with java :L

[Matryoshika]

Difficult? How am I making this difficult?
I've told you how to get the item

2 hours ago, Matryoshika said:

event.item.getItem() returns an actual Item.

I have told you how to cancel the event.
Now you take one, and stick it to the other, and you're done.

[Newww]

6 minutes ago, Matryoshika said:

Difficult? How am I making this difficult?
I've told you how to get the item

I have told you how to cancel the event.
Now you take one, and stick it to the other, and you're done.

Like this? :L

___________________________________________

       public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }

[Matryoshika]

You are comparing the items correctly now, yes.
However, you should be getting the ItemStack from the event itself, not from the player. (Go back to ItemStack stack = event.getItem())

And on another note, I am now seeing what I missed before. Your method takes in two arguments (the Event & Item).

This code will never be called because you have more than one arguments. Forge's EventHandler (which is the thing that goes "HEY, this happened, do your stuff") can only see static methods that need one argument, and that has to be some type of Event.
TL;DR remove the Item itemStack at the top, and put "static" after the "public", before the "void".

Edited December 29, 2017 by Matryoshika

[Newww]

9 minutes ago, Newww said:

Like this? :L

___________________________________________

       public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }

It doesn't do anything. Still places that dumb tripwire :L Is " PlayerUseItemEvent " even the correct on to use?

[Differentiation]

6 minutes ago, Newww said:

It doesn't do anything. Still places that dumb tripwire :L Is " PlayerUseItemEvent " even the correct on to use?

*******

@SubscribeEvent
public void onPlayerUseItem(PlayerUseItemEvent event)
{
 ...
}

Properly SUBSCRIBE to the event, THEN do things when it is fired.

Edited December 29, 2017 by Differentiation

[Newww]

3 minutes ago, Matryoshika said:

You are comparing the items correctly now, yes.
However, you should be getting the ItemStack from the event itself, not from the player. (Go back to ItemStack stack = event.getItem())

And on another note, I am now seeing what I missed before. Your method takes in two arguments (the Event & Item).

This code will never be called because you have more than one arguments. Forge's EventHandler (which is the thing that goes "HEY, this happened, do your stuff") can only see static methods that need one argument, and that has to be some type of Event.
TL;DR remove the Item itemStack at the top, and put "static" after the "public", before the "void".

_________________________________________

public class StringFix {

@SubscribeEvent       
       public static void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }
}

__________________________________

Ok, that's my current code. But he still places down those tripwires :L

And about that @SubscribeEvent, I need that right?

 

And here's my main file, if there's a mistake in there lol

___________________________________________

 

package com.example.examplemod;

import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.registry.GameRegistry;
import net.minecraft.init.Blocks;
import net.minecraftforge.common.MinecraftForge;

@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
public class ExampleMod
{
    public static final String MODID = "examplemod";
    public static final String VERSION = "1.0";
    
@Mod.EventHandler
public void preInit(FMLPreInitializationEvent event) {
    
MinecraftForge.EVENT_BUS.register(new StringFix());
}
}

[Differentiation]

1 minute ago, Newww said:

_________________________________________

public class StringFix {

@SubscribeEvent       
       public static void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }
}

__________________________________

Ok, that's my current code. But he still places down those tripwires :L

And about that @SubscribeEvent, I need that right?

 

And here's my main file, if there's a mistake in there lol

___________________________________________

 

package com.example.examplemod;

import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.registry.GameRegistry;
import net.minecraft.init.Blocks;
import net.minecraftforge.common.MinecraftForge;

@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
public class ExampleMod
{
    public static final String MODID = "examplemod";
    public static final String VERSION = "1.0";
    
@Mod.EventHandler
public void preInit(FMLPreInitializationEvent event) {
    
MinecraftForge.EVENT_BUS.register(new StringFix());
}
}

Please PROPERLY set up the mod and proxies, etc. before doing anything else...

[Newww]

1 minute ago, Differentiation said:

Please PROPERLY set up the mod and proxies, etc. before doing anything else...

Why do I need any Proxies? :L

[Differentiation]

4 minutes ago, Newww said:

static

Don't use static, you don't have to have that modifier.

Edited December 29, 2017 by Differentiation

[Newww]

1 minute ago, Differentiation said:

Don't use static, you don't have to have that modifier.

Tried that before, didn't make much of a difference lol

[Differentiation]

1 minute ago, Newww said:

Tried that before, didn't make much of a difference lol

It's not supposed to, just don't use static in this case...