Jump to content

Recommended Posts

Posted (edited)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
10 minutes ago, Draco18s said:

This i can fix and will do soon

 

11 minutes ago, Draco18s said:

Problematic Code problem numbers 2, 7

If you could help me fix this that would be great

 

11 minutes ago, Draco18s said:

Code Style issue number 1

Yes i know about this but prefer doing it this way

Posted
9 hours ago, diesieben07 said:

I also prefer calling my car "tree". Very helpful in communicating with others!

well first off thanks for the helpful comment secondly is it such a big problem, like i bet there hundreds of other code styles we should all follow, I've done it this way as i find it easier, if that's an issue feel free to change it for me, if not please stop commenting

Posted

I can't tell. You have your code redirecting things all over the place and while it looks fine, I can't spot the issue.

Use the debugger.

 

One of the things that might make things easier is to not let Item classes handle their own models. There is nothing that requires access to protected values.

 

For example, if I look at my code...and ignore lines 181 to 196 (those lines handle custom state mappers and custom mesh definitions, which DO require access to protected values) you'll see that I can register all the models I need without doing anything fancy. I do use a wrapper object for the array (due to having migrated the code from 1.10 where the ModelRegistryEvent didn't exist and I was registering items and models at the same time).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
7 hours ago, Draco18s said:

I can't tell. You have your code redirecting things all over the place and while it looks fine, I can't spot the issue.

Use the debugger.

 

One of the things that might make things easier is to not let Item classes handle their own models. There is nothing that requires access to protected values.

 

For example, if I look at my code...and ignore lines 181 to 196 (those lines handle custom state mappers and custom mesh definitions, which DO require access to protected values) you'll see that I can register all the models I need without doing anything fancy. I do use a wrapper object for the array (due to having migrated the code from 1.10 where the ModelRegistryEvent didn't exist and I was registering items and models at the same time).

Finally a helpful comment thanks so much, ill defiantly look into these and see what I can come up with

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.