Jump to content
View in the app

A better way to browse. Learn more.
Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.
Search the Forums BEFORE making a new post.
Currently supported: All versions

Making pull request to MinecraftForge - Generating patches changes some numbers in files I didn't touch

Tmtravlr
in Modder Support

Featured Replies

Posted

Hey,

 

I'm creating a pull request in forge. I generated the patches with ./gradlew genPatches, but I see there are two files with a few numbers different which I didn't edit. Should I be concerned about that and remove those files from the commit, or keep them?

 

I'll attach some screenshots of the two file diffs in sourcetree. The AdvancementManager, FunctionManager, and TemplateManager changes look like they're supposed to. Hopefully someone more familiar with making pull requests knows what to do.

 

Tmtravlr.

 

Pictures:

Spoiler

EntityList:

Capture.PNG

 

Item:

Capture.PNG

Edited by Tmtravlr

  • Quote

    This sometimes happens, just leave them out. If they are indeed invalid, LexManos will eventually regenerate patches. But for PRs just ignore them and revert the changes

  • Quote
    • Author

    Hmm, all right. I'll just remove those two files from the pull request. Hopefully everything will work.

  • Quote

    • Join the conversation

    You can post now and register later. If you have an account, sign in now to post with your account.
    Note: Your post will require moderator approval before it will be visible.

    Guest
    Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
    Reply to this topic...
    Go to topic listing

    Important Information

    By using this site, you agree to our Terms of Use.

    I accept

    Configure browser push notifications
    Chrome (Android)
    1. Tap the lock icon next to the address bar.
    2. Tap Permissions → Notifications.
    3. Adjust your preference.
    Chrome (Desktop)
    1. Click the padlock icon in the address bar.
    2. Select Site settings.
    3. Find Notifications and adjust your preference.