Jump to content

Making pull request to MinecraftForge - Generating patches changes some numbers in files I didn't touch


Recommended Posts

Posted (edited)

Hey,

 

I'm creating a pull request in forge. I generated the patches with ./gradlew genPatches, but I see there are two files with a few numbers different which I didn't edit. Should I be concerned about that and remove those files from the commit, or keep them?

 

I'll attach some screenshots of the two file diffs in sourcetree. The AdvancementManager, FunctionManager, and TemplateManager changes look like they're supposed to. Hopefully someone more familiar with making pull requests knows what to do.

 

Tmtravlr.

 

Pictures:

Spoiler

EntityList:

Capture.PNG

 

Item:

Capture.PNG

Edited by Tmtravlr
Posted

This sometimes happens, just leave them out. If they are indeed invalid, LexManos will eventually regenerate patches. But for PRs just ignore them and revert the changes

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.