Jump to content

Recommended Posts

Posted

I want to preface this with I am a complete amatuer in JAVA coding, and everything I know is from YouTube tutorials, so examples of code would be greatly appreciated. I am creating a custom slab for my mod, but when doing so I am having an  issue where the double slab will not display correctly, the top slab will be invisible when placed after the bottom slab, and when trying to place a top slab first then bottom, the game will not let me place the bottom slab at all.

 

BLOCKSLABBASE.java

 

package guardia.coremod.objects.blocks.slab;

import java.util.Random;

import guardia.coremod.Main;
import guardia.coremod.init.BlockInit;
import guardia.coremod.init.ItemInit;
import guardia.coremod.utils.interfaces.IHasModel;
import net.minecraft.block.BlockSlab;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemSlab;
import net.minecraft.item.ItemStack;

public abstract class BlockSlabBase extends BlockSlab implements IHasModel
{

    public BlockSlabBase(String name) 
    {
        super(Material.WOOD);
        setUnlocalizedName(name);
        setRegistryName(name);
        setHardness(3F);
        setResistance(15F);
        setCreativeTab(Main.coretab);
        
        IBlockState state = this.blockState.getBaseState();
        if (!this.isDouble()) 
        {
            state = state.withProperty(HALF, EnumBlockHalf.BOTTOM);
        }
        setDefaultState(state);
        this.useNeighborBrightness = true;
        
        this.fullBlock = !this.isDouble();
        
        BlockInit.BLOCKS.add(this);
        
    }
    
    @Override
    public String getUnlocalizedName(int meta) 
    {
        return this.getUnlocalizedName();
    }
    
    @Override
    public IProperty<?> getVariantProperty()
    {
        return HALF;
    }
    
    @Override
    public Comparable<?> getTypeForItem(ItemStack stack)
    {
        return EnumBlockHalf.BOTTOM;
    }
    
    @Override
    public int damageDropped(IBlockState state) 
    {
        return 0;
    }

    @Override
    public IBlockState getStateFromMeta(int meta) 
    {
        if (!this.isDouble())
            return this.getDefaultState().withProperty(HALF, EnumBlockHalf.values()[meta % EnumBlockHalf.values().length]);
        return this.getDefaultState();
    }
    
    @Override
    public int getMetaFromState(IBlockState state) 
    {
        if (this.isDouble())
            return 0;
        return((EnumBlockHalf) state.getValue(HALF)).ordinal() + 1;
    }
    
    @Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune) 
    {
        return Item.getItemFromBlock(BlockInit.HALF_SLAB);
    }
    
    @Override
    protected BlockStateContainer createBlockState() 
    {
        return new BlockStateContainer(this, new IProperty[] {HALF});
    }
    
    
    
    
    
    
    
    @Override
    public void registerModels() 
    {
        Main.proxy.registerItemRenderer(Item.getItemFromBlock(this), 0, "inventory");
    }

}
 

 

REGISTRYHANDLER.java

 

package guardia.coremod.utils.handlers;

import guardia.coremod.init.BiomeInit;
import guardia.coremod.init.BlockInit;
import guardia.coremod.init.EntityInit;
import guardia.coremod.init.ItemInit;
import guardia.coremod.utils.interfaces.IHasModel;
import guardia.coremod.world.gen.WorldGenCustomOres;
import guardia.coremod.world.gen.WorldGenCustomStructures;
import guardia.coremod.world.gen.WorldGenCustomTrees;
import guardia.coremod.world.types.WorldTypeCustom;
import guardia.coremod.world.types.WorldTypeElderOak;
import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemSlab;
import net.minecraft.world.WorldType;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.registry.ForgeRegistries;
import net.minecraftforge.fml.common.registry.GameRegistry;

@EventBusSubscriber
public class RegistryHandler 
{
    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event)
    {
        event.getRegistry().registerAll(ItemInit.ITEMS.toArray(new Item[0]));
        
        ItemBlock item = new ItemSlab(BlockInit.HALF_SLAB, BlockInit.HALF_SLAB, BlockInit.DOUBLE_SLAB);
        item.setRegistryName(BlockInit.HALF_SLAB.getRegistryName());
        ForgeRegistries.ITEMS.register(item);
    }
    
    @SubscribeEvent
    public static void onBlockRegister(RegistryEvent.Register<Block> event)
    {
        event.getRegistry().registerAll(BlockInit.BLOCKS.toArray(new Block[0]));
    }
    
    @SubscribeEvent
    public static void onModelRegister(ModelRegistryEvent event)
    {
        for(Item item : ItemInit.ITEMS)
        {
            if(item instanceof IHasModel)
            {
                ((IHasModel)item).registerModels();
            }
        }
        
        for(Block block : BlockInit.BLOCKS)
        {
            if(block instanceof IHasModel)
            {
                ((IHasModel)block).registerModels();
            }
        }
    }    
    
    
    
    public static void preInitRegistries()
    {
        GameRegistry.registerWorldGenerator(new WorldGenCustomOres(), 0);
        GameRegistry.registerWorldGenerator(new WorldGenCustomTrees(), 0);
        GameRegistry.registerWorldGenerator(new WorldGenCustomStructures(), 0);
        
        BiomeInit.registerBiomes();
        
        EntityInit.registerEntities();
        RenderHandler.registerEntityRenders();
    }
    
    public static void Client() 
    {
        RecipeHandler.registerSmelting();
    }
    
    public static void initRegistries()
    {
        SoundsHandler.registerSounds();
    }
    
    public static void postInitRegistries()
    {
        WorldType ELDER_OAK = new WorldTypeElderOak();
        WorldType CUSTOM = new WorldTypeCustom();
    }
}
 

Posted

It looks close, but you should probably look at the implementation of the vanilla block slab wood blocks and try making your code even closer. For example, in your constructor you set the block state based without any variant. Now that could make sense in your case, if you only have one type of slab you're making. However, it could also screw up your blockstates and model files unless you know what you're doing.

 

So you're close, but I would personally work back and copy more of the vanilla stuff until you get it working, and only then change things if you think you need to.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • on my last computer, i had a similar problem with forge/ neoforge mods but instead them launcher screen was black
    • I am trying to make a mod, all it is, a config folder that tells another mod to not require a dependency, pretty simple right.. well, I dont want whoever downloads my mod to have to download 4 other mods and then decide if they want 2 more that they kinda really need.. i want to make my mod basically implement all of these mods, i really dont care how it does it, ive tried putting them in every file location you can think of, ive downloaded intellij, mcreator, and tried vmware but thats eh (had it from school). I downloaded them in hopes theyd create the correct file i needed but honestly im only more lost now. I have gotten my config file to work, if i put all these mods into my own mods folder and the config file into the config and it works (unvbelievably) but i want to share this to everyone else, lets just say this mod will legitimately get 7M downloads.  I tried putting them in a run folder then having it create all the contents in that for a game (mods,config..etc) then i drop the mods in and all the sudden i cant even open the game, like it literally works with my own world i play on, but i cant get it to work on any coding platform, they all have like built in java versions you cant switch, its a nightmare. I am on 1.20.1 I need Java 17 (i dont think the specific versions of 17 matter) I have even tried recreating the mods i want to implement and deleting import things like net.adamsandler.themodsname and replacing it with what mine is. that only creates other problems, where im at right now is i got the thing to start opening then it crashes, closest ive gotten it, then it just says this  exception in thread "main" cpw.mods.niofs.union.unionfilesystem$uncheckedioexception: java.util.zip.zipexception: zip end header not found caused by: java.util.zip.zipexception: zip end header not found basically saying theres something wrong with my java.exe file, so i tried downloading so many different versions of java and putting them all in so many different spots, nothing, someone online says its just a mod that isnt built right so i put the mod into an editor and bunch of errors came up, id post it but i deleted it on accident, i just need help integrating mods
    • Vanilla 1.16.5 Crash Report [#L2KYKaK] - mclo.gs  
    • Hello, probably the last update, if anyone has the same problem or this can be of any help, the answer was pretty simple, textures started rendering just using a Tesselator instead of a VertexConsumer given by a MultibufferSource and a RenderType, pretty simple
    • Finally circling back to this, and I think all of us were half right.  getChunk() does appear to immediately load the chunk, but what changed between 1.16 and 1.18 is that the list of entities is now stored in the server, not per chunk.  So while it was possible to load a chunk in 1.16 and immediately grab an entity out of it, 1.18 loads the chunk and submits a request to load its entities on the next tick (if I understand correctly).  All this to say, you can immediately access the chunk itself, however you have to wait an additional tick for its entities to load in. In my case what this means is that I do have to set up an interface to wait an additional tick before submitting the request to retrieve the entity.  However, other functions do appear to be available immediately.  Just depends on what you're trying to do. Thank you all for the help! 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.