@SubscribeEvent
    public ItemStack soulDrop(LivingDropsEvent event) {
        DamageSource source = event.getSource();
        Entity entity = source.getTrueSource();
        EntityPlayer player = (EntityPlayer) entity;
        ItemStack soul = new ItemStack(ModItems.mobSouls);
        ItemStack hand = ItemStack.EMPTY;
        hand = player.getHeldItemMainhand();
        NBTTagCompound nbt = soul.getTagCompound();

        if (event.getEntity() instanceof EntityLiving && hand.getItem() == Items.IRON_HOE) {
            event.getDrops().add(new EntityItem(event.getEntity().getEntityWorld(), event.getEntity().posX, event.getEntity().posY, event.getEntity().posZ, new ItemStack(ModItems.mobSouls)));
           if(nbt == null){ nbt = new NBTTagCompound(); }
            if(nbt.hasKey("potency")){nbt.setInteger("potency", 0);
            }else{nbt.setInteger("potency", (int) Math.random()*100);}
            soul.setTagCompound(nbt);
        }
        return soul;
    }

 

This is my code for item drop event, I have managed to do this prior in 1.10, however, I lost my prior source code.

Edited January 29, 20187 yr by quinn50

This is not always true:

EntityPlayer player = (EntityPlayer) entity;

I.e. if the entity causing the damage is not a player, your code will outright crash.

 

This is dumb:

ItemStack hand = ItemStack.EMPTY;
        hand = player.getHeldItemMainhand();

Just assign the return to the variable when you create it.

 

This gets tossed in the garbage bin:

8 minutes ago, quinn50 said:

return soul;

 

This item is the one that actually gets dropped:

event.getDrops().add(new EntityItem(event.getEntity().getEntityWorld(), event.getEntity().posX, event.getEntity().posY, event.getEntity().posZ, new ItemStack(ModItems.mobSouls)));

 

Don't see it?  It's waaaaaaaaaaaayyyyyyyyyyyyyyy over heeeeeeeeeeeeeeeeeeeeeeeeeeeerrreeeeeeeeeee:

event.getDrops().add(new EntityItem(event.getEntity().getEntityWorld(), event.getEntity().posX, event.getEntity().posY, event.getEntity().posZ, new ItemStack(ModItems.mobSouls)));
-----------------> -----------------------------------------> ----------------------------------------> -----------------------------> ------------------------^

Edited January 29, 20187 yr by Draco18s

Ok thanks for the help.