Jump to content

[1.12.2] Obtaining correct ItemStack objects for Potion Brewing


Codasylph

Recommended Posts

My mod has several custom potion types and uses BrewingRecipeRegistry to add in recipes to make them in the Brewing Stand. Unfortunately the recipes are not working correctly. When I make them they seem to take in ANY ItemStack with Items.POTIONITEM as the item and return whatever potion matches the ingredient. For example if I brew something with a feather as the ingredient I get a flight potion regardless of whether the input item is a levitation potion (like its supposed to be) or some other random potion like a vanilla Potion of Speed. 

 

This is my brewing recipe handler:

Spoiler

public class DemBrewing 
{	
	public static ItemStack redstone = new ItemStack(Items.REDSTONE);
	public static ItemStack awkwardPotion = PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM), getVanillaType("awkward"));
	public static ItemStack levitationPotion = PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM), PotionType.getPotionTypeForName("demesne:potion.levitation"));
	public static ItemStack flightPotion = PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM), PotionType.getPotionTypeForName("demesne:potion.flight"));
	public static ItemStack shrinkPotion = PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM), PotionType.getPotionTypeForName("demesne:potion.shrink"));
	
	public static void init()
	{
		BrewingRecipeRegistry.addRecipe(awkwardPotion, new ItemStack(Items.CHORUS_FRUIT_POPPED), levitationPotion);
		BrewingRecipeRegistry.addRecipe(levitationPotion, new ItemStack(Items.FEATHER), flightPotion);
		BrewingRecipeRegistry.addRecipe(awkwardPotion, new ItemStack(Item.getItemFromBlock(Blocks.BROWN_MUSHROOM)), shrinkPotion);
		BrewingRecipeRegistry.addRecipe(shrinkPotion, redstone, PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM), PotionType.getPotionTypeForName("demesne:potion.shrink_long")));
		BrewingRecipeRegistry.addRecipe(flightPotion, redstone, PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM), PotionType.getPotionTypeForName("demesne:potion.flight_long")));		
	}
	
	public static PotionType getVanillaType(String name)
	{
		return PotionType.REGISTRY.getObject(new ResourceLocation(name));
	}
}

 

 

The only explanation I could come up with was that BrewingRecipeRegistry#getOutput is not metadata sensitive. So a dug through a bit more code and found that if your IBrewingRecipe object is an instance of BrewingRecipe (like it would be if you used the function I used) then it is in fact not metadata sensitive. Soo... I guess my question is, how should I fix this? Do I need to make my own class that implements IBrewingRecipe? or is there anything else I can do?

 

Edit: its nbt not meta data that is the issue.

Edited by Codasylph
Link to comment
Share on other sites

8 hours ago, Codasylph said:

Edit: its nbt not meta data that is the issue.

You edited your post...to not edit your post. :|

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

18 hours ago, Draco18s said:

You edited your post...to not edit your post. :|

 

Umm... I edited to add to it? I'm sorry I guess? No matter. I ended up doing what i said I probably needed to do and extended AbstractBrewingRecipe and overrode isInput so the stack comparison is nbt and meta data sensitive (in case some poor person runs into the same problem I do and finds this).

Soo.. this can can probably be closed.

Link to comment
Share on other sites

What I meant was, you could have just changed the word "metadata" to "nbt data" in the paragraph.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.