1.12 What are these things in ReflectionHelper? {field_74516_a, field_74512_d, field_74512_e} etc.

[TheRPGAdventurer]

I have revived a mod from 1.8 due to requests. It has reflections in it which i'm currently new, https://pastebin.com/TjJmQr2r

I am currently having this one below in the console:

 private static final Field keybindArrayField = ReflectionHelper.findField(KeyBinding.class, "keybindArray", "field_74516_a");

I also noticed that keyBindArray are all capital letters in 1.12 while small letters in 1.8 and I also noticed that it is not just a list anymore but a hashMap some sort. I also think it has something to do with these: field_74516_a.

[Choonster]

Those are SRG (obfuscated) names. You can use MCPBot to find the corresponding MCP (deobfuscated) names.

[TheRPGAdventurer]

Just now, Choonster said:

Those are SRG (obfuscated) names. You can use MCPBot to find the corresponding MCP (deobfuscated) names.

esper can't be acessed

[Choonster]

1 hour ago, TheRPGAdventurer said:

esper can't be acessed

 

Then you can look for the MCP mapping CSV files in the Gradle cache (~/.gradle or %USERPROFILE%\.gradle); these map SRG names to MCP names. 

 

I don't have the full path with me, but look for de/oceanlabs/mcp.

[desht]

The CSV files can also be downloaded from http://export.mcpbot.bspk.rs/

 

I also find https://github.com/bspkrs/MCPMappingViewer very handy - a Java-based GUI to search for MCP symbols.

 

As for the changes in KeyBinding, there's no simple solution there other than to study the KeyBinding class in 1.8 and 1.12.2 and work out why the keybinds changed from a list to a map.  It's almost certain that the mod's code will need to be adjusted in some way to account for it, although if the mod was simply using it to iterate over, it might be a fairly simple change.

[TheRPGAdventurer]

When the classis put in the keybind_array HashMap how do I remove it?

 /**
   *  Create an Interceptor based on an existing binding.
   *  The initial interception mode is OFF.
   *  If existingKeyBinding is already a KeyBindingInterceptor, a reinitialised copy will be created but no further effect.
   * @param existingKeyBinding - the binding that will be intercepted.
   */
  public KeyBindingInterceptor(KeyBinding existingKeyBinding)
  {
    super(existingKeyBinding.getKeyDescription(), existingKeyBinding.getKeyCode(), existingKeyBinding.getKeyCategory());
    try {
      // the base constructor automatically adds the class to the keybindArray and hash, which we don't want, so undo it
        HashMap reflectkeybindArray = (HashMap) keybindArrayField.get(this);
        reflectkeybindArray.remove(this); 
        reflectkeybindArray.remove(keyDescriptionField, this);

//      List reflectkeybindArray = (List) keybindArrayField.get(this);
//      reflectkeybindArray.remove(this); 

      pressedField.setBoolean(this, false);
      pressTimeField.setInt(this, 0);
//      this.pressed = false;
//      this.pressTime = 0;

    } catch (Exception e) {
      throw Throwables.propagate(e);
    }
    this.interceptionActive = false;
    this.interceptedPressTime = 0;

    if (existingKeyBinding instanceof KeyBindingInterceptor) {
      interceptedKeyBinding = ((KeyBindingInterceptor)existingKeyBinding).getOriginalKeyBinding();
    } else {
      interceptedKeyBinding = existingKeyBinding;
    }

    KeyBinding.resetKeyBindingArrayAndHash();
    KeyBinding.updateKeyBindState();
    
  }

in List it was easy because they just used List#add() but they used put in 1.12 and put has 2 params? would we use the remove method that has 2 params?

 

1.8: 

 public KeyBinding(String description, int keyCode, String category)
    {
        this.keyDescription = description;
        this.keyCode = keyCode;
        this.keyCodeDefault = keyCode;
        this.keyCategory = category;
        keybindArray.add(this);
        hash.addKey(keyCode, this);
        keybindSet.add(category);
    }

1.12

public KeyBinding(String description, int keyCode, String category)
    {
        this.keyDescription = description;
        this.keyCode = keyCode;
        this.keyCodeDefault = keyCode;
        this.keyCategory = category;
        KEYBIND_ARRAY.put(description, this);
        HASH.addKey(keyCode, this);
        KEYBIND_SET.add(category);
    }