Jump to content

[1.12.2]Set mouse itemstack in gui


WOTBLITZ

Recommended Posts

I was making a mod that sets an item on the mouse and I was testing everything in creative mode. When I tested it on survival mode the item stack was like it was only added in client side(you can't use the item it would disappear) but it worked just fine in creative.

 

Here is the code*:

 

public static void setMouseItem(ItemStack stack)
{
	getPlayerServer().inventory.setItemStack(stack);
	getPlayerClient().inventory.setItemStack(stack);
}

public static EntityPlayer getPlayerClient()
{
	return Minecraft.getMinecraft().player;
}

public static EntityPlayer getPlayerServer()
{
	return FMLCommonHandler.instance().getMinecraftServerInstance().getPlayerList().getPlayerByUsername(getPlayerClient().getName());
}

 

*The code was based on an old discontinued mod.

Edited by WOTBLITZ
Link to comment
Share on other sites

You're reaching across logical sides here. You can't do this, as as soon as you connect to a dedicated server, it wil. crash (because on the client FMLCommonHandler.instance().getMinecraftServerInstance() will be null).

 

You must use packets for this. The reason it works in creative, is because in creative the server explicitly allows the client to alter their own inventory. In survival, this is expressly forbidden.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

This is client side only and will absolutely crash a dedicated server:

public static EntityPlayer getPlayerClient()
{
	return Minecraft.getMinecraft().player;
}

This is server side only:

public static EntityPlayer getPlayerServer()
{
    return FMLCommonHandler.instance().getMinecraftServerInstance().getPlayerList().getPlayerByUsername(...);
}

As evidenced by the "get server instance" method name.

 

This code could only ever work single player, which is why it's called "reaching across logical sides."

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

On 2/8/2018 at 1:10 AM, diesieben07 said:

No, what you are doing is known as reaching across logical sides and it is a very bad idea. This will crash as soon as you play on a server and it will cause random inexplicable crashes during normal single player gameplay.

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.