Jump to content

Getting a block's smelting recipe? (1.12)


ThatBenderGuy

Recommended Posts

I am currently in a conundrum where I need to get a smelting recipe for a block. The simplest way to put it is I have an item and it holds data for a block (modID and unlocalized name) as nbt tags. I want to gather what those blocks will smelt into. I have no clue if this is a job for the CraftingManager or for the OreDictionary. I have googled all over but can't find an answer. I want this to be compatible with other mods as well (at least the ones that have "ore" in their unlocalized name)

 

An example is lets say that my item has the nbt tags for "minecraft" and "tile.iron_ore". With those two pieces of data how can I obtain what a "tile.iron_ore" will smelt into?

Edited by ThatBenderGuy

Bumper Cars!

Link to comment
Share on other sites

Okay several things

1. Does the FurnaceRecipes.instance().getSmeltingList() return recipes from other mods?

2. I still need to get an ItemStack object from the nbt of my item (Which is currently stores strings of the modid and the unlocalized name)

 

I figured out the for-loop to go through the FurnaceRecipes map but I need to convert the string I have on my item's NBT to a ItemStack object and I have no clue how to look up tile names and return with a ItemStack.

 

 

Bumper Cars!

Link to comment
Share on other sites

Yes, other mods are supposed to add their recipes using FurnaceRecipes#addSmeltingRecipe() method, so I think the list should contain them all.

 

You should store the registry name not the unlocalized name (there is no guarantee they are the same). Then you can just read in the registry name and look it up in the ForgeRegistries.BLOCKS.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

20 minutes ago, jabelar said:

I think so. That should include the modid automatically. When you read it back, just pass the string to a new ResourceLocation() constructor.

Okay so how does this look.

// This is when the item is generated in a different class
NBTTagCompound nbt = new NBTTagCompound();
nbt.setString("parentBlock", e.getState().getBlock().getRegistryName().toString());
ore.setTagCompound(nbt);

//This is the method to get the smelting result
private ItemStack getSmeltResult(String registryName){
	Map<ItemStack, ItemStack> smeltingRecipes = FurnaceRecipes.instance().getSmeltingList();
	ResourceLocation rLoc = new ResourceLocation(registryName);
	Block block = ForgeRegistries.BLOCKS.getValue(rLoc);
	ItemStack ISBlock = new ItemStack(block);
	for (Entry<ItemStack, ItemStack> entry : smeltingRecipes.entrySet()){
		if(entry.getKey() == ISBlock){
			return entry.getValue();
		}
	}

	return new ItemStack(Items.AIR);
}

// Then what I pass into the above method
ItemStack myItem = (ItemStack)this.inventory.get(0);
ItemStack result = getSmeltResult(myItem.getTagCompound().getString("parentBlock"));

 

Edited by ThatBenderGuy

Bumper Cars!

Link to comment
Share on other sites

Yeah, the general idea looks correct. You might need to trace through to make sure there aren't any detailed bugs, but conceptually yes -- you take the smelting list, you grab the block from the block recipe, and iterate through the smelting list to find a match. For storing in NBT, store the registry name (and anything additional you care about like metadata) then read the NBT to restore it from registry (and restore any additional info you care about).

Edited by jabelar
  • Like 1

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

8 hours ago, ThatBenderGuy said:

if(entry.getKey() == ISBlock){

This won't work. ItemStacks do not override Equals (or the == operator). You need to check
 

Item bitem = Item.getFromBlock(block);
if(entry.getKey().getIem() == bitem) {
}

 

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Yeah, Draco18s is right as usual -- best to compare the Item not the stack.

 

To original poster, if you do want to compare item stacks the ItemStack class has a number of methods for comparing, some that include NBT, some don't etc. There is areItemsEqual(), areItemsEqualIgnoreDurability(), areItemEqualUsingNBT() and so forth.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Alright thank you guys for all the help.

 

In order to test that the underlying mechanic is working I added a right click event to my item and used this code to see if it gets the smelt result:

String rLoc = new ResourceLocation(nbt.getString("parentBlock")).toString();
String itemResultStr = OreRefinerRecipes.getInstance().getSmeltResult(rLoc).getDisplayName();
player.sendMessage(new TextComponentString("Stored Block Smelt Result: " + itemResultStr)); 

and it returned the proper ingots :D So assuming all my code elsewhere is correct then my main mechanic to my mod should work. Haven't been this excited to finish a mod in a while. Thank you all so very much

Edited by ThatBenderGuy
  • Like 1

Bumper Cars!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.