Hey, I'm trying to loop a method that damages an entity 3 blocks in front of the player (which works) as long as the left mouse button is held down, but the game just runs the method way too quickly to the point that the game freezes, I tried to slow this down with a modulo operator as seen below, but it doesn't work. Thanks in advance!

public static void onClick(MouseInputEvent e) {
		GameSettings gs = Minecraft.getMinecraft().gameSettings;
		EntityPlayer p = Util.getPlayerbyUUID(Minecraft.getMinecraft().player.getPersistentID());
		if(p.getCapability(PMDataProvider.PDAT, null).getMMode()) {
			p.getCapability(PMDataProvider.PDAT, null).setLSpell(new SpellBase("test", MagickaType.ARCANE, SpellComponents.Telekinetic, 1));
			while(gs.keyBindAttack.isKeyDown()) {
				if(Minecraft.getMinecraft().world.getWorldTime()%10==0) {
					p.getCapability(PMDataProvider.PDAT, null).getLSpell().activateSpell(p);
					Util.logger.info("Left Spell: "+p.getCapability(PMDataProvider.PDAT, null).getLSpell().getRegistryName());
				}
			}
			if(gs.keyBindAttack.isPressed()) {
				KeyBinding.setKeyBindState(gs.keyBindAttack.getKeyCode(), false);
			}
			
			if(gs.keyBindUseItem.isPressed()) {
				KeyBinding.setKeyBindState(gs.keyBindUseItem.getKeyCode(), false);
			}	
		}
	}

 

while(gs.keyBindAttack.isKeyDown()) {

 

Congrats, the game is now frozen until you let go.

Fantastic! 

...how would I go about checking that the key is down and then looping the effect?

 

Also the game freezes even after i let go

 

Edited March 12, 20187 yr by GooberGunter

You need to think about this in a single-threaded fashion. You want the game to do other stuff while you keep the mouse button held down which means you need to not use an infinite loop.

The game is already looping, that is what a "tick" is. So you can handle the ClientTickEvent and check for mouse button press and then do ONE loop's worth of processing.

Ugh, I don’t know why I didn’t think of using the tick event. I even have one ready to be used. I also need to do a lot more research on threads ?. Thanks a lot.

Edited March 12, 20187 yr by GooberGunter