[1.12.2[ Texture error

[Stenbergcsgo]

Hey, I've managed to create following project:

By following Loremaster's tutorials. I'm currently at the "create a custom item" phase, but my items get texture errors:

12:27:42] [main/ERROR] [TEXTURE ERRORS]: +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
[12:27:42] [main/ERROR] [TEXTURE ERRORS]: The following texture errors were found.
[12:27:42] [main/ERROR] [TEXTURE ERRORS]: ==================================================
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:   DOMAIN um
[12:27:42] [main/ERROR] [TEXTURE ERRORS]: --------------------------------------------------
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:   domain um is missing 2 textures
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:     domain um has 1 location:
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:       mod um resources at C:\Users\Frederik\Desktop\WorkspaceUno\Mod\bin
[12:27:42] [main/ERROR] [TEXTURE ERRORS]: -------------------------
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:     The missing resources for domain um are:
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:       textures/items/schematic_sign.png.png
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:       textures/items/paste.png.png
[12:27:42] [main/ERROR] [TEXTURE ERRORS]: -------------------------
[12:27:42] [main/ERROR] [TEXTURE ERRORS]:     No other errors exist for domain um
[12:27:42] [main/ERROR] [TEXTURE ERRORS]: ==================================================

As the error suggest I do believe it might be path or name related, but after triple-checking it seems like it's either not that, or I've stared myself blind. I checked the MOD_ID and it is properly put to "um", and all the naming seem to be as it should. Are there any other reasons this could happen? Hopefully someone can spot something, thank you =)

[Cadiboo]

1) 

textures/items/schematic_sign.png.png

has two file endings, is this intended?

 

2) You shouldn't add file endings to your json files (don't know if your doing this, the forge log could just be being specific)

 

3)are you prefixing your texture locations with <MODID>:<PATH>

for example my mod's id is wiptech

{
    "parent": "item/generated",
    "textures": {
        "layer0": "wiptech:items/copper_ingot"
    },
    "display": {
        "thirdperson": {
            "rotation": [-90,0,0],
            "translation": [0,1,-3],
            "scale": [0.55,0.55,0.55]
        },
        "firstperson": {
            "rotation": [0,-135,25],
            "translation": [0,4,2],
            "scale": [1.7,1.7,1.7]
        }
    }
}

 

Edited March 12, 2018 by Cadiboo

[Cadiboo]

If that doesn't fix the problem, please post In-game screenshots, the contents of paste.json and your item registration and model registration code 

[Stenbergcsgo]

Yea this is my json for the schematic_sign:

{
   "parent": "item/generated",
   "textures": {
       "layer0": "um:items/schematic_sign"
   }
}

 

[Stenbergcsgo]

More project info

IGN Image:

 

RegistryHandler.java:

package com.mta.utzonmod.util.handlers;

import com.mta.utzonmod.init.ModItems;
import com.mta.utzonmod.util.IHasModel;

import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event) {
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event) {
		for(Item item : ModItems.ITEMS) {
			if(item instanceof IHasModel) {
				((IHasModel)item).registerModels();
			}
		}
	}
}

 

IHasModel.java:

package com.mta.utzonmod.util;

public interface IHasModel {
	public void registerModels();
}

 

[Cadiboo]

2 minutes ago, Stenbergcsgo said:

((IHasModel)item).registerModels();

 

2 minutes ago, Stenbergcsgo said:

registerModels();

and this does... what?

please post that code

Edited March 12, 2018 by Cadiboo

[Cadiboo]

This is how I do it

 

@SubscribeEvent
public static void registerModels(ModelRegistryEvent event)
	{
		for (Block block: Blocks.BLOCKS)
		{
			ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, new ModelResourceLocation(block.getRegistryName(), "inventory"));
		}

		for (Item item: Items.ITEMS)
		{
			if(!item.getHasSubtypes()) {
				ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
			} else {
              //register items with subtypes
            }
        }
}

 

Blocks is a Block[] with all my blocks in it and Items is an Item[] with all my items in it

 

Edited March 12, 2018 by Cadiboo

[Stenbergcsgo]

Code from ItemBase.java overriding the registerModels() function from the IHasModel interface:

package com.mta.utzonmod.items;

import com.mta.utzonmod.Main;
import com.mta.utzonmod.init.ModItems;
import com.mta.utzonmod.util.IHasModel;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;

public class ItemBase extends Item implements IHasModel {

	public ItemBase(String name) {
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.MISC);
		
		ModItems.ITEMS.add(this);
	}
	
	@Override
	public void registerModels() {
		
		Main.proxy.registerItemRenderer(this, 0, "inventory");
		
	}
	
}

 

[Cadiboo]

6 minutes ago, Stenbergcsgo said:

Main.proxy.registerItemRenderer(this, 0, "inventory");

this code?

[Stenbergcsgo]

Yea I'm pretty new to the minecraft modding, so I'm a bit unsure about some of the functions. I've been following Loremaster's tutorials: 

, so some of the functions go unexplained. :-(

[Cadiboo]

Oh no, they register stuff inside the item class...

[Stenbergcsgo]

Is that bad?

[Cadiboo]

ItemBase.java

package com.mta.utzonmod.item;
import com.mta.utzonmod.Reference;
import net.minecraft.item.Item;
public class ItemBase extends Item
{
    
    public ItemBase(String name)
    {
        super();
        
        this.setRegistryName(Reference.ID, name);
        this.setUnlocalizedName(name);
    }
      
}

 

ItemPaste.java

package com.mta.utzonmod.item;

public class ItemPaste extends ItemBase
{
	public ItemPaste(String name)
	{
		super(name);
	}
}

 

ModItems.java

package com.mta.utzonmod.init;

import com.mta.utzonmod.item.ItemPaste;
import net.minecraft.item.Item;

public class ModItems {
  public static final ItemPaste PASTE = new ItemPaste("paste");
  
  public static final Item[] ITEMS = {
    PASTE,
  };
  
}

 

Client Registry Class (Client Proxy or similar)

 

@Mod.EventBusSubscriber
public class CLIENT_PROXY_CLASS extends COMMON_PROXY_CLASS_OR_SIMILAR
{
  @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event)
  {
    for (Item item: Items.ITEMS)
    {
      if(!item.getHasSubtypes()) {
        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
      } else {
        //do stuff
      }
    }
  }
}

 

Edited March 12, 2018 by Cadiboo
Cleaned up code

[Cadiboo]

7 minutes ago, Stenbergcsgo said:

Is that bad?

I'm not sure if its actually that bad, but I know that it leads to less clean code and lots of copy/pasted & repetitive code

[Stenbergcsgo]

Where do I put ItemPaste? Init or items?

[Cadiboo]

package com.mta.utzonmod.item;

public class ItemPaste extends ItemBase
{
	public ItemPaste(String name)
	{
		super(name);
	}
}

 

package com.mta.utzonmod.item;

[Stenbergcsgo]

my bad

[Stenbergcsgo]

Thanks for your code suggestion, I tried to converting to that, but I am now getting a few errors:

ClientProxy.java:

package com.mta.utzonmod.proxy;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@Mod.EventBusSubscriber
public class ClientProxy extends CommonProxy {
	@SubscribeEvent
	public static void registerModels(ModelRegistryEvent event)
	{
		for (Item item: Items.ITEMS)
		{
			if(!item.getHasSubtypes()) {
				ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
			} else {
//do stuff
}
}
}
}

Error: 

ITEMS can not be resolved or is not a field

 

and my RegistryHandler.java:

package com.mta.utzonmod.util.handlers;

import com.mta.utzonmod.init.ModItems;
import com.mta.utzonmod.util.IHasModel;

import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event) {
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event) {
		for(Item item : ModItems.ITEMS) {
			if(item instanceof IHasModel) {
				((IHasModel)item).registerModels();
			}
		}
	}
}

Where I get the error: 

Cannot invoke toArray(Item[]) on the array type Item[]

 

[Cadiboo]

5 minutes ago, Stenbergcsgo said:

@SubscribeEvent public static void onModelRegister(ModelRegistryEvent event) { for(Item item : ModItems.ITEMS) { if(item instanceof IHasModel) { ((IHasModel)item).registerModels(); } } }

Remove this from RegistryHandleer

[Cadiboo]

@Mod.EventBusSubscriber
public class COMMON_PROXY_OR_SIMILAR {
  @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event)
  {	
    event.getRegistry().registerAll(Items.ITEMS);
  }
}

 

[Cadiboo]

Please keep in mind that all of this is how I do it, It might not be the best way, but it looks clean and I can't find any problems with it.

 

For me, my common proxy is a mix of RegistryHandler and Common Proxy, and my Client Proxy is pretty much only used for registering models and renders etc

Edited March 12, 2018 by Cadiboo

[Stenbergcsgo]

My classes are currently as such:

ClientProxy.java:
 

package com.mta.utzonmod.proxy;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@Mod.EventBusSubscriber
public class ClientProxy extends CommonProxy {
	@SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event)
  {	
    event.getRegistry().registerAll(Items.ITEMS);
  }
}

and RegistryHandler.java:
 

package com.mta.utzonmod.util.handlers;

import com.mta.utzonmod.init.ModItems;
import com.mta.utzonmod.util.IHasModel;

import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event) {
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
}

however with same errors

[Stenbergcsgo]

I don't mind changing the method. My goal is to create a rather simple mod containing 3 custom items that hopefully should end up parsing strings. So it doesn't have to be anything too fancy, just want it to work =)

[Cadiboo]

4 minutes ago, Stenbergcsgo said:

event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));

WHY WHY WHY

NO NO NO

should have seen this earlier

This fails so many ways

1) apparently cant event turn ModItems.ITEMS into an array

maybe because it has to be used like this ModItems.ITEMS.toArray() with nothing inside the ()

2) No idea what it would try to do with (new Item[0]), but it would fail absolutely horribly and fatally.

Do you know java or any other Object Oriented language? if so you will know that toArray(new Item[0]) is completely non-sensical and guaranteed to crash everything

 

event.getRegistry().registerAll(ModItems.ITEMS);

 

Edited March 12, 2018 by Cadiboo

[Stenbergcsgo]

Should I also change the 

 event.getRegistry().registerAll(Items.ITEMS);

to 

 event.getRegistry().registerAll(ModItems.ITEMS);

in the ClientProxy.java?

 

Just tried doing so, and now the errors are gone, but the items doesn't load at all.