Help me with TESR

[Mambo_Dancer]

Help sos pls

with my TESR class

when im placing my InfusionAltar, all particles are disapearing, and >2 altars dont want to render, and speed of spinning and hovering are too dam fast, help pls

https://github.com/MamboDancer/minecraftmod/tree/master/src/main/java/ua/mambodancer/theterrifyingbeats/blocks/tileentities - link to problem code (TESRAltar)

Edited March 12, 2018 by Mambo_Dancer

[Draco18s]

  On 3/12/2018 at 4:11 PM, Mambo_Dancer said:

when im placing my InfusionAltar my another entity, that should hovering above is stucks to me 

Expand  

What?

[Mambo_Dancer]

  On 3/12/2018 at 5:07 PM, Draco18s said:

What?

Expand  

ive got a bit of progress, now its hovering properly, but all particles are disapearing when i am looking on this block, and when i place >2 of this blocks only 2 blocks are rendering with TESR

[Matryoshika]

You are rendering your item outside the pushed matrix. Move it to be rendered inside of it.

TESR's are also singletons. There is only one TESR that does the work for rendering every single tile-entity that it is bound to. If there are several loaded at the same time, then you need to compensate the rotation, either by using a variable from the TE itself, or any other "outside" data, otherwise it'll speed up by +1x times for each tile.

I would also recommend that you start to undo whatever you rendered after you are done. "Artifacts" are a type of behaviour when rendering isn't stopped once you think it has, and starts interfering with other's rendering. OpenGL artifacts are annoying and hard to track down. GLStateManager helps out a bit, but in the end artifacts shouldn't exist.

An example of "undoing" would be to translate your TESR to where you want it, render the item, then translate again with negative values, to reset it. This goes for every action you do with OpenGL.

I have a TESR that spins in all axii, as well as bobbing up and down here. You can take a look and see where your code differentiates. Do note, I'm calling other methods as well so a pure copy/paste will lead to unintended behaviour.

[Mambo_Dancer]

  On 3/12/2018 at 6:46 PM, Matryoshika said:

You are rendering your item outside the pushed matrix. Move it to be rendered inside of it.

TESR's are also singletons. There is only one TESR that does the work for rendering every single tile-entity that it is bound to. If there are several loaded at the same time, then you need to compensate the rotation, either by using a variable from the TE itself, or any other "outside" data, otherwise it'll speed up by +1x times for each tile.

I would also recommend that you start to undo whatever you rendered after you are done. "Artifacts" are a type of behaviour when rendering isn't stopped once you think it has, and starts interfering with other's rendering. OpenGL artifacts are annoying and hard to track down. GLStateManager helps out a bit, but in the end artifacts shouldn't exist.

An example of "undoing" would be to translate your TESR to where you want it, render the item, then translate again with negative values, to reset it. This goes for every action you do with OpenGL.

I have a TESR that spins in all axii, as well as bobbing up and down here. You can take a look and see where your code differentiates. Do note, I'm calling other methods as well so a pure copy/paste will lead to unintended behaviour.

Expand  

thanks alot, but most of it seems to be hard to understand coz im a beginner, i will appreciate any help with undoing as example

[Mambo_Dancer]

  On 3/12/2018 at 6:46 PM, Matryoshika said:

You are rendering your item outside the pushed matrix. Move it to be rendered inside of it.

TESR's are also singletons. There is only one TESR that does the work for rendering every single tile-entity that it is bound to. If there are several loaded at the same time, then you need to compensate the rotation, either by using a variable from the TE itself, or any other "outside" data, otherwise it'll speed up by +1x times for each tile.

I would also recommend that you start to undo whatever you rendered after you are done. "Artifacts" are a type of behaviour when rendering isn't stopped once you think it has, and starts interfering with other's rendering. OpenGL artifacts are annoying and hard to track down. GLStateManager helps out a bit, but in the end artifacts shouldn't exist.

An example of "undoing" would be to translate your TESR to where you want it, render the item, then translate again with negative values, to reset it. This goes for every action you do with OpenGL.

I have a TESR that spins in all axii, as well as bobbing up and down here. You can take a look and see where your code differentiates. Do note, I'm calling other methods as well so a pure copy/paste will lead to unintended behaviour.

Expand  

Still cant get rid of no particles, moved to inside matrix (x=0,y=0.4,z=0) and trouble still in

[Mambo_Dancer]

  On 3/12/2018 at 6:46 PM, Matryoshika said:

You are rendering your item outside the pushed matrix. Move it to be rendered inside of it.

TESR's are also singletons. There is only one TESR that does the work for rendering every single tile-entity that it is bound to. If there are several loaded at the same time, then you need to compensate the rotation, either by using a variable from the TE itself, or any other "outside" data, otherwise it'll speed up by +1x times for each tile.

I would also recommend that you start to undo whatever you rendered after you are done. "Artifacts" are a type of behaviour when rendering isn't stopped once you think it has, and starts interfering with other's rendering. OpenGL artifacts are annoying and hard to track down. GLStateManager helps out a bit, but in the end artifacts shouldn't exist.

An example of "undoing" would be to translate your TESR to where you want it, render the item, then translate again with negative values, to reset it. This goes for every action you do with OpenGL.

I have a TESR that spins in all axii, as well as bobbing up and down here. You can take a look and see where your code differentiates. Do note, I'm calling other methods as well so a pure copy/paste will lead to unintended behaviour.

Expand  

and i will be very happy if you help me with that fast rotation, cant get rid of it too((

[Matryoshika]

well, can you post your current code/update your github? Can't help if I don't know what you have & what you have done.

[Mambo_Dancer]

  On 3/12/2018 at 8:27 PM, Matryoshika said:

well, can you post your current code/update your github? Can't help if I don't know what you have & what you have done.

Expand  

done

https://github.com/MamboDancer/minecraftmod

[Matryoshika]

1. You are constantly creating a new EntityItem every frame. These will stack up, and just cause excessive cleanup for the GarbageCollector (which cleans up used memory).
   Declare a final EntityItem outside the method and just reference whenever you want to render.
2. You are completely missing a pushMatrix call.
3. You need to revert the rotation & the translation after you have rendered the EntityItem 

An example of reverting the rotation would be as I did in my code I linked earlier
 

    	GlStateManager.rotate(angle, 1, 1, 1); //Rotating everything
    	renderBody(te, x, y, z, partialTicks, destroyStage); //render the thing
    	GlStateManager.rotate(-angle, 1, 1, 1); //reverting the rotation with an equal but negative angle

 

If you want to use the same logic as I do for calculating the angle, then instead of multiplying by 100 (what you changed) you should divide by a larger number than 40 (what I used).

[Matryoshika]

  On 3/12/2018 at 9:25 PM, Matryoshika said:

1. You are constantly creating a new EntityItem every frame. These will stack up, and just cause excessive cleanup for the GarbageCollector (which cleans up used memory).
   Declare a final EntityItem outside the method and just reference whenever you want to render.
2. You are completely missing a pushMatrix call.
3. You need to revert the rotation & the translation after you have rendered the EntityItem 

An example of reverting the rotation would be as I did in my code I linked earlier
 

    	GlStateManager.rotate(angle, 1, 1, 1); //Rotating everything
    	renderBody(te, x, y, z, partialTicks, destroyStage); //render the thing
    	GlStateManager.rotate(-angle, 1, 1, 1); //reverting the rotation with an equal but negative angle

 

If you want to use the same logic as I do for calculating the angle (but slow it down), then instead of multiplying by 100 (what you changed) you should divide by a larger number than 40 (what I used).

Expand  

 

[Mambo_Dancer]

  On 3/12/2018 at 9:26 PM, Matryoshika said:

 

Expand  

so changed all, but renderBody is missing (changed to entityItem - my infusionthing ) but doesnt want to work. Im missing smthng,yes? (in my mind and skill lel)

[Draco18s]

  On 3/12/2018 at 9:25 PM, Matryoshika said:

GlStateManager.rotate(angle, 1, 1, 1); //Rotating everything

renderBody(te, x, y, z, partialTicks, destroyStage); //render the thing

GlStateManager.rotate(-angle, 1, 1, 1); //reverting the rotation with an equal but negative angle

Expand  

This is what pushMatrix and popMatrix do.

GLStateManager.pushMatrix();
GlStateManager.rotate(angle, 1, 1, 1); //Rotating everything
renderBody(te, x, y, z, partialTicks, destroyStage); //render the thing
GLStateManager.popMatrix(); //undo to the last pushMatrix

 

 

Edited March 12, 2018 by Draco18s

[Mambo_Dancer]

  On 3/12/2018 at 9:26 PM, Matryoshika said:

 

Expand  

so it worked, particularry, it doesnt want to rotate, and i have annoying name hovering above block when u lookng on block (container.infusionaltar) tried to look where it is called but my mission failed)
i do not know about forge modding so much stuff, could you recommend me some stuff where i can learn more about? thanks for help btw

[sir_titi]

  On 3/12/2018 at 9:47 PM, Mambo_Dancer said:

so it worked, particularry, it doesnt want to rotate, and i have annoying name hovering above block when u lookng on block (container.infusionaltar) tried to look where it is called but my mission failed)
i do not know about forge modding so much stuff, could you recommend me some stuff where i can learn more about? thanks for help btw

Expand  

Heya, i have taken a quick look at your TESR and you are setting the value in the render method, I would recommenced you to do this for example in the update method in your tileEntity (to update the value) and make setters and getters for that value in your tile.

So then you can call this from your TESR.

But you should also take care of the latency.

Example to explain better  :

tile.getModelAngle() * partialTickTime  <- if you are actually rotating the model

and if the data (angle) doesn't change you give it just the tile.getModelAngle()

 

real example : 

float rotation = tile.isModelRotating() ? tile.getModelAngle() + (tile.getModelAngle() - tile.getModelPrevAngle()) *partialTickTime : tile.getModelPrevAngle() + ( tile.getModelAngle() - tile.getModelPrevAngle());
GlStateManager.rotate(rotation, 0, 0, 1);

 

Hope this helps you somehow.

 

(NOTE: TESR is as far as i know multi-threaded meaning the same render method is called in "independent" threads so your "angle" in the TESR will have different values, cuss the different threads don't share there values/data to each other.

So your rotation will always be broke.

And the render method is only called when the player is actually looking at the block/tile, so is not rotating which is fine if it's just for aesthetic purpose ) 

 

Greets Sir_titi

Edited March 14, 2018 by sir_titi

[Draco18s]

  On 3/14/2018 at 7:02 PM, sir_titi said:

(NOTE: TESR is as far as i know multi-threaded meaning the same render method is called in "independent" threads so your "angle" in the TESR will have different values, cuss the different threads don't share there values/data to each other.

Expand  

What? This is literally nonsense.

"Two instances of the class" and "two threads" are completely and utterly different concepts.

[sir_titi]

  On 3/14/2018 at 7:07 PM, Draco18s said:

What? This is literally nonsense.

"Two instances of the class" and "two threads" are completely and utterly different concepts.

Expand  

Wait what do you mean?

Sorry me for being stupid

[Draco18s]

  On 3/14/2018 at 7:09 PM, sir_titi said:

Wait what do you mean?

Sorry me for being stupid

Expand  

https://en.wikipedia.org/wiki/Multithreading_(computer_architecture)

 

[Mambo_Dancer]

Guys,thanks a lot, im updated my github so u can look how my "final" code of TESR are