[Solved] Compiling FML

[panoskj]

Hey guys I'm new here, just made an account to get quick help, if possible.

 

To begin, I found a bug in vanilla Minecraft, which affects a mod I am trying to make. Luckily, there is a forge hook right after this bug appears. I thought adding 2 lines of code along with the hook will fix it. Then I would submit a PR. So, I cloned FML, set it up ('gradlew setupForge') and compiled it without any modifications ('gradlew build'). I'm not using an IDE, just notepad and command line btw. The first thing that struck me was the file size. The officially released universal jar is ~4.6MB whereas my compilation result was ~4MB. I didn't look into it any further because it did work without errors. Next step was to modify Minecraft's code and run genPatches. I did confirm the patch file was like I expected it to be and I ran 'gradlew build' again. I copied the universal jar and started Minecraft again - but my modification seemed to have no effect.

 

So, what did I do wrong? Are there any special steps that need to be taken if you modify the .patch files? I can't find much documentation on the subject. And why is there such a huge difference in file sizes?

Edited March 23, 2018 by panoskj

[Draco18s]

http://mcforge.readthedocs.io/en/latest/forgedev/#making-changes-and-pull-requests

[panoskj]

Thanks, that's the guide I followed but as you can see it is very short and not very informative. I also confirmed that a file called binpatches.pack inside the jar is modified successfully, but my changes still have no effect. Any other idea or clue?

Edited March 22, 2018 by panoskj

[Draco18s]

Ok, so the process goes like this:

 

Fork

Download your fork (use a proper git program, GitHub desktop works, but is not the greatest)

Setup

Write code

GenPatches

Push (the patches only!) to your fork. If you correctly forked and downloaded, Git will see the correct files that have been modified.

Create Pull Request

 

I have no idea what you are looking at. Not a clue. I also don't know what you mean by "your changes have no effect." No effect where?

Edited March 22, 2018 by Draco18s

[panoskj]

They had no effect when I copied the compiled universal jar into an existing Minecraft installation. But it turns out there never was a problem compiling FML.

 

What I overlooked was Optifine... it is overwriting the specific patch I wanted to make. The worst part is it's not opensource.

 

Thanks for the help, I will make a PR explaining what the issue is shortly.

[Draco18s]

6 hours ago, panoskj said:

They had no effect when I copied the compiled universal jar into an existing Minecraft installation. But it turns out there never was a problem compiling FML.

Don't bother. You can run the game in Eclipse and you don't need to validate the "compiled jar."

6 hours ago, panoskj said:

What I overlooked was Optifine... it is overwriting the specific patch I wanted to make. The worst part is it's not opensource.

And there's a reason OptiFine is not compatible with Forge.