Jump to content

[1.12.2, Botania addon] I'm making an addon to re-add the Ring of the Aesir, and need to change a method in Botania itself.


yotmam12

Recommended Posts

When the ring was removed, the methods "is<god>Ring(stack)" for each ring obviously stopped returning true for an Aesir Ring ItemStack. How can I change that back?

With the Odin ring I'm fine, and I haven't tried the Loki ring yet, but the Terra Shatterer code relies on "getThorRing(player)" which relies on "isThorRing(stack)". Do I need to learn how to use ASM, and use that to change the Botania files? Or is there another way?

Edited by yotmam12
Link to comment
Share on other sites

I'm not familiar that mod's source code. But it depends on how the value of that method is used. This ring is supposed to provide regeneration, right? So you can just replicate the effect by making a tick event handler and checking if the player is wearing the ring and then regenerate. It also gives some immunity effects, right? Then maybe you can figure out which events could be handled to create a similar effect.

 

Basically, just look at wherever the method is called and then see if there is an event which could be used to provide an equivalent effect. You might not be able to get it exactly like the original, but you could probably get pretty close.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

That's the Odin ring, you're right that it was very easy to recreate. The hard part is the Thor ring, which increases the range of the Terra Shatterer- the increase takes place in ItemTerraPick::breakOtherBlock, not in the code for the Thor Ring class. You can look at the code on github, Botania is open source.

Link to comment
Share on other sites

  • 7 months later...

You could make a new item that extends the terra shatterer and override it in the registry

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.